* [PATCH] drm/rcar-du: Add run-time dependencies
@ 2014-05-26 11:01 Jean Delvare
2014-05-26 11:36 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Jean Delvare @ 2014-05-26 11:01 UTC (permalink / raw)
To: dri-devel; +Cc: Laurent Pinchart
The Renesas R-Car Display Unit driver is only useful on shmobile
unless build testing. The LVDS output is useful on an even more
reduced hardware set.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: David Airlie <airlied@linux.ie>
---
drivers/gpu/drm/rcar-du/Kconfig | 2 ++
1 file changed, 2 insertions(+)
--- linux-3.15-rc6.orig/drivers/gpu/drm/rcar-du/Kconfig 2014-03-31 05:40:15.000000000 +0200
+++ linux-3.15-rc6/drivers/gpu/drm/rcar-du/Kconfig 2014-05-23 18:03:16.440036942 +0200
@@ -1,6 +1,7 @@
config DRM_RCAR_DU
tristate "DRM Support for R-Car Display Unit"
depends on DRM && ARM
+ depends on ARCH_SHMOBILE || COMPILE_TEST
select DRM_KMS_HELPER
select DRM_KMS_CMA_HELPER
select DRM_GEM_CMA_HELPER
@@ -12,6 +13,7 @@ config DRM_RCAR_DU
config DRM_RCAR_LVDS
bool "R-Car DU LVDS Encoder Support"
depends on DRM_RCAR_DU
+ depends on ARCH_R8A7790 || ARCH_R8A7791 || COMPILE_TEST
help
Enable support the R-Car Display Unit embedded LVDS encoders
(currently only on R8A7790).
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/rcar-du: Add run-time dependencies
2014-05-26 11:01 [PATCH] drm/rcar-du: Add run-time dependencies Jean Delvare
@ 2014-05-26 11:36 ` Laurent Pinchart
2014-05-26 12:21 ` Jean Delvare
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2014-05-26 11:36 UTC (permalink / raw)
To: Jean Delvare, David Airlie; +Cc: dri-devel
Hi Jean,
Thank you for the patch.
On Monday 26 May 2014 13:01:35 Jean Delvare wrote:
> The Renesas R-Car Display Unit driver is only useful on shmobile
> unless build testing. The LVDS output is useful on an even more
> reduced hardware set.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: David Airlie <airlied@linux.ie>
> ---
> drivers/gpu/drm/rcar-du/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-3.15-rc6.orig/drivers/gpu/drm/rcar-du/Kconfig 2014-03-31
> 05:40:15.000000000 +0200 +++
> linux-3.15-rc6/drivers/gpu/drm/rcar-du/Kconfig 2014-05-23
> 18:03:16.440036942 +0200 @@ -1,6 +1,7 @@
> config DRM_RCAR_DU
> tristate "DRM Support for R-Car Display Unit"
> depends on DRM && ARM
Have you checked whether ARM is needed for compilation ? If not you could drop
it.
> + depends on ARCH_SHMOBILE || COMPILE_TEST
> select DRM_KMS_HELPER
> select DRM_KMS_CMA_HELPER
> select DRM_GEM_CMA_HELPER
> @@ -12,6 +13,7 @@ config DRM_RCAR_DU
> config DRM_RCAR_LVDS
> bool "R-Car DU LVDS Encoder Support"
> depends on DRM_RCAR_DU
> + depends on ARCH_R8A7790 || ARCH_R8A7791 || COMPILE_TEST
> help
> Enable support the R-Car Display Unit embedded LVDS encoders
> (currently only on R8A7790).
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/rcar-du: Add run-time dependencies
2014-05-26 11:36 ` Laurent Pinchart
@ 2014-05-26 12:21 ` Jean Delvare
2014-05-26 12:50 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Jean Delvare @ 2014-05-26 12:21 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: dri-devel
Hi Laurent,
On Mon, 26 May 2014 13:36:11 +0200, Laurent Pinchart wrote:
> Thank you for the patch.
You're welcome. And thanks for your help :-)
> On Monday 26 May 2014 13:01:35 Jean Delvare wrote:
> > The Renesas R-Car Display Unit driver is only useful on shmobile
> > unless build testing. The LVDS output is useful on an even more
> > reduced hardware set.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Cc: David Airlie <airlied@linux.ie>
> > ---
> > drivers/gpu/drm/rcar-du/Kconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > --- linux-3.15-rc6.orig/drivers/gpu/drm/rcar-du/Kconfig 2014-03-31
> > 05:40:15.000000000 +0200 +++
> > linux-3.15-rc6/drivers/gpu/drm/rcar-du/Kconfig 2014-05-23
> > 18:03:16.440036942 +0200 @@ -1,6 +1,7 @@
> > config DRM_RCAR_DU
> > tristate "DRM Support for R-Car Display Unit"
> > depends on DRM && ARM
>
> Have you checked whether ARM is needed for compilation ? If not you could drop
> it.
It does depend on ARM indirectly, because it selects DRM_GEM_CMA_HELPER
which builds code that calls dma_alloc_writecombine(), which in turn is
only defined on arm (and avr32.) That's why I left the build-time
dependency on ARM.
>
> > + depends on ARCH_SHMOBILE || COMPILE_TEST
> > select DRM_KMS_HELPER
> > select DRM_KMS_CMA_HELPER
> > select DRM_GEM_CMA_HELPER
> > @@ -12,6 +13,7 @@ config DRM_RCAR_DU
> > config DRM_RCAR_LVDS
> > bool "R-Car DU LVDS Encoder Support"
> > depends on DRM_RCAR_DU
> > + depends on ARCH_R8A7790 || ARCH_R8A7791 || COMPILE_TEST
> > help
> > Enable support the R-Car Display Unit embedded LVDS encoders
> > (currently only on R8A7790).
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/rcar-du: Add run-time dependencies
2014-05-26 12:21 ` Jean Delvare
@ 2014-05-26 12:50 ` Laurent Pinchart
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2014-05-26 12:50 UTC (permalink / raw)
To: Jean Delvare; +Cc: dri-devel
Hi Jean,
On Monday 26 May 2014 14:21:30 Jean Delvare wrote:
> On Mon, 26 May 2014 13:36:11 +0200, Laurent Pinchart wrote:
> > On Monday 26 May 2014 13:01:35 Jean Delvare wrote:
> > > The Renesas R-Car Display Unit driver is only useful on shmobile
> > > unless build testing. The LVDS output is useful on an even more
> > > reduced hardware set.
> > >
> > > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > Cc: David Airlie <airlied@linux.ie>
> > > ---
> > >
> > > drivers/gpu/drm/rcar-du/Kconfig | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > --- linux-3.15-rc6.orig/drivers/gpu/drm/rcar-du/Kconfig 2014-03-31
> > > 05:40:15.000000000 +0200 +++
> > > linux-3.15-rc6/drivers/gpu/drm/rcar-du/Kconfig 2014-05-23
> > > 18:03:16.440036942 +0200 @@ -1,6 +1,7 @@
> > > config DRM_RCAR_DU
> > > tristate "DRM Support for R-Car Display Unit"
> > > depends on DRM && ARM
> >
> > Have you checked whether ARM is needed for compilation ? If not you could
> > drop it.
>
> It does depend on ARM indirectly, because it selects DRM_GEM_CMA_HELPER
> which builds code that calls dma_alloc_writecombine(), which in turn is
> only defined on arm (and avr32.) That's why I left the build-time
> dependency on ARM.
In that case,
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > + depends on ARCH_SHMOBILE || COMPILE_TEST
> > > select DRM_KMS_HELPER
> > > select DRM_KMS_CMA_HELPER
> > > select DRM_GEM_CMA_HELPER
> > > @@ -12,6 +13,7 @@ config DRM_RCAR_DU
> > > config DRM_RCAR_LVDS
> > > bool "R-Car DU LVDS Encoder Support"
> > > depends on DRM_RCAR_DU
> > > + depends on ARCH_R8A7790 || ARCH_R8A7791 || COMPILE_TEST
> > > help
> > > Enable support the R-Car Display Unit embedded LVDS encoders
> > > (currently only on R8A7790).
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-26 12:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-26 11:01 [PATCH] drm/rcar-du: Add run-time dependencies Jean Delvare
2014-05-26 11:36 ` Laurent Pinchart
2014-05-26 12:21 ` Jean Delvare
2014-05-26 12:50 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.