From: Johan Jonker <jbx6244@gmail.com>
To: Rob Herring <robh@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/arm: dts: rockchip: Fix DSI node names
Date: Sun, 19 Mar 2023 20:36:20 +0100 [thread overview]
Message-ID: <591bf126-1ab7-8a5d-0d3a-1cac4cd9b112@gmail.com> (raw)
In-Reply-To: <20230319174105.43978-1-robh@kernel.org>
On 3/19/23 18:41, Rob Herring wrote:
> DSI bus/controller nodes should be named 'dsi' rather than 'mipi'.
There's already a serie that does that.
Lack of communication becomes common.
More thing must be fixed to comply then this patch alone.
[PATCH v6 09/17] ARM: dts: rockchip: rk3288: fix dsi node
https://lore.kernel.org/linux-rockchip/f3edcbff-4aef-1d24-8d65-e519c9451cda@gmail.com/
[PATCH v6 15/17] arm64: dts: rockchip: rk3399: fix dp node
https://lore.kernel.org/linux-rockchip/f6008819-db9b-0944-3f5b-5522b7cd8a8d@gmail.com/
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 2 +-
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 2ca76b69add7..d401b850583c 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1114,7 +1114,7 @@ vopl_mmu: iommu@ff940300 {
> status = "disabled";
> };
>
> - mipi_dsi: mipi@ff960000 {
> + mipi_dsi: dsi@ff960000 {
> compatible = "rockchip,rk3288-mipi-dsi", "snps,dw-mipi-dsi";
> reg = <0x0 0xff960000 0x0 0x4000>;
> interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 1881b4b71f91..e44e1c40c0ba 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1954,7 +1954,7 @@ hdmi_in_vopl: endpoint@1 {
> };
> };
>
> - mipi_dsi: mipi@ff960000 {
> + mipi_dsi: dsi@ff960000 {
> compatible = "rockchip,rk3399-mipi-dsi", "snps,dw-mipi-dsi";
> reg = <0x0 0xff960000 0x0 0x8000>;
> interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH 0>;
> @@ -1990,7 +1990,7 @@ mipi_in_vopl: endpoint@1 {
> };
> };
>
> - mipi_dsi1: mipi@ff968000 {
> + mipi_dsi1: dsi@ff968000 {
> compatible = "rockchip,rk3399-mipi-dsi", "snps,dw-mipi-dsi";
> reg = <0x0 0xff968000 0x0 0x8000>;
> interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH 0>;
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: Rob Herring <robh@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/arm: dts: rockchip: Fix DSI node names
Date: Sun, 19 Mar 2023 20:36:20 +0100 [thread overview]
Message-ID: <591bf126-1ab7-8a5d-0d3a-1cac4cd9b112@gmail.com> (raw)
In-Reply-To: <20230319174105.43978-1-robh@kernel.org>
On 3/19/23 18:41, Rob Herring wrote:
> DSI bus/controller nodes should be named 'dsi' rather than 'mipi'.
There's already a serie that does that.
Lack of communication becomes common.
More thing must be fixed to comply then this patch alone.
[PATCH v6 09/17] ARM: dts: rockchip: rk3288: fix dsi node
https://lore.kernel.org/linux-rockchip/f3edcbff-4aef-1d24-8d65-e519c9451cda@gmail.com/
[PATCH v6 15/17] arm64: dts: rockchip: rk3399: fix dp node
https://lore.kernel.org/linux-rockchip/f6008819-db9b-0944-3f5b-5522b7cd8a8d@gmail.com/
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 2 +-
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 2ca76b69add7..d401b850583c 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1114,7 +1114,7 @@ vopl_mmu: iommu@ff940300 {
> status = "disabled";
> };
>
> - mipi_dsi: mipi@ff960000 {
> + mipi_dsi: dsi@ff960000 {
> compatible = "rockchip,rk3288-mipi-dsi", "snps,dw-mipi-dsi";
> reg = <0x0 0xff960000 0x0 0x4000>;
> interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 1881b4b71f91..e44e1c40c0ba 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1954,7 +1954,7 @@ hdmi_in_vopl: endpoint@1 {
> };
> };
>
> - mipi_dsi: mipi@ff960000 {
> + mipi_dsi: dsi@ff960000 {
> compatible = "rockchip,rk3399-mipi-dsi", "snps,dw-mipi-dsi";
> reg = <0x0 0xff960000 0x0 0x8000>;
> interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH 0>;
> @@ -1990,7 +1990,7 @@ mipi_in_vopl: endpoint@1 {
> };
> };
>
> - mipi_dsi1: mipi@ff968000 {
> + mipi_dsi1: dsi@ff968000 {
> compatible = "rockchip,rk3399-mipi-dsi", "snps,dw-mipi-dsi";
> reg = <0x0 0xff968000 0x0 0x8000>;
> interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH 0>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: Rob Herring <robh@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/arm: dts: rockchip: Fix DSI node names
Date: Sun, 19 Mar 2023 20:36:20 +0100 [thread overview]
Message-ID: <591bf126-1ab7-8a5d-0d3a-1cac4cd9b112@gmail.com> (raw)
In-Reply-To: <20230319174105.43978-1-robh@kernel.org>
On 3/19/23 18:41, Rob Herring wrote:
> DSI bus/controller nodes should be named 'dsi' rather than 'mipi'.
There's already a serie that does that.
Lack of communication becomes common.
More thing must be fixed to comply then this patch alone.
[PATCH v6 09/17] ARM: dts: rockchip: rk3288: fix dsi node
https://lore.kernel.org/linux-rockchip/f3edcbff-4aef-1d24-8d65-e519c9451cda@gmail.com/
[PATCH v6 15/17] arm64: dts: rockchip: rk3399: fix dp node
https://lore.kernel.org/linux-rockchip/f6008819-db9b-0944-3f5b-5522b7cd8a8d@gmail.com/
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 2 +-
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 2ca76b69add7..d401b850583c 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1114,7 +1114,7 @@ vopl_mmu: iommu@ff940300 {
> status = "disabled";
> };
>
> - mipi_dsi: mipi@ff960000 {
> + mipi_dsi: dsi@ff960000 {
> compatible = "rockchip,rk3288-mipi-dsi", "snps,dw-mipi-dsi";
> reg = <0x0 0xff960000 0x0 0x4000>;
> interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 1881b4b71f91..e44e1c40c0ba 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1954,7 +1954,7 @@ hdmi_in_vopl: endpoint@1 {
> };
> };
>
> - mipi_dsi: mipi@ff960000 {
> + mipi_dsi: dsi@ff960000 {
> compatible = "rockchip,rk3399-mipi-dsi", "snps,dw-mipi-dsi";
> reg = <0x0 0xff960000 0x0 0x8000>;
> interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH 0>;
> @@ -1990,7 +1990,7 @@ mipi_in_vopl: endpoint@1 {
> };
> };
>
> - mipi_dsi1: mipi@ff968000 {
> + mipi_dsi1: dsi@ff968000 {
> compatible = "rockchip,rk3399-mipi-dsi", "snps,dw-mipi-dsi";
> reg = <0x0 0xff968000 0x0 0x8000>;
> interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH 0>;
next prev parent reply other threads:[~2023-03-19 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 17:41 [PATCH] arm64/arm: dts: rockchip: Fix DSI node names Rob Herring
2023-03-19 17:41 ` Rob Herring
2023-03-19 17:41 ` Rob Herring
2023-03-19 19:36 ` Johan Jonker [this message]
2023-03-19 19:36 ` Johan Jonker
2023-03-19 19:36 ` Johan Jonker
2023-03-22 23:45 ` Heiko Stuebner
2023-03-22 23:45 ` Heiko Stuebner
2023-03-22 23:45 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591bf126-1ab7-8a5d-0d3a-1cac4cd9b112@gmail.com \
--to=jbx6244@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.