From: Daniel Borkmann <daniel@iogearbox.net>
To: David Miller <davem@davemloft.net>
Cc: garsilva@embeddedor.com, ast@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: bpf: remove dead code
Date: Mon, 22 May 2017 19:00:14 +0200 [thread overview]
Message-ID: <5923191E.30804@iogearbox.net> (raw)
In-Reply-To: <20170522.122742.1326733219925627993.davem@davemloft.net>
On 05/22/2017 06:27 PM, David Miller wrote:
[...]
> Ok I understand the issue now. Thanks for explaining.
>
> I guess a hard-coded value of 2 and an adjusted comment above the
> assignment of ip_align is the way to go.
>
> I'll push the following, thanks everyone:
>
> ====================
> net: Make IP alignment calulations clearer.
>
> The assignmnet:
>
> ip_align = strict ? 2 : NET_IP_ALIGN;
>
> in compare_pkt_ptr_alignment() trips up Coverity because we can only
> get to this code when strict is true, therefore ip_align will always
> be 2 regardless of NET_IP_ALIGN's value.
>
> So just assign directly to '2' and explain the situation in the
> comment above.
>
> Reported-by: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Yeah, that's fine, thanks!
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
prev parent reply other threads:[~2017-05-22 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 14:07 [PATCH] kernel: bpf: remove dead code Gustavo A. R. Silva
2017-05-22 14:38 ` David Miller
2017-05-22 14:51 ` Gustavo A. R. Silva
2017-05-22 14:51 ` Gustavo A. R. Silva
2017-05-22 14:52 ` Daniel Borkmann
2017-05-22 16:27 ` David Miller
2017-05-22 17:00 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5923191E.30804@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=garsilva@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.