All of lore.kernel.org
 help / color / mirror / Atom feed
From: puck.chen@hisilicon.com (Chen Feng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] reset: hisilicon: Fix hi6220 module license
Date: Fri, 26 May 2017 11:12:59 +0800	[thread overview]
Message-ID: <59279D3B.6090804@hisilicon.com> (raw)
In-Reply-To: <20170525092232.27960-1-afaerber@suse.de>

looks good to me.

On 2017/5/25 17:22, Andreas F?rber wrote:
> The hi6220_reset driver fails to load:
>
>   [   10.423640] hi6220_reset: module license 'unspecified' taints kernel.
>   [   10.423644] Disabling lock debugging due to kernel taint
>   [   10.423735] hi6220_reset: Unknown symbol regmap_write (err 0)
>   [   10.423747] hi6220_reset: Unknown symbol devm_kmalloc (err 0)
>   [   10.423759] hi6220_reset: Unknown symbol syscon_node_to_regmap (err 0)
>   [   10.423768] hi6220_reset: Unknown symbol reset_controller_register (err 0)
>   [   10.423784] hi6220_reset: Unknown symbol __platform_driver_register (err 0)
>
> Add a MODULE_LICENSE() to fix this.
>
> Fixes: 70b3590f639f ("reset: hi6220: fix modular build")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Andreas F?rber <afaerber@suse.de>
> ---
>  drivers/reset/hisilicon/hi6220_reset.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
> index 35ce53edabf9..d5e5229308f2 100644
> --- a/drivers/reset/hisilicon/hi6220_reset.c
> +++ b/drivers/reset/hisilicon/hi6220_reset.c
> @@ -155,3 +155,5 @@ static int __init hi6220_reset_init(void)
>  }
>  
>  postcore_initcall(hi6220_reset_init);
> +
> +MODULE_LICENSE("GPL v2");

WARNING: multiple messages have this Message-ID (diff)
From: Chen Feng <puck.chen@hisilicon.com>
To: "Andreas Färber" <afaerber@suse.de>,
	linux-arm-kernel@lists.infradead.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] reset: hisilicon: Fix hi6220 module license
Date: Fri, 26 May 2017 11:12:59 +0800	[thread overview]
Message-ID: <59279D3B.6090804@hisilicon.com> (raw)
In-Reply-To: <20170525092232.27960-1-afaerber@suse.de>

looks good to me.

On 2017/5/25 17:22, Andreas Färber wrote:
> The hi6220_reset driver fails to load:
>
>   [   10.423640] hi6220_reset: module license 'unspecified' taints kernel.
>   [   10.423644] Disabling lock debugging due to kernel taint
>   [   10.423735] hi6220_reset: Unknown symbol regmap_write (err 0)
>   [   10.423747] hi6220_reset: Unknown symbol devm_kmalloc (err 0)
>   [   10.423759] hi6220_reset: Unknown symbol syscon_node_to_regmap (err 0)
>   [   10.423768] hi6220_reset: Unknown symbol reset_controller_register (err 0)
>   [   10.423784] hi6220_reset: Unknown symbol __platform_driver_register (err 0)
>
> Add a MODULE_LICENSE() to fix this.
>
> Fixes: 70b3590f639f ("reset: hi6220: fix modular build")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  drivers/reset/hisilicon/hi6220_reset.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
> index 35ce53edabf9..d5e5229308f2 100644
> --- a/drivers/reset/hisilicon/hi6220_reset.c
> +++ b/drivers/reset/hisilicon/hi6220_reset.c
> @@ -155,3 +155,5 @@ static int __init hi6220_reset_init(void)
>  }
>  
>  postcore_initcall(hi6220_reset_init);
> +
> +MODULE_LICENSE("GPL v2");

  reply	other threads:[~2017-05-26  3:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25  9:22 [PATCH] reset: hisilicon: Fix hi6220 module license Andreas Färber
2017-05-25  9:22 ` Andreas Färber
2017-05-26  3:12 ` Chen Feng [this message]
2017-05-26  3:12   ` Chen Feng
2017-05-26  8:44 ` Arnd Bergmann
2017-05-26  8:44   ` Arnd Bergmann
2017-05-26  9:25   ` Andreas Färber
2017-05-26  9:25     ` Andreas Färber
2017-05-29  9:46 ` Philipp Zabel
2017-05-29  9:46   ` Philipp Zabel
2017-05-29 13:07   ` Andreas Färber
2017-05-29 13:07     ` Andreas Färber
2017-05-30  8:43     ` Philipp Zabel
2017-05-30  8:43       ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59279D3B.6090804@hisilicon.com \
    --to=puck.chen@hisilicon.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.