From: Stefan Bruens <stefan.bruens@rwth-aachen.de>
To: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/edid: Tighten checksum conditions for CEA blocks
Date: Sun, 23 Nov 2014 03:53:43 +0100 [thread overview]
Message-ID: <5929818.WJzQo7qZms@pebbles.site> (raw)
In-Reply-To: <87389csmeb.fsf@intel.com>
On Friday 21 November 2014 15:39:40 you wrote:
> I still feel like this should be embedded in drm_edid_block_valid
> somehow. Who's going to print the bad edid now? Is it simply no longer
> printed in this loop?
>
> I'll defer to others; any better suggestions?
>
> Jani.
>
This can not be embedded in drm_edid_block_valid, as the function is
completely "passive", but we must be able to trigger a retransmission of the
bad block.
Regarding printing, this should be added.
Thinking about it, maybe factor out the printing routine, and add the zero
block handling to it?
Kind regards,
Stefan
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2014-11-23 2:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1416103472-16923-1-git-send-email-stefan.bruens@rwth-aachen.de>
2014-11-20 2:25 ` [PATCH] drm/edid: shorten log output in case of all zeroes edid block Stefan Brüns
2014-11-21 13:32 ` Jani Nikula
2014-11-23 2:21 ` [PATCH 1/2] drm/edid: move drm_edid_is_zero to top, make edid argument const Stefan Brüns
[not found] ` <1416709265-31437-1-git-send-email-stefan.bruens@rwth-aachen.de>
2014-11-23 2:21 ` [PATCH 2/2] drm/edid: shorten log output in case of all zeroes edid block V2 Stefan Brüns
2014-11-20 2:27 ` [PATCH 1/3] drm/edid: new drm_edid_block_checksum helper function Stefan Brüns
2014-11-21 13:34 ` Jani Nikula
2014-11-23 2:40 ` [PATCH 1/3] drm/edid: new drm_edid_block_checksum helper function V2 Stefan Brüns
2014-11-24 7:50 ` Jani Nikula
[not found] ` <1416450460-3692-1-git-send-email-stefan.bruens@rwth-aachen.de>
2014-11-20 2:27 ` [PATCH 2/3] drm/edid: calculate address of current extension block only once Stefan Brüns
2014-11-21 13:35 ` Jani Nikula
2014-11-20 2:27 ` [PATCH 3/3] drm/edid: Tighten checksum conditions for CEA blocks Stefan Brüns
2014-11-21 13:39 ` Jani Nikula
2014-11-23 2:53 ` Stefan Bruens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5929818.WJzQo7qZms@pebbles.site \
--to=stefan.bruens@rwth-aachen.de \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.