From: Jani Nikula <jani.nikula@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: stefan.bruens@rwth-aachen.de
Subject: Re: [PATCH 2/3] drm/edid: calculate address of current extension block only once
Date: Fri, 21 Nov 2014 15:35:18 +0200 [thread overview]
Message-ID: <8761e8smll.fsf@intel.com> (raw)
In-Reply-To: <2fd77d8b-a0a0-4961-8670-358d469b90a5@HUB1.rwth-ad.de>
On Thu, 20 Nov 2014, Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote:
> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/drm_edid.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index b072041..3a10f3f 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -1232,12 +1232,11 @@ drm_do_get_edid(struct drm_connector *connector, struct i2c_adapter *adapter)
> block = new;
>
> for (j = 1; j <= block[0x7e]; j++) {
> + u8 *ext_block = block + (valid_extensions + 1) * EDID_LENGTH;
> for (i = 0; i < 4; i++) {
> - if (drm_do_probe_ddc_edid(adapter,
> - block + (valid_extensions + 1) * EDID_LENGTH,
> - j, EDID_LENGTH))
> + if (drm_do_probe_ddc_edid(adapter, ext_block, j, EDID_LENGTH))
> goto out;
> - if (drm_edid_block_valid(block + (valid_extensions + 1) * EDID_LENGTH, j, print_bad_edid)) {
> + if (drm_edid_block_valid(ext_block, j, print_bad_edid)) {
> valid_extensions++;
> break;
> }
> --
> 2.1.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-11-21 13:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1416103472-16923-1-git-send-email-stefan.bruens@rwth-aachen.de>
2014-11-20 2:25 ` [PATCH] drm/edid: shorten log output in case of all zeroes edid block Stefan Brüns
2014-11-21 13:32 ` Jani Nikula
2014-11-23 2:21 ` [PATCH 1/2] drm/edid: move drm_edid_is_zero to top, make edid argument const Stefan Brüns
[not found] ` <1416709265-31437-1-git-send-email-stefan.bruens@rwth-aachen.de>
2014-11-23 2:21 ` [PATCH 2/2] drm/edid: shorten log output in case of all zeroes edid block V2 Stefan Brüns
2014-11-20 2:27 ` [PATCH 1/3] drm/edid: new drm_edid_block_checksum helper function Stefan Brüns
2014-11-21 13:34 ` Jani Nikula
2014-11-23 2:40 ` [PATCH 1/3] drm/edid: new drm_edid_block_checksum helper function V2 Stefan Brüns
2014-11-24 7:50 ` Jani Nikula
[not found] ` <1416450460-3692-1-git-send-email-stefan.bruens@rwth-aachen.de>
2014-11-20 2:27 ` [PATCH 2/3] drm/edid: calculate address of current extension block only once Stefan Brüns
2014-11-21 13:35 ` Jani Nikula [this message]
2014-11-20 2:27 ` [PATCH 3/3] drm/edid: Tighten checksum conditions for CEA blocks Stefan Brüns
2014-11-21 13:39 ` Jani Nikula
2014-11-23 2:53 ` Stefan Bruens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761e8smll.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=stefan.bruens@rwth-aachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.