All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aníbal Limón" <anibal.limon@linux.intel.com>
To: Patrick Ohly <patrick.ohly@intel.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/6] yocto-compat-layer.py: apply test_signatures to all layers
Date: Mon, 29 May 2017 11:13:49 -0500	[thread overview]
Message-ID: <592C48BD.5020107@linux.intel.com> (raw)
In-Reply-To: <c8d26bf705a207b8f639c966f811bbb15556038c.1496071841.git-series.patrick.ohly@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

On 05/29/2017 10:32 AM, Patrick Ohly wrote:
> Software layers were previously allowed to change signatures, but
> that's not desired for those layers either. The rule that a layer
> which is "Yocto Compatible 2.0" must not change signatures unless
> explicitly requested holds for all kinds of layers.

If i understand correctly now a software layer can't change a signature
but how do we handle this?, currently if a software layer is added and
has bbappends or newer version of a recipe the signature will change.

May be we need to postpone this validation removal until we have a
manner to avoid a software layer automatically change the signatures.

Cheers,
Anibal


> 
> Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
> ---
>  scripts/lib/compatlayer/cases/common.py | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/scripts/lib/compatlayer/cases/common.py b/scripts/lib/compatlayer/cases/common.py
> index 2dfcbb1..fe4936e 100644
> --- a/scripts/lib/compatlayer/cases/common.py
> +++ b/scripts/lib/compatlayer/cases/common.py
> @@ -27,10 +27,6 @@ class CommonCompatLayer(OECompatLayerTestCase):
>                        'bitbake -e')
>  
>      def test_signatures(self):
> -        if self.tc.layer['type'] == LayerType.SOFTWARE:
> -            raise unittest.SkipTest("Layer %s isn't BSP or DISTRO one." \
> -                     % self.tc.layer['name'])
> -
>          # task -> (old signature, new signature)
>          sig_diff = {}
>          curr_sigs, _ = get_signatures(self.td['builddir'], failsafe=True)
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2017-05-29 16:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-29 15:32 [PATCH 0/6] yocto-compat-layer.py: various enhancements Patrick Ohly
2017-05-29 15:32 ` [PATCH 1/6] yocto-compat-layer.py: avoid adding layers more than once Patrick Ohly
2017-05-29 15:32 ` [PATCH 2/6] yocto-compat-layer.py: tolerate broken world builds during signature diff Patrick Ohly
2017-05-29 15:32 ` [PATCH 3/6] yocto-compat-layer.py: apply test_signatures to all layers Patrick Ohly
2017-05-29 16:13   ` Aníbal Limón [this message]
2017-05-29 19:18     ` Patrick Ohly
2017-05-29 19:26       ` Aníbal Limón
2017-05-29 20:14         ` Christopher Larson
2017-05-30  6:51           ` Patrick Ohly
2017-05-29 15:32 ` [PATCH 4/6] yocto-compat-layer.py: add test_world Patrick Ohly
2017-05-29 15:32 ` [PATCH 5/6] yocto-compat-layer.py: allow README with suffix Patrick Ohly
2017-05-29 15:32 ` [PATCH 6/6] yocto-compat-layer.py: make signature check code reusable Patrick Ohly
2017-05-29 16:15 ` [PATCH 0/6] yocto-compat-layer.py: various enhancements Aníbal Limón
2017-06-27 15:33 ` [PATCH v2 " Patrick Ohly
2017-06-27 15:33   ` [PATCH v2 1/6] yocto-compat-layer.py: avoid adding layers more than once Patrick Ohly
2017-06-27 22:46     ` Christopher Larson
2017-06-28  7:50       ` Patrick Ohly
2017-06-28  9:06         ` Mark Hatle
2017-06-27 15:33   ` [PATCH v2 2/6] yocto-compat-layer.py: tolerate broken world builds during signature diff Patrick Ohly
2017-06-27 15:33   ` [PATCH v2 3/6] yocto-compat-layer.py: apply test_signatures to all layers Patrick Ohly
2017-06-28  9:08     ` Mark Hatle
2017-06-28  9:33       ` Patrick Ohly
2017-06-30  9:17         ` Mark Hatle
2017-06-27 15:33   ` [PATCH v2 4/6] yocto-compat-layer.py: add test_world Patrick Ohly
2017-06-27 15:33   ` [PATCH v2 5/6] yocto-compat-layer.py: allow README with suffix Patrick Ohly
2017-06-27 15:33   ` [PATCH v2 6/6] yocto-compat-layer.py: make signature check code reusable Patrick Ohly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=592C48BD.5020107@linux.intel.com \
    --to=anibal.limon@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=patrick.ohly@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.