From: "Aníbal Limón" <anibal.limon@linux.intel.com>
To: Patrick Ohly <patrick.ohly@intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 0/6] yocto-compat-layer.py: various enhancements
Date: Mon, 29 May 2017 11:15:44 -0500 [thread overview]
Message-ID: <592C4930.3080600@linux.intel.com> (raw)
In-Reply-To: <cover.393a6efac99077bd222866024d8e18f371414195.1496071841.git-series.patrick.ohly@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
Most of the patches looks good, i only have comments on:
- yocto-compat-layer.py: apply test_signatures to all layers
For the rest:
Acked-by: Aníbal Limón <anibal.limon@linux.intel.com>
Cheers,
Anibal
On 05/29/2017 10:32 AM, Patrick Ohly wrote:
> While enhancing the layer structure in intel-iot-refkit I ran into
> various cases where enhancements to the tool were
> necessary. intel-iot-refkit now has oe-selftests that check all layers
> using this tool. In addition, the signature checking utility code is
> imported into a custom test that also covers a refkit specific case
> (including refkit-config.inc must not change signatures).
>
> Patrick Ohly (6):
> yocto-compat-layer.py: avoid adding layers more than once
> yocto-compat-layer.py: tolerate broken world builds during signature diff
> yocto-compat-layer.py: apply test_signatures to all layers
> yocto-compat-layer.py: add test_world
> yocto-compat-layer.py: allow README with suffix
> yocto-compat-layer.py: make signature check code reusable
>
> scripts/lib/compatlayer/__init__.py | 90 +++++++++++++++++++++++++-
> scripts/lib/compatlayer/cases/common.py | 91 ++++++--------------------
> 2 files changed, 111 insertions(+), 70 deletions(-)
>
> base-commit: 598e5da5a2af2bd93ad890687dd32009e348fc85
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2017-05-29 16:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 15:32 [PATCH 0/6] yocto-compat-layer.py: various enhancements Patrick Ohly
2017-05-29 15:32 ` [PATCH 1/6] yocto-compat-layer.py: avoid adding layers more than once Patrick Ohly
2017-05-29 15:32 ` [PATCH 2/6] yocto-compat-layer.py: tolerate broken world builds during signature diff Patrick Ohly
2017-05-29 15:32 ` [PATCH 3/6] yocto-compat-layer.py: apply test_signatures to all layers Patrick Ohly
2017-05-29 16:13 ` Aníbal Limón
2017-05-29 19:18 ` Patrick Ohly
2017-05-29 19:26 ` Aníbal Limón
2017-05-29 20:14 ` Christopher Larson
2017-05-30 6:51 ` Patrick Ohly
2017-05-29 15:32 ` [PATCH 4/6] yocto-compat-layer.py: add test_world Patrick Ohly
2017-05-29 15:32 ` [PATCH 5/6] yocto-compat-layer.py: allow README with suffix Patrick Ohly
2017-05-29 15:32 ` [PATCH 6/6] yocto-compat-layer.py: make signature check code reusable Patrick Ohly
2017-05-29 16:15 ` Aníbal Limón [this message]
2017-06-27 15:33 ` [PATCH v2 0/6] yocto-compat-layer.py: various enhancements Patrick Ohly
2017-06-27 15:33 ` [PATCH v2 1/6] yocto-compat-layer.py: avoid adding layers more than once Patrick Ohly
2017-06-27 22:46 ` Christopher Larson
2017-06-28 7:50 ` Patrick Ohly
2017-06-28 9:06 ` Mark Hatle
2017-06-27 15:33 ` [PATCH v2 2/6] yocto-compat-layer.py: tolerate broken world builds during signature diff Patrick Ohly
2017-06-27 15:33 ` [PATCH v2 3/6] yocto-compat-layer.py: apply test_signatures to all layers Patrick Ohly
2017-06-28 9:08 ` Mark Hatle
2017-06-28 9:33 ` Patrick Ohly
2017-06-30 9:17 ` Mark Hatle
2017-06-27 15:33 ` [PATCH v2 4/6] yocto-compat-layer.py: add test_world Patrick Ohly
2017-06-27 15:33 ` [PATCH v2 5/6] yocto-compat-layer.py: allow README with suffix Patrick Ohly
2017-06-27 15:33 ` [PATCH v2 6/6] yocto-compat-layer.py: make signature check code reusable Patrick Ohly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592C4930.3080600@linux.intel.com \
--to=anibal.limon@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=patrick.ohly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.