From: walter harms <wharms@bfs.de>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: QLogic-Storage-Upstream@cavium.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: qedi: Fix a return value in case of error in 'qedi_alloc_global_queues'
Date: Sun, 11 Jun 2017 08:34:47 +0000 [thread overview]
Message-ID: <593D00A7.1090507@bfs.de> (raw)
In-Reply-To: <aafc9e362592524150d11f61dc7ab0b49e75f698.1497162751.git.christophe.jaillet@wanadoo.fr>
Am 11.06.2017 08:40, schrieb Christophe JAILLET:
> We should return -ENOMEM in case of memory allocation error, as done
> elsewhere in this function.
>
> Fixes: ace7f46ba5fde ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/scsi/qedi/qedi_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
> index f46880315ba8..c81e494a9067 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -1319,6 +1319,7 @@ static int qedi_alloc_global_queues(struct qedi_ctx *qedi)
> if (!qedi->global_queues[i]) {
> QEDI_ERR(&qedi->dbg_ctx,
> "Unable to allocation global queue %d.\n", i);
> + status = -ENOMEM;
> goto mem_alloc_failure;
> }
>
copy of "[PATCH 1/3] scsi: qedf: Fix a return value in case ..." ?
same strange error message
re,
wh
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: QLogic-Storage-Upstream@cavium.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: qedi: Fix a return value in case of error in 'qedi_alloc_global_queues'
Date: Sun, 11 Jun 2017 10:34:47 +0200 [thread overview]
Message-ID: <593D00A7.1090507@bfs.de> (raw)
In-Reply-To: <aafc9e362592524150d11f61dc7ab0b49e75f698.1497162751.git.christophe.jaillet@wanadoo.fr>
Am 11.06.2017 08:40, schrieb Christophe JAILLET:
> We should return -ENOMEM in case of memory allocation error, as done
> elsewhere in this function.
>
> Fixes: ace7f46ba5fde ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/scsi/qedi/qedi_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
> index f46880315ba8..c81e494a9067 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -1319,6 +1319,7 @@ static int qedi_alloc_global_queues(struct qedi_ctx *qedi)
> if (!qedi->global_queues[i]) {
> QEDI_ERR(&qedi->dbg_ctx,
> "Unable to allocation global queue %d.\n", i);
> + status = -ENOMEM;
> goto mem_alloc_failure;
> }
>
copy of "[PATCH 1/3] scsi: qedf: Fix a return value in case ..." ?
same strange error message
re,
wh
next prev parent reply other threads:[~2017-06-11 8:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-11 6:40 [PATCH 0/2] Fix a return value + some cleanups Christophe JAILLET
2017-06-11 6:40 ` Christophe JAILLET
2017-06-11 6:40 ` [PATCH 1/2] scsi: qedi: Fix a return value in case of error in 'qedi_alloc_global_queues' Christophe JAILLET
2017-06-11 6:40 ` Christophe JAILLET
2017-06-11 8:34 ` walter harms [this message]
2017-06-11 8:34 ` walter harms
2017-06-11 6:40 ` [PATCH 2/2] scsi: qedi: Use 'dma_zalloc_coherent' to reduce code verbosity Christophe JAILLET
2017-06-11 6:40 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=593D00A7.1090507@bfs.de \
--to=wharms@bfs.de \
--cc=QLogic-Storage-Upstream@cavium.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.