From: tanxiaojun@huawei.com (Tan Xiaojun)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] arm64: fix crash when reading /proc/kcore
Date: Tue, 13 Jun 2017 10:00:01 +0800 [thread overview]
Message-ID: <593F4721.7000501@huawei.com> (raw)
In-Reply-To: <20170608194139.9250-1-ard.biesheuvel@linaro.org>
On 2017/6/9 3:41, Ard Biesheuvel wrote:
> This is a follow-up to patches from zhonjiang [0] and myself [1] that aim
> to solve a problem in the kcore code, which gets confused by the presence
> of block mappings in the vmalloc region.
>
> While fixing the crash is quite straight forward [2], we need to tweak
> the kcore code itself to ensure that it operates correctly on arm64.
> Fortunately, we can achieve this with two very simple changes:
>
> - replace a call to is_vmalloc_or_module_addr() in read_kcore() with a
> comparison of the kclist type field (#1)
> - enable CONFIG_ARCH_PROC_KCORE_TEXT for arm64 (#2)
>
> [0] http://marc.info/?l=linux-mm&m=149632393629295&w=2
> [1] http://marc.info/?l=linux-mm&m=149685966530180&w=2
> [2] http://marc.info/?l=linux-mm&m=149694975123959&w=2
>
> Ard Biesheuvel (2):
> fs/proc: kcore: use kcore_list type to check for vmalloc/module
> address
> arm64: mm: select CONFIG_ARCH_PROC_KCORE_TEXT
>
> arch/arm64/Kconfig | 3 +++
> fs/proc/kcore.c | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
Reported-by: Tan Xiaojun <tanxiaojun@huawei.com>
Tested-by: Tan Xiaojun <tanxiaojun@huawei.com>
Thank you for working on this problem which I reported two months ago.
https://patchwork.kernel.org/patch/9687319/
I tested, and it really solved the problem in Hisilicon D02/D03/D05.
Thanks.
Xiaojun.
WARNING: multiple messages have this Message-ID (diff)
From: Tan Xiaojun <tanxiaojun@huawei.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
<linux-kernel@vger.kernel.org>
Cc: <mark.rutland@arm.com>, <jolsa@kernel.org>,
<akpm@linux-foundation.org>, <zhongjiang@huawei.com>,
<mingo@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<labbott@fedoraproject.org>
Subject: Re: [PATCH 0/2] arm64: fix crash when reading /proc/kcore
Date: Tue, 13 Jun 2017 10:00:01 +0800 [thread overview]
Message-ID: <593F4721.7000501@huawei.com> (raw)
In-Reply-To: <20170608194139.9250-1-ard.biesheuvel@linaro.org>
On 2017/6/9 3:41, Ard Biesheuvel wrote:
> This is a follow-up to patches from zhonjiang [0] and myself [1] that aim
> to solve a problem in the kcore code, which gets confused by the presence
> of block mappings in the vmalloc region.
>
> While fixing the crash is quite straight forward [2], we need to tweak
> the kcore code itself to ensure that it operates correctly on arm64.
> Fortunately, we can achieve this with two very simple changes:
>
> - replace a call to is_vmalloc_or_module_addr() in read_kcore() with a
> comparison of the kclist type field (#1)
> - enable CONFIG_ARCH_PROC_KCORE_TEXT for arm64 (#2)
>
> [0] http://marc.info/?l=linux-mm&m=149632393629295&w=2
> [1] http://marc.info/?l=linux-mm&m=149685966530180&w=2
> [2] http://marc.info/?l=linux-mm&m=149694975123959&w=2
>
> Ard Biesheuvel (2):
> fs/proc: kcore: use kcore_list type to check for vmalloc/module
> address
> arm64: mm: select CONFIG_ARCH_PROC_KCORE_TEXT
>
> arch/arm64/Kconfig | 3 +++
> fs/proc/kcore.c | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
Reported-by: Tan Xiaojun <tanxiaojun@huawei.com>
Tested-by: Tan Xiaojun <tanxiaojun@huawei.com>
Thank you for working on this problem which I reported two months ago.
https://patchwork.kernel.org/patch/9687319/
I tested, and it really solved the problem in Hisilicon D02/D03/D05.
Thanks.
Xiaojun.
next prev parent reply other threads:[~2017-06-13 2:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 19:41 [PATCH 0/2] arm64: fix crash when reading /proc/kcore Ard Biesheuvel
2017-06-08 19:41 ` Ard Biesheuvel
2017-06-08 19:41 ` [PATCH 1/2] fs/proc: kcore: use kcore_list type to check for vmalloc/module address Ard Biesheuvel
2017-06-08 19:41 ` Ard Biesheuvel
2017-06-08 19:41 ` [PATCH 2/2] arm64: mm: select CONFIG_ARCH_PROC_KCORE_TEXT Ard Biesheuvel
2017-06-08 19:41 ` Ard Biesheuvel
2017-06-09 10:00 ` [PATCH 0/2] arm64: fix crash when reading /proc/kcore Mark Rutland
2017-06-09 10:00 ` Mark Rutland
2017-06-09 18:05 ` Laura Abbott
2017-06-09 18:05 ` Laura Abbott
2017-06-13 2:00 ` Tan Xiaojun [this message]
2017-06-13 2:00 ` Tan Xiaojun
2017-06-13 7:17 ` Ard Biesheuvel
2017-06-13 7:17 ` Ard Biesheuvel
2017-06-13 14:06 ` Jiri Olsa
2017-06-13 14:06 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=593F4721.7000501@huawei.com \
--to=tanxiaojun@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.