* [PATCH v2 0/2] LOBF enablement fix
@ 2024-12-04 10:03 Animesh Manna
2024-12-04 10:03 ` [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna
` (4 more replies)
0 siblings, 5 replies; 14+ messages in thread
From: Animesh Manna @ 2024-12-04 10:03 UTC (permalink / raw)
To: intel-gfx; +Cc: jouni.hogander, jani.nikula, jeevan.b, Animesh Manna
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Animesh Manna (2):
drm/i915/lobf: Add lobf enablement in post plane update
drm/i915/lobf: Add debug print for LOBF
drivers/gpu/drm/i915/display/intel_alpm.c | 29 +++++++++++++++++++-
drivers/gpu/drm/i915/display/intel_alpm.h | 4 +++
drivers/gpu/drm/i915/display/intel_display.c | 3 ++
3 files changed, 35 insertions(+), 1 deletion(-)
--
2.29.0
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update 2024-12-04 10:03 [PATCH v2 0/2] LOBF enablement fix Animesh Manna @ 2024-12-04 10:03 ` Animesh Manna 2024-12-09 8:35 ` Hogander, Jouni 2024-12-04 10:03 ` [PATCH v2 2/2] drm/i915/lobf: Add debug print for LOBF Animesh Manna ` (3 subsequent siblings) 4 siblings, 1 reply; 14+ messages in thread From: Animesh Manna @ 2024-12-04 10:03 UTC (permalink / raw) To: intel-gfx; +Cc: jouni.hogander, jani.nikula, jeevan.b, Animesh Manna Enablement of LOBF is added in post plane update whenever has_lobf flag is set. As LOBF can be enabled in non-psr case as well so adding in post plane update. There is no change of configuring alpm with psr path. v1: Initial version. v2: Use encoder-mask to find the associated encoder from crtc-state. [Jani] Signed-off-by: Animesh Manna <animesh.manna@intel.com> --- drivers/gpu/drm/i915/display/intel_alpm.c | 25 ++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_alpm.h | 4 ++++ drivers/gpu/drm/i915/display/intel_display.c | 3 +++ 3 files changed, 32 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c index 55f3ae1e68c9..75063342a100 100644 --- a/drivers/gpu/drm/i915/display/intel_alpm.c +++ b/drivers/gpu/drm/i915/display/intel_alpm.c @@ -367,6 +367,31 @@ void intel_alpm_configure(struct intel_dp *intel_dp, lnl_alpm_configure(intel_dp, crtc_state); } +void intel_alpm_post_plane_update(struct intel_atomic_state *state, + struct intel_crtc *crtc) +{ + struct intel_display *display = to_intel_display(state); + const struct intel_crtc_state *crtc_state = + intel_atomic_get_new_crtc_state(state, crtc); + struct intel_encoder *encoder; + + if (!crtc_state->has_lobf) + return; + + for_each_intel_encoder_mask(display->drm, encoder, + crtc_state->uapi.encoder_mask) { + struct intel_dp *intel_dp; + + if (!intel_encoder_is_dp(encoder)) + continue; + + intel_dp = enc_to_intel_dp(encoder); + + if (intel_dp_is_edp(intel_dp)) + intel_alpm_configure(intel_dp, crtc_state); + } +} + static int i915_edp_lobf_info_show(struct seq_file *m, void *data) { struct intel_connector *connector = m->private; diff --git a/drivers/gpu/drm/i915/display/intel_alpm.h b/drivers/gpu/drm/i915/display/intel_alpm.h index 8c409b10dce6..2f862b0476a8 100644 --- a/drivers/gpu/drm/i915/display/intel_alpm.h +++ b/drivers/gpu/drm/i915/display/intel_alpm.h @@ -12,6 +12,8 @@ struct intel_dp; struct intel_crtc_state; struct drm_connector_state; struct intel_connector; +struct intel_atomic_state; +struct intel_crtc; void intel_alpm_init_dpcd(struct intel_dp *intel_dp); bool intel_alpm_compute_params(struct intel_dp *intel_dp, @@ -21,6 +23,8 @@ void intel_alpm_lobf_compute_config(struct intel_dp *intel_dp, struct drm_connector_state *conn_state); void intel_alpm_configure(struct intel_dp *intel_dp, const struct intel_crtc_state *crtc_state); +void intel_alpm_post_plane_update(struct intel_atomic_state *state, + struct intel_crtc *crtc); void intel_alpm_lobf_debugfs_add(struct intel_connector *connector); bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp); bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp); diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 4805bf682d43..ffd96b187e5e 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -55,6 +55,7 @@ #include "i9xx_plane.h" #include "i9xx_plane_regs.h" #include "i9xx_wm.h" +#include "intel_alpm.h" #include "intel_atomic.h" #include "intel_atomic_plane.h" #include "intel_audio.h" @@ -1190,6 +1191,8 @@ static void intel_post_plane_update(struct intel_atomic_state *state, intel_psr_post_plane_update(state, crtc); + intel_alpm_post_plane_update(state, crtc); + intel_frontbuffer_flip(dev_priv, new_crtc_state->fb_bits); if (new_crtc_state->update_wm_post && new_crtc_state->hw.active) -- 2.29.0 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update 2024-12-04 10:03 ` [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna @ 2024-12-09 8:35 ` Hogander, Jouni 2024-12-09 11:19 ` Manna, Animesh 0 siblings, 1 reply; 14+ messages in thread From: Hogander, Jouni @ 2024-12-09 8:35 UTC (permalink / raw) To: Manna, Animesh, intel-gfx@lists.freedesktop.org; +Cc: Nikula, Jani, B, Jeevan On Wed, 2024-12-04 at 15:33 +0530, Animesh Manna wrote: > Enablement of LOBF is added in post plane update whenever > has_lobf flag is set. As LOBF can be enabled in non-psr > case as well so adding in post plane update. There is no > change of configuring alpm with psr path. > > v1: Initial version. > v2: Use encoder-mask to find the associated encoder from > crtc-state. [Jani] > > Signed-off-by: Animesh Manna <animesh.manna@intel.com> > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 25 > ++++++++++++++++++++ > drivers/gpu/drm/i915/display/intel_alpm.h | 4 ++++ > drivers/gpu/drm/i915/display/intel_display.c | 3 +++ > 3 files changed, 32 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c > b/drivers/gpu/drm/i915/display/intel_alpm.c > index 55f3ae1e68c9..75063342a100 100644 > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > @@ -367,6 +367,31 @@ void intel_alpm_configure(struct intel_dp > *intel_dp, > lnl_alpm_configure(intel_dp, crtc_state); > } > > +void intel_alpm_post_plane_update(struct intel_atomic_state *state, > + struct intel_crtc *crtc) > +{ > + struct intel_display *display = to_intel_display(state); > + const struct intel_crtc_state *crtc_state = > + intel_atomic_get_new_crtc_state(state, crtc); > + struct intel_encoder *encoder; > + > + if (!crtc_state->has_lobf) > + return; > + > + for_each_intel_encoder_mask(display->drm, encoder, > + crtc_state->uapi.encoder_mask) { > + struct intel_dp *intel_dp; > + > + if (!intel_encoder_is_dp(encoder)) > + continue; > + > + intel_dp = enc_to_intel_dp(encoder); > + > + if (intel_dp_is_edp(intel_dp)) > + intel_alpm_configure(intel_dp, crtc_state); This is reconfiguring lobf even if it's already configured? Is that wanted? BR, Jouni Högander > + } > +} > + > static int i915_edp_lobf_info_show(struct seq_file *m, void *data) > { > struct intel_connector *connector = m->private; > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.h > b/drivers/gpu/drm/i915/display/intel_alpm.h > index 8c409b10dce6..2f862b0476a8 100644 > --- a/drivers/gpu/drm/i915/display/intel_alpm.h > +++ b/drivers/gpu/drm/i915/display/intel_alpm.h > @@ -12,6 +12,8 @@ struct intel_dp; > struct intel_crtc_state; > struct drm_connector_state; > struct intel_connector; > +struct intel_atomic_state; > +struct intel_crtc; > > void intel_alpm_init_dpcd(struct intel_dp *intel_dp); > bool intel_alpm_compute_params(struct intel_dp *intel_dp, > @@ -21,6 +23,8 @@ void intel_alpm_lobf_compute_config(struct intel_dp > *intel_dp, > struct drm_connector_state > *conn_state); > void intel_alpm_configure(struct intel_dp *intel_dp, > const struct intel_crtc_state *crtc_state); > +void intel_alpm_post_plane_update(struct intel_atomic_state *state, > + struct intel_crtc *crtc); > void intel_alpm_lobf_debugfs_add(struct intel_connector *connector); > bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp); > bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp); > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > b/drivers/gpu/drm/i915/display/intel_display.c > index 4805bf682d43..ffd96b187e5e 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -55,6 +55,7 @@ > #include "i9xx_plane.h" > #include "i9xx_plane_regs.h" > #include "i9xx_wm.h" > +#include "intel_alpm.h" > #include "intel_atomic.h" > #include "intel_atomic_plane.h" > #include "intel_audio.h" > @@ -1190,6 +1191,8 @@ static void intel_post_plane_update(struct > intel_atomic_state *state, > > intel_psr_post_plane_update(state, crtc); > > + intel_alpm_post_plane_update(state, crtc); > + > intel_frontbuffer_flip(dev_priv, new_crtc_state->fb_bits); > > if (new_crtc_state->update_wm_post && new_crtc_state- > >hw.active) ^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update 2024-12-09 8:35 ` Hogander, Jouni @ 2024-12-09 11:19 ` Manna, Animesh 2024-12-09 11:34 ` Hogander, Jouni 0 siblings, 1 reply; 14+ messages in thread From: Manna, Animesh @ 2024-12-09 11:19 UTC (permalink / raw) To: Hogander, Jouni, intel-gfx@lists.freedesktop.org; +Cc: Nikula, Jani, B, Jeevan > -----Original Message----- > From: Hogander, Jouni <jouni.hogander@intel.com> > Sent: Monday, December 9, 2024 2:06 PM > To: Manna, Animesh <animesh.manna@intel.com>; intel- > gfx@lists.freedesktop.org > Cc: Nikula, Jani <jani.nikula@intel.com>; B, Jeevan <jeevan.b@intel.com> > Subject: Re: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post > plane update > > On Wed, 2024-12-04 at 15:33 +0530, Animesh Manna wrote: > > Enablement of LOBF is added in post plane update whenever has_lobf > > flag is set. As LOBF can be enabled in non-psr case as well so adding > > in post plane update. There is no change of configuring alpm with psr > > path. > > > > v1: Initial version. > > v2: Use encoder-mask to find the associated encoder from crtc-state. > > [Jani] > > > > Signed-off-by: Animesh Manna <animesh.manna@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_alpm.c | 25 > > ++++++++++++++++++++ > > drivers/gpu/drm/i915/display/intel_alpm.h | 4 ++++ > > drivers/gpu/drm/i915/display/intel_display.c | 3 +++ > > 3 files changed, 32 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c > > b/drivers/gpu/drm/i915/display/intel_alpm.c > > index 55f3ae1e68c9..75063342a100 100644 > > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > > @@ -367,6 +367,31 @@ void intel_alpm_configure(struct intel_dp > > *intel_dp, > > lnl_alpm_configure(intel_dp, crtc_state); > > } > > > > +void intel_alpm_post_plane_update(struct intel_atomic_state *state, > > + struct intel_crtc *crtc) { > > + struct intel_display *display = to_intel_display(state); > > + const struct intel_crtc_state *crtc_state = > > + intel_atomic_get_new_crtc_state(state, crtc); > > + struct intel_encoder *encoder; > > + > > + if (!crtc_state->has_lobf) > > + return; > > + > > + for_each_intel_encoder_mask(display->drm, encoder, > > + crtc_state->uapi.encoder_mask) { > > + struct intel_dp *intel_dp; > > + > > + if (!intel_encoder_is_dp(encoder)) > > + continue; > > + > > + intel_dp = enc_to_intel_dp(encoder); > > + > > + if (intel_dp_is_edp(intel_dp)) > > + intel_alpm_configure(intel_dp, crtc_state); > > This is reconfiguring lobf even if it's already configured? Is that wanted? has_psr and has_lobf are mutually exclusive, so alpm_configure() will be called once. Regards, Animesh > > BR, > > Jouni Högander > > + } > > +} > > + > > static int i915_edp_lobf_info_show(struct seq_file *m, void *data) > > { > > struct intel_connector *connector = m->private; diff --git > > a/drivers/gpu/drm/i915/display/intel_alpm.h > > b/drivers/gpu/drm/i915/display/intel_alpm.h > > index 8c409b10dce6..2f862b0476a8 100644 > > --- a/drivers/gpu/drm/i915/display/intel_alpm.h > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.h > > @@ -12,6 +12,8 @@ struct intel_dp; > > struct intel_crtc_state; > > struct drm_connector_state; > > struct intel_connector; > > +struct intel_atomic_state; > > +struct intel_crtc; > > > > void intel_alpm_init_dpcd(struct intel_dp *intel_dp); > > bool intel_alpm_compute_params(struct intel_dp *intel_dp, @@ -21,6 > > +23,8 @@ void intel_alpm_lobf_compute_config(struct intel_dp > > *intel_dp, > > struct drm_connector_state > > *conn_state); > > void intel_alpm_configure(struct intel_dp *intel_dp, > > const struct intel_crtc_state *crtc_state); > > +void intel_alpm_post_plane_update(struct intel_atomic_state *state, > > + struct intel_crtc *crtc); > > void intel_alpm_lobf_debugfs_add(struct intel_connector *connector); > > bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp); > > bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp); > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > > b/drivers/gpu/drm/i915/display/intel_display.c > > index 4805bf682d43..ffd96b187e5e 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -55,6 +55,7 @@ > > #include "i9xx_plane.h" > > #include "i9xx_plane_regs.h" > > #include "i9xx_wm.h" > > +#include "intel_alpm.h" > > #include "intel_atomic.h" > > #include "intel_atomic_plane.h" > > #include "intel_audio.h" > > @@ -1190,6 +1191,8 @@ static void intel_post_plane_update(struct > > intel_atomic_state *state, > > > > intel_psr_post_plane_update(state, crtc); > > > > + intel_alpm_post_plane_update(state, crtc); > > + > > intel_frontbuffer_flip(dev_priv, new_crtc_state->fb_bits); > > > > if (new_crtc_state->update_wm_post && new_crtc_state- > > >hw.active) ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update 2024-12-09 11:19 ` Manna, Animesh @ 2024-12-09 11:34 ` Hogander, Jouni 2024-12-09 11:54 ` Manna, Animesh 0 siblings, 1 reply; 14+ messages in thread From: Hogander, Jouni @ 2024-12-09 11:34 UTC (permalink / raw) To: Manna, Animesh, intel-gfx@lists.freedesktop.org; +Cc: Nikula, Jani, B, Jeevan On Mon, 2024-12-09 at 11:19 +0000, Manna, Animesh wrote: > > > > -----Original Message----- > > From: Hogander, Jouni <jouni.hogander@intel.com> > > Sent: Monday, December 9, 2024 2:06 PM > > To: Manna, Animesh <animesh.manna@intel.com>; intel- > > gfx@lists.freedesktop.org > > Cc: Nikula, Jani <jani.nikula@intel.com>; B, Jeevan > > <jeevan.b@intel.com> > > Subject: Re: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in > > post > > plane update > > > > On Wed, 2024-12-04 at 15:33 +0530, Animesh Manna wrote: > > > Enablement of LOBF is added in post plane update whenever > > > has_lobf > > > flag is set. As LOBF can be enabled in non-psr case as well so > > > adding > > > in post plane update. There is no change of configuring alpm with > > > psr > > > path. > > > > > > v1: Initial version. > > > v2: Use encoder-mask to find the associated encoder from crtc- > > > state. > > > [Jani] > > > > > > Signed-off-by: Animesh Manna <animesh.manna@intel.com> > > > --- > > > drivers/gpu/drm/i915/display/intel_alpm.c | 25 > > > ++++++++++++++++++++ > > > drivers/gpu/drm/i915/display/intel_alpm.h | 4 ++++ > > > drivers/gpu/drm/i915/display/intel_display.c | 3 +++ > > > 3 files changed, 32 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c > > > b/drivers/gpu/drm/i915/display/intel_alpm.c > > > index 55f3ae1e68c9..75063342a100 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > > > @@ -367,6 +367,31 @@ void intel_alpm_configure(struct intel_dp > > > *intel_dp, > > > lnl_alpm_configure(intel_dp, crtc_state); > > > } > > > > > > +void intel_alpm_post_plane_update(struct intel_atomic_state > > > *state, > > > + struct intel_crtc *crtc) { > > > + struct intel_display *display = to_intel_display(state); > > > + const struct intel_crtc_state *crtc_state = > > > + intel_atomic_get_new_crtc_state(state, crtc); > > > + struct intel_encoder *encoder; > > > + > > > + if (!crtc_state->has_lobf) > > > + return; > > > + > > > + for_each_intel_encoder_mask(display->drm, encoder, > > > + crtc_state- > > > >uapi.encoder_mask) { > > > + struct intel_dp *intel_dp; > > > + > > > + if (!intel_encoder_is_dp(encoder)) > > > + continue; > > > + > > > + intel_dp = enc_to_intel_dp(encoder); > > > + > > > + if (intel_dp_is_edp(intel_dp)) > > > + intel_alpm_configure(intel_dp, > > > crtc_state); > > > > This is reconfiguring lobf even if it's already configured? Is that > > wanted? > > has_psr and has_lobf are mutually exclusive, so alpm_configure() will > be called once. has_psr is unrelated. Consider e.g. case where xe.enable_psr=0 is in bootcmd. has_psr is always false. ALPM_CTL is written with lobf enabled on every commit if has_lobf is true. Another thing here is that lobf is never disabled after it gets enabled? Please also review cases where lobf needs to be disabled. E.g. refresh rate change. See bspec 71041. BR, Jouni Högander > > Regards, > Animesh > > > > > BR, > > > > Jouni Högander > > > + } > > > +} > > > + > > > static int i915_edp_lobf_info_show(struct seq_file *m, void > > > *data) > > > { > > > struct intel_connector *connector = m->private; diff -- > > > git > > > a/drivers/gpu/drm/i915/display/intel_alpm.h > > > b/drivers/gpu/drm/i915/display/intel_alpm.h > > > index 8c409b10dce6..2f862b0476a8 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_alpm.h > > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.h > > > @@ -12,6 +12,8 @@ struct intel_dp; > > > struct intel_crtc_state; > > > struct drm_connector_state; > > > struct intel_connector; > > > +struct intel_atomic_state; > > > +struct intel_crtc; > > > > > > void intel_alpm_init_dpcd(struct intel_dp *intel_dp); > > > bool intel_alpm_compute_params(struct intel_dp *intel_dp, @@ - > > > 21,6 > > > +23,8 @@ void intel_alpm_lobf_compute_config(struct intel_dp > > > *intel_dp, > > > struct drm_connector_state > > > *conn_state); > > > void intel_alpm_configure(struct intel_dp *intel_dp, > > > const struct intel_crtc_state > > > *crtc_state); > > > +void intel_alpm_post_plane_update(struct intel_atomic_state > > > *state, > > > + struct intel_crtc *crtc); > > > void intel_alpm_lobf_debugfs_add(struct intel_connector > > > *connector); > > > bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp); > > > bool intel_alpm_aux_less_wake_supported(struct intel_dp > > > *intel_dp); > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > > > b/drivers/gpu/drm/i915/display/intel_display.c > > > index 4805bf682d43..ffd96b187e5e 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > > @@ -55,6 +55,7 @@ > > > #include "i9xx_plane.h" > > > #include "i9xx_plane_regs.h" > > > #include "i9xx_wm.h" > > > +#include "intel_alpm.h" > > > #include "intel_atomic.h" > > > #include "intel_atomic_plane.h" > > > #include "intel_audio.h" > > > @@ -1190,6 +1191,8 @@ static void intel_post_plane_update(struct > > > intel_atomic_state *state, > > > > > > intel_psr_post_plane_update(state, crtc); > > > > > > + intel_alpm_post_plane_update(state, crtc); > > > + > > > intel_frontbuffer_flip(dev_priv, new_crtc_state- > > > >fb_bits); > > > > > > if (new_crtc_state->update_wm_post && new_crtc_state- > > > > hw.active) > ^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update 2024-12-09 11:34 ` Hogander, Jouni @ 2024-12-09 11:54 ` Manna, Animesh 2024-12-09 11:59 ` Hogander, Jouni 0 siblings, 1 reply; 14+ messages in thread From: Manna, Animesh @ 2024-12-09 11:54 UTC (permalink / raw) To: Hogander, Jouni, intel-gfx@lists.freedesktop.org; +Cc: Nikula, Jani, B, Jeevan > -----Original Message----- > From: Hogander, Jouni <jouni.hogander@intel.com> > Sent: Monday, December 9, 2024 5:04 PM > To: Manna, Animesh <animesh.manna@intel.com>; intel- > gfx@lists.freedesktop.org > Cc: Nikula, Jani <jani.nikula@intel.com>; B, Jeevan <jeevan.b@intel.com> > Subject: Re: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post > plane update > > On Mon, 2024-12-09 at 11:19 +0000, Manna, Animesh wrote: > > > > > > > -----Original Message----- > > > From: Hogander, Jouni <jouni.hogander@intel.com> > > > Sent: Monday, December 9, 2024 2:06 PM > > > To: Manna, Animesh <animesh.manna@intel.com>; intel- > > > gfx@lists.freedesktop.org > > > Cc: Nikula, Jani <jani.nikula@intel.com>; B, Jeevan > > > <jeevan.b@intel.com> > > > Subject: Re: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in > > > post plane update > > > > > > On Wed, 2024-12-04 at 15:33 +0530, Animesh Manna wrote: > > > > Enablement of LOBF is added in post plane update whenever has_lobf > > > > flag is set. As LOBF can be enabled in non-psr case as well so > > > > adding in post plane update. There is no change of configuring > > > > alpm with psr path. > > > > > > > > v1: Initial version. > > > > v2: Use encoder-mask to find the associated encoder from crtc- > > > > state. > > > > [Jani] > > > > > > > > Signed-off-by: Animesh Manna <animesh.manna@intel.com> > > > > --- > > > > drivers/gpu/drm/i915/display/intel_alpm.c | 25 > > > > ++++++++++++++++++++ > > > > drivers/gpu/drm/i915/display/intel_alpm.h | 4 ++++ > > > > drivers/gpu/drm/i915/display/intel_display.c | 3 +++ > > > > 3 files changed, 32 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c > > > > b/drivers/gpu/drm/i915/display/intel_alpm.c > > > > index 55f3ae1e68c9..75063342a100 100644 > > > > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > > > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > > > > @@ -367,6 +367,31 @@ void intel_alpm_configure(struct intel_dp > > > > *intel_dp, > > > > lnl_alpm_configure(intel_dp, crtc_state); > > > > } > > > > > > > > +void intel_alpm_post_plane_update(struct intel_atomic_state > > > > *state, > > > > + struct intel_crtc *crtc) { > > > > + struct intel_display *display = to_intel_display(state); > > > > + const struct intel_crtc_state *crtc_state = > > > > + intel_atomic_get_new_crtc_state(state, crtc); > > > > + struct intel_encoder *encoder; > > > > + > > > > + if (!crtc_state->has_lobf) > > > > + return; > > > > + > > > > + for_each_intel_encoder_mask(display->drm, encoder, > > > > + crtc_state- > > > > >uapi.encoder_mask) { > > > > + struct intel_dp *intel_dp; > > > > + > > > > + if (!intel_encoder_is_dp(encoder)) > > > > + continue; > > > > + > > > > + intel_dp = enc_to_intel_dp(encoder); > > > > + > > > > + if (intel_dp_is_edp(intel_dp)) > > > > + intel_alpm_configure(intel_dp, > > > > crtc_state); > > > > > > This is reconfiguring lobf even if it's already configured? Is that > > > wanted? > > > > has_psr and has_lobf are mutually exclusive, so alpm_configure() will > > be called once. > > has_psr is unrelated. Consider e.g. case where xe.enable_psr=0 is in > bootcmd. has_psr is always false. ALPM_CTL is written with lobf enabled on > every commit if has_lobf is true. Currently VRR fixed refresh mode check is not added in this patch series which can take care of resetting the has_lobf flag as well, thanks for catching, will add in next version. Hope with the above change the below comments will be addressed. Regards, Animesh > > Another thing here is that lobf is never disabled after it gets enabled? > > Please also review cases where lobf needs to be disabled. E.g. refresh rate > change. See bspec 71041. > > BR, > > Jouni Högander > > > > Regards, > > Animesh > > > > > > > > BR, > > > > > > Jouni Högander > > > > + } > > > > +} > > > > + > > > > static int i915_edp_lobf_info_show(struct seq_file *m, void > > > > *data) > > > > { > > > > struct intel_connector *connector = m->private; diff -- > > > > git a/drivers/gpu/drm/i915/display/intel_alpm.h > > > > b/drivers/gpu/drm/i915/display/intel_alpm.h > > > > index 8c409b10dce6..2f862b0476a8 100644 > > > > --- a/drivers/gpu/drm/i915/display/intel_alpm.h > > > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.h > > > > @@ -12,6 +12,8 @@ struct intel_dp; > > > > struct intel_crtc_state; > > > > struct drm_connector_state; > > > > struct intel_connector; > > > > +struct intel_atomic_state; > > > > +struct intel_crtc; > > > > > > > > void intel_alpm_init_dpcd(struct intel_dp *intel_dp); > > > > bool intel_alpm_compute_params(struct intel_dp *intel_dp, @@ - > > > > 21,6 > > > > +23,8 @@ void intel_alpm_lobf_compute_config(struct intel_dp > > > > *intel_dp, > > > > struct drm_connector_state > > > > *conn_state); > > > > void intel_alpm_configure(struct intel_dp *intel_dp, > > > > const struct intel_crtc_state > > > > *crtc_state); > > > > +void intel_alpm_post_plane_update(struct intel_atomic_state > > > > *state, > > > > + struct intel_crtc *crtc); > > > > void intel_alpm_lobf_debugfs_add(struct intel_connector > > > > *connector); > > > > bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp); > > > > bool intel_alpm_aux_less_wake_supported(struct intel_dp > > > > *intel_dp); diff --git > > > > a/drivers/gpu/drm/i915/display/intel_display.c > > > > b/drivers/gpu/drm/i915/display/intel_display.c > > > > index 4805bf682d43..ffd96b187e5e 100644 > > > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > > > @@ -55,6 +55,7 @@ > > > > #include "i9xx_plane.h" > > > > #include "i9xx_plane_regs.h" > > > > #include "i9xx_wm.h" > > > > +#include "intel_alpm.h" > > > > #include "intel_atomic.h" > > > > #include "intel_atomic_plane.h" > > > > #include "intel_audio.h" > > > > @@ -1190,6 +1191,8 @@ static void intel_post_plane_update(struct > > > > intel_atomic_state *state, > > > > > > > > intel_psr_post_plane_update(state, crtc); > > > > > > > > + intel_alpm_post_plane_update(state, crtc); > > > > + > > > > intel_frontbuffer_flip(dev_priv, new_crtc_state- > > > > >fb_bits); > > > > > > > > if (new_crtc_state->update_wm_post && new_crtc_state- > > > > > hw.active) > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update 2024-12-09 11:54 ` Manna, Animesh @ 2024-12-09 11:59 ` Hogander, Jouni 2024-12-09 12:29 ` Manna, Animesh 0 siblings, 1 reply; 14+ messages in thread From: Hogander, Jouni @ 2024-12-09 11:59 UTC (permalink / raw) To: Manna, Animesh, intel-gfx@lists.freedesktop.org; +Cc: Nikula, Jani, B, Jeevan On Mon, 2024-12-09 at 11:54 +0000, Manna, Animesh wrote: > > > > -----Original Message----- > > From: Hogander, Jouni <jouni.hogander@intel.com> > > Sent: Monday, December 9, 2024 5:04 PM > > To: Manna, Animesh <animesh.manna@intel.com>; intel- > > gfx@lists.freedesktop.org > > Cc: Nikula, Jani <jani.nikula@intel.com>; B, Jeevan > > <jeevan.b@intel.com> > > Subject: Re: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in > > post > > plane update > > > > On Mon, 2024-12-09 at 11:19 +0000, Manna, Animesh wrote: > > > > > > > > > > -----Original Message----- > > > > From: Hogander, Jouni <jouni.hogander@intel.com> > > > > Sent: Monday, December 9, 2024 2:06 PM > > > > To: Manna, Animesh <animesh.manna@intel.com>; intel- > > > > gfx@lists.freedesktop.org > > > > Cc: Nikula, Jani <jani.nikula@intel.com>; B, Jeevan > > > > <jeevan.b@intel.com> > > > > Subject: Re: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement > > > > in > > > > post plane update > > > > > > > > On Wed, 2024-12-04 at 15:33 +0530, Animesh Manna wrote: > > > > > Enablement of LOBF is added in post plane update whenever > > > > > has_lobf > > > > > flag is set. As LOBF can be enabled in non-psr case as well > > > > > so > > > > > adding in post plane update. There is no change of > > > > > configuring > > > > > alpm with psr path. > > > > > > > > > > v1: Initial version. > > > > > v2: Use encoder-mask to find the associated encoder from > > > > > crtc- > > > > > state. > > > > > [Jani] > > > > > > > > > > Signed-off-by: Animesh Manna <animesh.manna@intel.com> > > > > > --- > > > > > drivers/gpu/drm/i915/display/intel_alpm.c | 25 > > > > > ++++++++++++++++++++ > > > > > drivers/gpu/drm/i915/display/intel_alpm.h | 4 ++++ > > > > > drivers/gpu/drm/i915/display/intel_display.c | 3 +++ > > > > > 3 files changed, 32 insertions(+) > > > > > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c > > > > > b/drivers/gpu/drm/i915/display/intel_alpm.c > > > > > index 55f3ae1e68c9..75063342a100 100644 > > > > > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > > > > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > > > > > @@ -367,6 +367,31 @@ void intel_alpm_configure(struct > > > > > intel_dp > > > > > *intel_dp, > > > > > lnl_alpm_configure(intel_dp, crtc_state); > > > > > } > > > > > > > > > > +void intel_alpm_post_plane_update(struct intel_atomic_state > > > > > *state, > > > > > + struct intel_crtc *crtc) { > > > > > + struct intel_display *display = > > > > > to_intel_display(state); > > > > > + const struct intel_crtc_state *crtc_state = > > > > > + intel_atomic_get_new_crtc_state(state, crtc); > > > > > + struct intel_encoder *encoder; > > > > > + > > > > > + if (!crtc_state->has_lobf) > > > > > + return; > > > > > + > > > > > + for_each_intel_encoder_mask(display->drm, encoder, > > > > > + crtc_state- > > > > > > uapi.encoder_mask) { > > > > > + struct intel_dp *intel_dp; > > > > > + > > > > > + if (!intel_encoder_is_dp(encoder)) > > > > > + continue; > > > > > + > > > > > + intel_dp = enc_to_intel_dp(encoder); > > > > > + > > > > > + if (intel_dp_is_edp(intel_dp)) > > > > > + intel_alpm_configure(intel_dp, > > > > > crtc_state); > > > > > > > > This is reconfiguring lobf even if it's already configured? Is > > > > that > > > > wanted? > > > > > > has_psr and has_lobf are mutually exclusive, so alpm_configure() > > > will > > > be called once. > > > > has_psr is unrelated. Consider e.g. case where xe.enable_psr=0 is > > in > > bootcmd. has_psr is always false. ALPM_CTL is written with lobf > > enabled on > > every commit if has_lobf is true. > > Currently VRR fixed refresh mode check is not added in this patch > series which can take care of resetting the has_lobf flag as well, > thanks for catching, will add in next version. > Hope with the above change the below comments will be addressed. Please note that it is not about just resetting the flag. Someone has to reset lobf enable bit in ALPM_CTL as well. BR, Jouni Högander > > Regards, > Animesh > > > > > Another thing here is that lobf is never disabled after it gets > > enabled? > > > > Please also review cases where lobf needs to be disabled. E.g. > > refresh rate > > change. See bspec 71041. > > > > BR, > > > > Jouni Högander > > > > > > Regards, > > > Animesh > > > > > > > > > > > BR, > > > > > > > > Jouni Högander > > > > > + } > > > > > +} > > > > > + > > > > > static int i915_edp_lobf_info_show(struct seq_file *m, void > > > > > *data) > > > > > { > > > > > struct intel_connector *connector = m->private; diff > > > > > -- > > > > > git a/drivers/gpu/drm/i915/display/intel_alpm.h > > > > > b/drivers/gpu/drm/i915/display/intel_alpm.h > > > > > index 8c409b10dce6..2f862b0476a8 100644 > > > > > --- a/drivers/gpu/drm/i915/display/intel_alpm.h > > > > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.h > > > > > @@ -12,6 +12,8 @@ struct intel_dp; > > > > > struct intel_crtc_state; > > > > > struct drm_connector_state; > > > > > struct intel_connector; > > > > > +struct intel_atomic_state; > > > > > +struct intel_crtc; > > > > > > > > > > void intel_alpm_init_dpcd(struct intel_dp *intel_dp); > > > > > bool intel_alpm_compute_params(struct intel_dp *intel_dp, @@ > > > > > - > > > > > 21,6 > > > > > +23,8 @@ void intel_alpm_lobf_compute_config(struct intel_dp > > > > > *intel_dp, > > > > > struct > > > > > drm_connector_state > > > > > *conn_state); > > > > > void intel_alpm_configure(struct intel_dp *intel_dp, > > > > > const struct intel_crtc_state > > > > > *crtc_state); > > > > > +void intel_alpm_post_plane_update(struct intel_atomic_state > > > > > *state, > > > > > + struct intel_crtc *crtc); > > > > > void intel_alpm_lobf_debugfs_add(struct intel_connector > > > > > *connector); > > > > > bool intel_alpm_aux_wake_supported(struct intel_dp > > > > > *intel_dp); > > > > > bool intel_alpm_aux_less_wake_supported(struct intel_dp > > > > > *intel_dp); diff --git > > > > > a/drivers/gpu/drm/i915/display/intel_display.c > > > > > b/drivers/gpu/drm/i915/display/intel_display.c > > > > > index 4805bf682d43..ffd96b187e5e 100644 > > > > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > > > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > > > > @@ -55,6 +55,7 @@ > > > > > #include "i9xx_plane.h" > > > > > #include "i9xx_plane_regs.h" > > > > > #include "i9xx_wm.h" > > > > > +#include "intel_alpm.h" > > > > > #include "intel_atomic.h" > > > > > #include "intel_atomic_plane.h" > > > > > #include "intel_audio.h" > > > > > @@ -1190,6 +1191,8 @@ static void > > > > > intel_post_plane_update(struct > > > > > intel_atomic_state *state, > > > > > > > > > > intel_psr_post_plane_update(state, crtc); > > > > > > > > > > + intel_alpm_post_plane_update(state, crtc); > > > > > + > > > > > intel_frontbuffer_flip(dev_priv, new_crtc_state- > > > > > > fb_bits); > > > > > > > > > > if (new_crtc_state->update_wm_post && new_crtc_state- > > > > > > hw.active) > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update 2024-12-09 11:59 ` Hogander, Jouni @ 2024-12-09 12:29 ` Manna, Animesh 0 siblings, 0 replies; 14+ messages in thread From: Manna, Animesh @ 2024-12-09 12:29 UTC (permalink / raw) To: Hogander, Jouni, intel-gfx@lists.freedesktop.org; +Cc: Nikula, Jani, B, Jeevan > -----Original Message----- > From: Hogander, Jouni <jouni.hogander@intel.com> > Sent: Monday, December 9, 2024 5:29 PM > To: Manna, Animesh <animesh.manna@intel.com>; intel- > gfx@lists.freedesktop.org > Cc: Nikula, Jani <jani.nikula@intel.com>; B, Jeevan <jeevan.b@intel.com> > Subject: Re: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post > plane update > > On Mon, 2024-12-09 at 11:54 +0000, Manna, Animesh wrote: > > > > > > > -----Original Message----- > > > From: Hogander, Jouni <jouni.hogander@intel.com> > > > Sent: Monday, December 9, 2024 5:04 PM > > > To: Manna, Animesh <animesh.manna@intel.com>; intel- > > > gfx@lists.freedesktop.org > > > Cc: Nikula, Jani <jani.nikula@intel.com>; B, Jeevan > > > <jeevan.b@intel.com> > > > Subject: Re: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in > > > post plane update > > > > > > On Mon, 2024-12-09 at 11:19 +0000, Manna, Animesh wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: Hogander, Jouni <jouni.hogander@intel.com> > > > > > Sent: Monday, December 9, 2024 2:06 PM > > > > > To: Manna, Animesh <animesh.manna@intel.com>; intel- > > > > > gfx@lists.freedesktop.org > > > > > Cc: Nikula, Jani <jani.nikula@intel.com>; B, Jeevan > > > > > <jeevan.b@intel.com> > > > > > Subject: Re: [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement > > > > > in post plane update > > > > > > > > > > On Wed, 2024-12-04 at 15:33 +0530, Animesh Manna wrote: > > > > > > Enablement of LOBF is added in post plane update whenever > > > > > > has_lobf flag is set. As LOBF can be enabled in non-psr case > > > > > > as well so adding in post plane update. There is no change of > > > > > > configuring alpm with psr path. > > > > > > > > > > > > v1: Initial version. > > > > > > v2: Use encoder-mask to find the associated encoder from > > > > > > crtc- > > > > > > state. > > > > > > [Jani] > > > > > > > > > > > > Signed-off-by: Animesh Manna <animesh.manna@intel.com> > > > > > > --- > > > > > > drivers/gpu/drm/i915/display/intel_alpm.c | 25 > > > > > > ++++++++++++++++++++ > > > > > > drivers/gpu/drm/i915/display/intel_alpm.h | 4 ++++ > > > > > > drivers/gpu/drm/i915/display/intel_display.c | 3 +++ > > > > > > 3 files changed, 32 insertions(+) > > > > > > > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c > > > > > > b/drivers/gpu/drm/i915/display/intel_alpm.c > > > > > > index 55f3ae1e68c9..75063342a100 100644 > > > > > > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > > > > > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > > > > > > @@ -367,6 +367,31 @@ void intel_alpm_configure(struct intel_dp > > > > > > *intel_dp, > > > > > > lnl_alpm_configure(intel_dp, crtc_state); > > > > > > } > > > > > > > > > > > > +void intel_alpm_post_plane_update(struct intel_atomic_state > > > > > > *state, > > > > > > + struct intel_crtc *crtc) { > > > > > > + struct intel_display *display = > > > > > > to_intel_display(state); > > > > > > + const struct intel_crtc_state *crtc_state = > > > > > > + intel_atomic_get_new_crtc_state(state, crtc); > > > > > > + struct intel_encoder *encoder; > > > > > > + > > > > > > + if (!crtc_state->has_lobf) > > > > > > + return; > > > > > > + > > > > > > + for_each_intel_encoder_mask(display->drm, encoder, > > > > > > + crtc_state- > > > > > > > uapi.encoder_mask) { > > > > > > + struct intel_dp *intel_dp; > > > > > > + > > > > > > + if (!intel_encoder_is_dp(encoder)) > > > > > > + continue; > > > > > > + > > > > > > + intel_dp = enc_to_intel_dp(encoder); > > > > > > + > > > > > > + if (intel_dp_is_edp(intel_dp)) > > > > > > + intel_alpm_configure(intel_dp, > > > > > > crtc_state); > > > > > > > > > > This is reconfiguring lobf even if it's already configured? Is > > > > > that wanted? > > > > > > > > has_psr and has_lobf are mutually exclusive, so alpm_configure() > > > > will be called once. > > > > > > has_psr is unrelated. Consider e.g. case where xe.enable_psr=0 is in > > > bootcmd. has_psr is always false. ALPM_CTL is written with lobf > > > enabled on every commit if has_lobf is true. > > > > Currently VRR fixed refresh mode check is not added in this patch > > series which can take care of resetting the has_lobf flag as well, > > thanks for catching, will add in next version. > > Hope with the above change the below comments will be addressed. > > Please note that it is not about just resetting the flag. Someone has to reset > lobf enable bit in ALPM_CTL as well. Agree, will add a check for (old_crtc_state->has_lobf && !new_crtc_state->has_lobf) to clear the bitfield of ALPM_CTL. Regards, Animesh > > BR, > > Jouni Högander > > > > > Regards, > > Animesh > > > > > > > > Another thing here is that lobf is never disabled after it gets > > > enabled? > > > > > > Please also review cases where lobf needs to be disabled. E.g. > > > refresh rate > > > change. See bspec 71041. > > > > > > BR, > > > > > > Jouni Högander > > > > > > > > Regards, > > > > Animesh > > > > > > > > > > > > > > BR, > > > > > > > > > > Jouni Högander > > > > > > + } > > > > > > +} > > > > > > + > > > > > > static int i915_edp_lobf_info_show(struct seq_file *m, void > > > > > > *data) > > > > > > { > > > > > > struct intel_connector *connector = m->private; diff > > > > > > -- > > > > > > git a/drivers/gpu/drm/i915/display/intel_alpm.h > > > > > > b/drivers/gpu/drm/i915/display/intel_alpm.h > > > > > > index 8c409b10dce6..2f862b0476a8 100644 > > > > > > --- a/drivers/gpu/drm/i915/display/intel_alpm.h > > > > > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.h > > > > > > @@ -12,6 +12,8 @@ struct intel_dp; > > > > > > struct intel_crtc_state; > > > > > > struct drm_connector_state; > > > > > > struct intel_connector; > > > > > > +struct intel_atomic_state; > > > > > > +struct intel_crtc; > > > > > > > > > > > > void intel_alpm_init_dpcd(struct intel_dp *intel_dp); > > > > > > bool intel_alpm_compute_params(struct intel_dp *intel_dp, @@ > > > > > > - > > > > > > 21,6 > > > > > > +23,8 @@ void intel_alpm_lobf_compute_config(struct intel_dp > > > > > > *intel_dp, > > > > > > struct drm_connector_state > > > > > > *conn_state); > > > > > > void intel_alpm_configure(struct intel_dp *intel_dp, > > > > > > const struct intel_crtc_state > > > > > > *crtc_state); > > > > > > +void intel_alpm_post_plane_update(struct intel_atomic_state > > > > > > *state, > > > > > > + struct intel_crtc *crtc); > > > > > > void intel_alpm_lobf_debugfs_add(struct intel_connector > > > > > > *connector); > > > > > > bool intel_alpm_aux_wake_supported(struct intel_dp > > > > > > *intel_dp); > > > > > > bool intel_alpm_aux_less_wake_supported(struct intel_dp > > > > > > *intel_dp); diff --git > > > > > > a/drivers/gpu/drm/i915/display/intel_display.c > > > > > > b/drivers/gpu/drm/i915/display/intel_display.c > > > > > > index 4805bf682d43..ffd96b187e5e 100644 > > > > > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > > > > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > > > > > @@ -55,6 +55,7 @@ > > > > > > #include "i9xx_plane.h" > > > > > > #include "i9xx_plane_regs.h" > > > > > > #include "i9xx_wm.h" > > > > > > +#include "intel_alpm.h" > > > > > > #include "intel_atomic.h" > > > > > > #include "intel_atomic_plane.h" > > > > > > #include "intel_audio.h" > > > > > > @@ -1190,6 +1191,8 @@ static void > > > > > > intel_post_plane_update(struct intel_atomic_state *state, > > > > > > > > > > > > intel_psr_post_plane_update(state, crtc); > > > > > > > > > > > > + intel_alpm_post_plane_update(state, crtc); > > > > > > + > > > > > > intel_frontbuffer_flip(dev_priv, new_crtc_state- > > > > > > > fb_bits); > > > > > > > > > > > > if (new_crtc_state->update_wm_post && new_crtc_state- > > > > > > > hw.active) > > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] drm/i915/lobf: Add debug print for LOBF 2024-12-04 10:03 [PATCH v2 0/2] LOBF enablement fix Animesh Manna 2024-12-04 10:03 ` [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna @ 2024-12-04 10:03 ` Animesh Manna 2024-12-04 13:00 ` ✗ Fi.CI.SPARSE: warning for LOBF enablement fix (rev2) Patchwork ` (2 subsequent siblings) 4 siblings, 0 replies; 14+ messages in thread From: Animesh Manna @ 2024-12-04 10:03 UTC (permalink / raw) To: intel-gfx; +Cc: jouni.hogander, jani.nikula, jeevan.b, Animesh Manna Lobf is enabled part of ALPM configuration and if has_lobf is set to true respective bit for LOBF will be set. Add debug print while setting the bitfield of LOBF. Signed-off-by: Animesh Manna <animesh.manna@intel.com> --- drivers/gpu/drm/i915/display/intel_alpm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c index 75063342a100..5fa6b36b0193 100644 --- a/drivers/gpu/drm/i915/display/intel_alpm.c +++ b/drivers/gpu/drm/i915/display/intel_alpm.c @@ -353,8 +353,10 @@ static void lnl_alpm_configure(struct intel_dp *intel_dp, ALPM_CTL_EXTENDED_FAST_WAKE_TIME(intel_dp->alpm_parameters.fast_wake_lines); } - if (crtc_state->has_lobf) + if (crtc_state->has_lobf) { alpm_ctl |= ALPM_CTL_LOBF_ENABLE; + drm_dbg_kms(display->drm, "Link off between frames (LOBF) enabled\n"); + } alpm_ctl |= ALPM_CTL_ALPM_ENTRY_CHECK(intel_dp->alpm_parameters.check_entry_lines); -- 2.29.0 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* ✗ Fi.CI.SPARSE: warning for LOBF enablement fix (rev2) 2024-12-04 10:03 [PATCH v2 0/2] LOBF enablement fix Animesh Manna 2024-12-04 10:03 ` [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna 2024-12-04 10:03 ` [PATCH v2 2/2] drm/i915/lobf: Add debug print for LOBF Animesh Manna @ 2024-12-04 13:00 ` Patchwork 2024-12-04 13:12 ` ✗ i915.CI.BAT: failure " Patchwork 2024-12-09 8:43 ` [PATCH v2 0/2] LOBF enablement fix Hogander, Jouni 4 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2024-12-04 13:00 UTC (permalink / raw) To: Manna, Animesh; +Cc: intel-gfx == Series Details == Series: LOBF enablement fix (rev2) URL : https://patchwork.freedesktop.org/series/141974/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:116:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:147:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:149:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:153:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:155:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:173:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:175:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:179:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:181:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:185:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:187:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:191:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:194:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:236:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:238:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:243:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:243:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:243:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:243:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:243:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:243:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:243:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:243:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:245:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:245:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:245:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:245:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:245:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:245:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:245:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:245:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:137:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:137:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:137:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:137:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:137:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:137:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:137:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:137:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:139:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:139:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:139:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:139:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:139:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:139:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:139:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:139:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'break' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'break' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'break' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'break' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'break' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'break' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'break' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'break' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'continue' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'continue' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'continue' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'continue' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'continue' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'continue' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'continue' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'continue' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:23: warning: unreplaced symbol '___p1' +./include/asm-generic/bitops/generic-non-atomic.h:140:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:140:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:140:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:140:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:140:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:140:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:140:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:140:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:151:1: warning: too many warnings +./include/asm-generic/bitops/instrumented-non-atomic.h:151:1: warning: too many warnings +./include/asm-generic/bitops/instrumented-non-atomic.h:151:1: warning: too many warnings +./include/asm-generic/bitops/instrumented-non-atomic.h:151:1: warning: too many warnings +./include/asm-generic/bitops/instrumented-non-atomic.h:151:1: warning: too many warnings +./include/asm-generic/bitops/instrumented-non-atomic.h:151:1: warning: too many warnings +./include/asm-generic/bitops/instrumented-non-atomic.h:151:1: warning: too many warnings +./include/asm-generic/bitops/instrumented-non-atomic.h:151:1: warning: too many warnings +./include/asm-generic/bitops/instrumented-non-atomic.h:154:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:154:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:154:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:154:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:154:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:154:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:154:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:154:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' /home/kbuild2/linux/maintainer-tools/dim: line 2106: echo: write error: Broken pipe ^ permalink raw reply [flat|nested] 14+ messages in thread
* ✗ i915.CI.BAT: failure for LOBF enablement fix (rev2) 2024-12-04 10:03 [PATCH v2 0/2] LOBF enablement fix Animesh Manna ` (2 preceding siblings ...) 2024-12-04 13:00 ` ✗ Fi.CI.SPARSE: warning for LOBF enablement fix (rev2) Patchwork @ 2024-12-04 13:12 ` Patchwork 2024-12-09 8:43 ` [PATCH v2 0/2] LOBF enablement fix Hogander, Jouni 4 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2024-12-04 13:12 UTC (permalink / raw) To: Manna, Animesh; +Cc: intel-gfx == Series Details == Series: LOBF enablement fix (rev2) URL : https://patchwork.freedesktop.org/series/141974/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15786 -> Patchwork_141974v2 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_141974v2 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_141974v2, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141974v2/index.html Participating hosts (44 -> 43) ------------------------------ Missing (1): fi-snb-2520m Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_141974v2: ### IGT changes ### #### Possible regressions #### * igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size: - fi-kbl-7567u: [PASS][1] -> [DMESG-WARN][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15786/fi-kbl-7567u/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141974v2/fi-kbl-7567u/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html Known issues ------------ Here are the changes found in Patchwork_141974v2 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_module_load@reload: - bat-twl-1: [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15786/bat-twl-1/igt@i915_module_load@reload.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141974v2/bat-twl-1/igt@i915_module_load@reload.html * igt@i915_selftest@live@gt_mocs: - bat-twl-2: [PASS][5] -> [ABORT][6] ([i915#12919]) +1 other test abort [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15786/bat-twl-2/igt@i915_selftest@live@gt_mocs.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141974v2/bat-twl-2/igt@i915_selftest@live@gt_mocs.html #### Possible fixes #### * igt@i915_module_load@load: - bat-twl-1: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15786/bat-twl-1/igt@i915_module_load@load.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141974v2/bat-twl-1/igt@i915_module_load@load.html * igt@i915_pm_rpm@module-reload: - bat-rpls-4: [FAIL][9] ([i915#12903]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15786/bat-rpls-4/igt@i915_pm_rpm@module-reload.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141974v2/bat-rpls-4/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live@workarounds: - bat-mtlp-6: [ABORT][11] ([i915#12061]) -> [PASS][12] +1 other test pass [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15786/bat-mtlp-6/igt@i915_selftest@live@workarounds.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141974v2/bat-mtlp-6/igt@i915_selftest@live@workarounds.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061 [i915#12903]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12903 [i915#12919]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919 [i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982 Build changes ------------- * Linux: CI_DRM_15786 -> Patchwork_141974v2 CI-20190529: 20190529 CI_DRM_15786: c8df5caf278df4f9ca0aba627047c5ee4318fc0d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_8137: 8137 Patchwork_141974v2: c8df5caf278df4f9ca0aba627047c5ee4318fc0d @ git://anongit.freedesktop.org/gfx-ci/linux == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141974v2/index.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/2] LOBF enablement fix 2024-12-04 10:03 [PATCH v2 0/2] LOBF enablement fix Animesh Manna ` (3 preceding siblings ...) 2024-12-04 13:12 ` ✗ i915.CI.BAT: failure " Patchwork @ 2024-12-09 8:43 ` Hogander, Jouni 2024-12-09 11:40 ` Manna, Animesh 4 siblings, 1 reply; 14+ messages in thread From: Hogander, Jouni @ 2024-12-09 8:43 UTC (permalink / raw) To: Manna, Animesh, intel-gfx@lists.freedesktop.org; +Cc: Nikula, Jani, B, Jeevan Generic comments on these patches. These are enabling LOBF if it's possible. Possible errors are not taken into account. I think DP_ALPM_LOCK_TIMEOUT_ERROR should be taken into account in LOBF as well: See drivers/gpu/drm/i915/display/intel_psr.c:psr_alpm_check. You might also want to add some debug interface to disable lobf. I can imagine this being feature not working on all setups where possible on first try. Debugging/bisecting would be much easier if you have such interface. BR, Jouni Högander On Wed, 2024-12-04 at 15:33 +0530, Animesh Manna wrote: > Signed-off-by: Animesh Manna <animesh.manna@intel.com> > > Animesh Manna (2): > drm/i915/lobf: Add lobf enablement in post plane update > drm/i915/lobf: Add debug print for LOBF > > drivers/gpu/drm/i915/display/intel_alpm.c | 29 > +++++++++++++++++++- > drivers/gpu/drm/i915/display/intel_alpm.h | 4 +++ > drivers/gpu/drm/i915/display/intel_display.c | 3 ++ > 3 files changed, 35 insertions(+), 1 deletion(-) > ^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v2 0/2] LOBF enablement fix 2024-12-09 8:43 ` [PATCH v2 0/2] LOBF enablement fix Hogander, Jouni @ 2024-12-09 11:40 ` Manna, Animesh 0 siblings, 0 replies; 14+ messages in thread From: Manna, Animesh @ 2024-12-09 11:40 UTC (permalink / raw) To: Hogander, Jouni, intel-gfx@lists.freedesktop.org; +Cc: Nikula, Jani, B, Jeevan > -----Original Message----- > From: Hogander, Jouni <jouni.hogander@intel.com> > Sent: Monday, December 9, 2024 2:14 PM > To: Manna, Animesh <animesh.manna@intel.com>; intel- > gfx@lists.freedesktop.org > Cc: Nikula, Jani <jani.nikula@intel.com>; B, Jeevan <jeevan.b@intel.com> > Subject: Re: [PATCH v2 0/2] LOBF enablement fix > > Generic comments on these patches. > > These are enabling LOBF if it's possible. Possible errors are not taken into > account. I think DP_ALPM_LOCK_TIMEOUT_ERROR should be taken into > account in LOBF as well: See > drivers/gpu/drm/i915/display/intel_psr.c:psr_alpm_check. Sure, will add checks for LOBF as well. > > You might also want to add some debug interface to disable lobf. I can > imagine this being feature not working on all setups where possible on first > try. Debugging/bisecting would be much easier if you have such interface. Got it, will try to add. Regards, Animesh > > BR, > > Jouni Högander > > On Wed, 2024-12-04 at 15:33 +0530, Animesh Manna wrote: > > Signed-off-by: Animesh Manna <animesh.manna@intel.com> > > > > Animesh Manna (2): > > drm/i915/lobf: Add lobf enablement in post plane update > > drm/i915/lobf: Add debug print for LOBF > > > > drivers/gpu/drm/i915/display/intel_alpm.c | 29 > > +++++++++++++++++++- > > drivers/gpu/drm/i915/display/intel_alpm.h | 4 +++ > > drivers/gpu/drm/i915/display/intel_display.c | 3 ++ > > 3 files changed, 35 insertions(+), 1 deletion(-) > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 0/2] LOBF enablement fix @ 2024-12-09 7:50 Animesh Manna 2024-12-09 7:50 ` [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna 0 siblings, 1 reply; 14+ messages in thread From: Animesh Manna @ 2024-12-09 7:50 UTC (permalink / raw) To: intel-xe; +Cc: jouni.hogander, jani.nikula, jeevan.b, Animesh Manna Signed-off-by: Animesh Manna <animesh.manna@intel.com> Animesh Manna (2): drm/i915/lobf: Add lobf enablement in post plane update drm/i915/lobf: Add debug print for LOBF drivers/gpu/drm/i915/display/intel_alpm.c | 29 +++++++++++++++++++- drivers/gpu/drm/i915/display/intel_alpm.h | 4 +++ drivers/gpu/drm/i915/display/intel_display.c | 3 ++ 3 files changed, 35 insertions(+), 1 deletion(-) -- 2.29.0 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update 2024-12-09 7:50 Animesh Manna @ 2024-12-09 7:50 ` Animesh Manna 0 siblings, 0 replies; 14+ messages in thread From: Animesh Manna @ 2024-12-09 7:50 UTC (permalink / raw) To: intel-xe; +Cc: jouni.hogander, jani.nikula, jeevan.b, Animesh Manna Enablement of LOBF is added in post plane update whenever has_lobf flag is set. As LOBF can be enabled in non-psr case as well so adding in post plane update. There is no change of configuring alpm with psr path. v1: Initial version. v2: Use encoder-mask to find the associated encoder from crtc-state. [Jani] Signed-off-by: Animesh Manna <animesh.manna@intel.com> --- drivers/gpu/drm/i915/display/intel_alpm.c | 25 ++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_alpm.h | 4 ++++ drivers/gpu/drm/i915/display/intel_display.c | 3 +++ 3 files changed, 32 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c index 55f3ae1e68c9..75063342a100 100644 --- a/drivers/gpu/drm/i915/display/intel_alpm.c +++ b/drivers/gpu/drm/i915/display/intel_alpm.c @@ -367,6 +367,31 @@ void intel_alpm_configure(struct intel_dp *intel_dp, lnl_alpm_configure(intel_dp, crtc_state); } +void intel_alpm_post_plane_update(struct intel_atomic_state *state, + struct intel_crtc *crtc) +{ + struct intel_display *display = to_intel_display(state); + const struct intel_crtc_state *crtc_state = + intel_atomic_get_new_crtc_state(state, crtc); + struct intel_encoder *encoder; + + if (!crtc_state->has_lobf) + return; + + for_each_intel_encoder_mask(display->drm, encoder, + crtc_state->uapi.encoder_mask) { + struct intel_dp *intel_dp; + + if (!intel_encoder_is_dp(encoder)) + continue; + + intel_dp = enc_to_intel_dp(encoder); + + if (intel_dp_is_edp(intel_dp)) + intel_alpm_configure(intel_dp, crtc_state); + } +} + static int i915_edp_lobf_info_show(struct seq_file *m, void *data) { struct intel_connector *connector = m->private; diff --git a/drivers/gpu/drm/i915/display/intel_alpm.h b/drivers/gpu/drm/i915/display/intel_alpm.h index 8c409b10dce6..2f862b0476a8 100644 --- a/drivers/gpu/drm/i915/display/intel_alpm.h +++ b/drivers/gpu/drm/i915/display/intel_alpm.h @@ -12,6 +12,8 @@ struct intel_dp; struct intel_crtc_state; struct drm_connector_state; struct intel_connector; +struct intel_atomic_state; +struct intel_crtc; void intel_alpm_init_dpcd(struct intel_dp *intel_dp); bool intel_alpm_compute_params(struct intel_dp *intel_dp, @@ -21,6 +23,8 @@ void intel_alpm_lobf_compute_config(struct intel_dp *intel_dp, struct drm_connector_state *conn_state); void intel_alpm_configure(struct intel_dp *intel_dp, const struct intel_crtc_state *crtc_state); +void intel_alpm_post_plane_update(struct intel_atomic_state *state, + struct intel_crtc *crtc); void intel_alpm_lobf_debugfs_add(struct intel_connector *connector); bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp); bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp); diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 4805bf682d43..ffd96b187e5e 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -55,6 +55,7 @@ #include "i9xx_plane.h" #include "i9xx_plane_regs.h" #include "i9xx_wm.h" +#include "intel_alpm.h" #include "intel_atomic.h" #include "intel_atomic_plane.h" #include "intel_audio.h" @@ -1190,6 +1191,8 @@ static void intel_post_plane_update(struct intel_atomic_state *state, intel_psr_post_plane_update(state, crtc); + intel_alpm_post_plane_update(state, crtc); + intel_frontbuffer_flip(dev_priv, new_crtc_state->fb_bits); if (new_crtc_state->update_wm_post && new_crtc_state->hw.active) -- 2.29.0 ^ permalink raw reply related [flat|nested] 14+ messages in thread
end of thread, other threads:[~2024-12-09 12:29 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-12-04 10:03 [PATCH v2 0/2] LOBF enablement fix Animesh Manna 2024-12-04 10:03 ` [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna 2024-12-09 8:35 ` Hogander, Jouni 2024-12-09 11:19 ` Manna, Animesh 2024-12-09 11:34 ` Hogander, Jouni 2024-12-09 11:54 ` Manna, Animesh 2024-12-09 11:59 ` Hogander, Jouni 2024-12-09 12:29 ` Manna, Animesh 2024-12-04 10:03 ` [PATCH v2 2/2] drm/i915/lobf: Add debug print for LOBF Animesh Manna 2024-12-04 13:00 ` ✗ Fi.CI.SPARSE: warning for LOBF enablement fix (rev2) Patchwork 2024-12-04 13:12 ` ✗ i915.CI.BAT: failure " Patchwork 2024-12-09 8:43 ` [PATCH v2 0/2] LOBF enablement fix Hogander, Jouni 2024-12-09 11:40 ` Manna, Animesh -- strict thread matches above, loose matches on Subject: below -- 2024-12-09 7:50 Animesh Manna 2024-12-09 7:50 ` [PATCH v2 1/2] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.