* [PATCH] drm/amdgpu/atom: fix ps allocation size for EnableDispPowerGating
@ 2017-06-15 15:17 Alex Deucher
[not found] ` <1497539827-26354-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-06-19 16:58 ` [PATCH] drm/amdgpu/atom: fix ps allocation size for EnableDispPowerGating Alex Deucher
0 siblings, 2 replies; 9+ messages in thread
From: Alex Deucher @ 2017-06-15 15:17 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher, stable
We were using the wrong structure which lead to an overflow
on some boards.
bug: https://bugs.freedesktop.org/show_bug.cgi?id=101387
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c b/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c
index 8c9bc75..8a0818b 100644
--- a/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c
+++ b/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c
@@ -165,7 +165,7 @@ void amdgpu_atombios_crtc_powergate(struct drm_crtc *crtc, int state)
struct drm_device *dev = crtc->dev;
struct amdgpu_device *adev = dev->dev_private;
int index = GetIndexIntoMasterTable(COMMAND, EnableDispPowerGating);
- ENABLE_DISP_POWER_GATING_PARAMETERS_V2_1 args;
+ ENABLE_DISP_POWER_GATING_PS_ALLOCATION args;
memset(&args, 0, sizeof(args));
@@ -178,7 +178,7 @@ void amdgpu_atombios_crtc_powergate(struct drm_crtc *crtc, int state)
void amdgpu_atombios_crtc_powergate_init(struct amdgpu_device *adev)
{
int index = GetIndexIntoMasterTable(COMMAND, EnableDispPowerGating);
- ENABLE_DISP_POWER_GATING_PARAMETERS_V2_1 args;
+ ENABLE_DISP_POWER_GATING_PS_ALLOCATION args;
memset(&args, 0, sizeof(args));
--
2.5.5
^ permalink raw reply related [flat|nested] 9+ messages in thread[parent not found: <1497539827-26354-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>]
* [PATCH] drm/amdgpu: adjust default display clock
2017-06-15 15:17 [PATCH] drm/amdgpu/atom: fix ps allocation size for EnableDispPowerGating Alex Deucher
@ 2017-06-15 15:17 ` Alex Deucher
2017-06-19 16:58 ` [PATCH] drm/amdgpu/atom: fix ps allocation size for EnableDispPowerGating Alex Deucher
1 sibling, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2017-06-15 15:17 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Alex Deucher, stable-u79uwXL29TY76Z2rM5mHXA
Increase the default display clock on newer asics to
accomodate some high res modes with really high refresh
rates.
bug: https://bugs.freedesktop.org/show_bug.cgi?id=93826
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
index 1cf78f4..1e8e112 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
@@ -693,6 +693,10 @@ int amdgpu_atombios_get_clock_info(struct amdgpu_device *adev)
DRM_INFO("Changing default dispclk from %dMhz to 600Mhz\n",
adev->clock.default_dispclk / 100);
adev->clock.default_dispclk = 60000;
+ } else if (adev->clock.default_dispclk <= 60000) {
+ DRM_INFO("Changing default dispclk from %dMhz to 625Mhz\n",
+ adev->clock.default_dispclk / 100);
+ adev->clock.default_dispclk = 62500;
}
adev->clock.dp_extclk =
le16_to_cpu(firmware_info->info_21.usUniphyDPModeExtClkFreq);
--
2.5.5
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] drm/amdgpu: adjust default display clock
@ 2017-06-15 15:17 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2017-06-15 15:17 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher, stable
Increase the default display clock on newer asics to
accomodate some high res modes with really high refresh
rates.
bug: https://bugs.freedesktop.org/show_bug.cgi?id=93826
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
index 1cf78f4..1e8e112 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
@@ -693,6 +693,10 @@ int amdgpu_atombios_get_clock_info(struct amdgpu_device *adev)
DRM_INFO("Changing default dispclk from %dMhz to 600Mhz\n",
adev->clock.default_dispclk / 100);
adev->clock.default_dispclk = 60000;
+ } else if (adev->clock.default_dispclk <= 60000) {
+ DRM_INFO("Changing default dispclk from %dMhz to 625Mhz\n",
+ adev->clock.default_dispclk / 100);
+ adev->clock.default_dispclk = 62500;
}
adev->clock.dp_extclk =
le16_to_cpu(firmware_info->info_21.usUniphyDPModeExtClkFreq);
--
2.5.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] drm/amdgpu: adjust default display clock
2017-06-15 15:17 ` Alex Deucher
(?)
@ 2017-06-19 17:36 ` Alex Deucher
[not found] ` <CADnq5_PP=wMVi5JayAcF-0HGKAeZbhS+pyhV1OW5LeW1dVqHsQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
-1 siblings, 1 reply; 9+ messages in thread
From: Alex Deucher @ 2017-06-19 17:36 UTC (permalink / raw)
To: amd-gfx list; +Cc: Alex Deucher, for 3.8
ping.
On Thu, Jun 15, 2017 at 11:17 AM, Alex Deucher <alexdeucher@gmail.com> wrote:
> Increase the default display clock on newer asics to
> accomodate some high res modes with really high refresh
> rates.
>
> bug: https://bugs.freedesktop.org/show_bug.cgi?id=93826
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
> index 1cf78f4..1e8e112 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
> @@ -693,6 +693,10 @@ int amdgpu_atombios_get_clock_info(struct amdgpu_device *adev)
> DRM_INFO("Changing default dispclk from %dMhz to 600Mhz\n",
> adev->clock.default_dispclk / 100);
> adev->clock.default_dispclk = 60000;
> + } else if (adev->clock.default_dispclk <= 60000) {
> + DRM_INFO("Changing default dispclk from %dMhz to 625Mhz\n",
> + adev->clock.default_dispclk / 100);
> + adev->clock.default_dispclk = 62500;
> }
> adev->clock.dp_extclk =
> le16_to_cpu(firmware_info->info_21.usUniphyDPModeExtClkFreq);
> --
> 2.5.5
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/amdgpu/atom: fix ps allocation size for EnableDispPowerGating
2017-06-15 15:17 [PATCH] drm/amdgpu/atom: fix ps allocation size for EnableDispPowerGating Alex Deucher
[not found] ` <1497539827-26354-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
@ 2017-06-19 16:58 ` Alex Deucher
[not found] ` <CADnq5_NQvtnLjGuwDPK2yOVUWcG=twAzXmGbyiXg+vODGymeNg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
1 sibling, 1 reply; 9+ messages in thread
From: Alex Deucher @ 2017-06-19 16:58 UTC (permalink / raw)
To: amd-gfx list; +Cc: Alex Deucher, for 3.8
Ping?
On Thu, Jun 15, 2017 at 11:17 AM, Alex Deucher <alexdeucher@gmail.com> wrote:
> We were using the wrong structure which lead to an overflow
> on some boards.
>
> bug: https://bugs.freedesktop.org/show_bug.cgi?id=101387
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c b/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c
> index 8c9bc75..8a0818b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c
> @@ -165,7 +165,7 @@ void amdgpu_atombios_crtc_powergate(struct drm_crtc *crtc, int state)
> struct drm_device *dev = crtc->dev;
> struct amdgpu_device *adev = dev->dev_private;
> int index = GetIndexIntoMasterTable(COMMAND, EnableDispPowerGating);
> - ENABLE_DISP_POWER_GATING_PARAMETERS_V2_1 args;
> + ENABLE_DISP_POWER_GATING_PS_ALLOCATION args;
>
> memset(&args, 0, sizeof(args));
>
> @@ -178,7 +178,7 @@ void amdgpu_atombios_crtc_powergate(struct drm_crtc *crtc, int state)
> void amdgpu_atombios_crtc_powergate_init(struct amdgpu_device *adev)
> {
> int index = GetIndexIntoMasterTable(COMMAND, EnableDispPowerGating);
> - ENABLE_DISP_POWER_GATING_PARAMETERS_V2_1 args;
> + ENABLE_DISP_POWER_GATING_PS_ALLOCATION args;
>
> memset(&args, 0, sizeof(args));
>
> --
> 2.5.5
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-06-20 8:37 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-15 15:17 [PATCH] drm/amdgpu/atom: fix ps allocation size for EnableDispPowerGating Alex Deucher
[not found] ` <1497539827-26354-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-06-15 15:17 ` [PATCH] drm/amdgpu: adjust default display clock Alex Deucher
2017-06-15 15:17 ` Alex Deucher
2017-06-19 17:36 ` Alex Deucher
[not found] ` <CADnq5_PP=wMVi5JayAcF-0HGKAeZbhS+pyhV1OW5LeW1dVqHsQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-20 2:40 ` zhoucm1
[not found] ` <59488B03.1070409-5C7GfCeVMHo@public.gmane.org>
2017-06-20 8:37 ` Christian König
2017-06-20 8:37 ` Christian König
2017-06-19 16:58 ` [PATCH] drm/amdgpu/atom: fix ps allocation size for EnableDispPowerGating Alex Deucher
[not found] ` <CADnq5_NQvtnLjGuwDPK2yOVUWcG=twAzXmGbyiXg+vODGymeNg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-20 2:38 ` zhoucm1
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.