Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices

[jeffy <jeffy.chen@rock-chips.com>]

Hi Krzysztof,

thanx for your comment.

On 06/21/2017 06:45 PM, Krzysztof Kozlowski wrote:
> On Wed, Jun 21, 2017 at 12:01 PM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
>> We used to enable wakeup for cros-ec-spi devices unconditionally.
>> Now we are using the more generic wakeup-source property to enable it.
>
> Using wakeup-source property is still enabling this unconditionally.
> What  do you exactly mean here?
i mean the wakeup-source is an optional property, we can disable wakeup 
by not adding it.

but now i enable it to all exist cros-ec-spi devices for not breaking 
current stuffs :)
>
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> ---
>>
>> Changes in v3: None
>>
>>   arch/arm/boot/dts/exynos5420-peach-pit.dts      | 1 +
>>   arch/arm/boot/dts/exynos5800-peach-pi.dts       | 1 +
>>   arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 1 +
>>   arch/arm/boot/dts/tegra124-nyan.dtsi            | 1 +
>>   arch/arm/boot/dts/tegra124-venice2.dts          | 1 +
>>   arch/arm64/boot/dts/nvidia/tegra132-norrin.dts  | 1 +
>>   arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi    | 1 +
>>   7 files changed, 7 insertions(+)
>
> Please split it per arch (arm and arm64) and per machine. I'll take
> exynos after splitting.
ok, sounds good, will do it in next version, thanx~
>
> Best regards,
> Krzysztof
>
>
>