From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/5] ARM: dts: Fix the sort ordering of EHCI and HSIC in rk3288.dtsi
Date: Fri, 01 Aug 2014 11:17:27 +0200 [thread overview]
Message-ID: <5965899.y405fxfhDg@diego> (raw)
In-Reply-To: <1406846976-23127-4-git-send-email-dianders@chromium.org>
Am Donnerstag, 31. Juli 2014, 15:49:35 schrieb Doug Anderson:
> The EHCI and HSIC device tree nodes were added in the wrong place.
> Fix them.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
hmm, not sure if this counts as fix ... aka material for 3.17-rc2 or should
wait for 3.18. Simply because it's more a cosmetic thing.
If it is a fix, could base it on the appropriate dts revision, because here
it's in the middle of the dwc2 series, including the
usb_host1: usb at ff540000
nodes.
Heiko
> ---
> Changes in v4:
> - Based on the proper patch
>
> Changes in v3:
> - EHCI and HSIC move new for version 3.
>
> arch/arm/boot/dts/rk3288.dtsi | 41
> ++++++++++++++++++++--------------------- 1 file changed, 20 insertions(+),
> 21 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 9713054..49c99f2 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -156,6 +156,17 @@
> status = "disabled";
> };
>
> + usb_host0_ehci: usb at ff500000 {
> + compatible = "generic-ehci";
> + reg = <0xff500000 0x100>;
> + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru HCLK_USBHOST0>;
> + clock-names = "usbhost";
> + status = "disabled";
> + };
> +
> + /* NOTE: ohci at ff520000 doesn't actually work on hardware */
> +
> usb_host1: usb at ff540000 {
> compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
> "snps,dwc2";
> @@ -176,6 +187,15 @@
> status = "disabled";
> };
>
> + usb_hsic: usb at ff5c0000 {
> + compatible = "generic-ehci";
> + reg = <0xff5c0000 0x100>;
> + interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru HCLK_HSIC>;
> + clock-names = "usbhost";
> + status = "disabled";
> + };
> +
> uart2: serial at ff690000 {
> compatible = "rockchip,rk3288-uart", "snps,dw-apb-uart";
> reg = <0xff690000 0x100>;
> @@ -270,27 +290,6 @@
> interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> };
> -
> - usb_host0_ehci: usb at ff500000 {
> - compatible = "generic-ehci";
> - reg = <0xff500000 0x100>;
> - interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cru HCLK_USBHOST0>;
> - clock-names = "usbhost";
> - status = "disabled";
> - };
> -
> - /* NOTE: ohci at ff520000 doesn't actually work on hardware */
> -
> - usb_hsic: usb at ff5c0000 {
> - compatible = "generic-ehci";
> - reg = <0xff5c0000 0x100>;
> - interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cru HCLK_HSIC>;
> - clock-names = "usbhost";
> - status = "disabled";
> - };
> -
> gic: interrupt-controller at ffc01000 {
> compatible = "arm,gic-400";
> interrupt-controller;
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org
Cc: Paul Zimmerman <paulz-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
Sonny Rao <sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 4/5] ARM: dts: Fix the sort ordering of EHCI and HSIC in rk3288.dtsi
Date: Fri, 01 Aug 2014 11:17:27 +0200 [thread overview]
Message-ID: <5965899.y405fxfhDg@diego> (raw)
In-Reply-To: <1406846976-23127-4-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Am Donnerstag, 31. Juli 2014, 15:49:35 schrieb Doug Anderson:
> The EHCI and HSIC device tree nodes were added in the wrong place.
> Fix them.
>
> Signed-off-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Signed-off-by: Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
hmm, not sure if this counts as fix ... aka material for 3.17-rc2 or should
wait for 3.18. Simply because it's more a cosmetic thing.
If it is a fix, could base it on the appropriate dts revision, because here
it's in the middle of the dwc2 series, including the
usb_host1: usb@ff540000
nodes.
Heiko
> ---
> Changes in v4:
> - Based on the proper patch
>
> Changes in v3:
> - EHCI and HSIC move new for version 3.
>
> arch/arm/boot/dts/rk3288.dtsi | 41
> ++++++++++++++++++++--------------------- 1 file changed, 20 insertions(+),
> 21 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 9713054..49c99f2 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -156,6 +156,17 @@
> status = "disabled";
> };
>
> + usb_host0_ehci: usb@ff500000 {
> + compatible = "generic-ehci";
> + reg = <0xff500000 0x100>;
> + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru HCLK_USBHOST0>;
> + clock-names = "usbhost";
> + status = "disabled";
> + };
> +
> + /* NOTE: ohci@ff520000 doesn't actually work on hardware */
> +
> usb_host1: usb@ff540000 {
> compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
> "snps,dwc2";
> @@ -176,6 +187,15 @@
> status = "disabled";
> };
>
> + usb_hsic: usb@ff5c0000 {
> + compatible = "generic-ehci";
> + reg = <0xff5c0000 0x100>;
> + interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru HCLK_HSIC>;
> + clock-names = "usbhost";
> + status = "disabled";
> + };
> +
> uart2: serial@ff690000 {
> compatible = "rockchip,rk3288-uart", "snps,dw-apb-uart";
> reg = <0xff690000 0x100>;
> @@ -270,27 +290,6 @@
> interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> };
> -
> - usb_host0_ehci: usb@ff500000 {
> - compatible = "generic-ehci";
> - reg = <0xff500000 0x100>;
> - interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cru HCLK_USBHOST0>;
> - clock-names = "usbhost";
> - status = "disabled";
> - };
> -
> - /* NOTE: ohci@ff520000 doesn't actually work on hardware */
> -
> - usb_hsic: usb@ff5c0000 {
> - compatible = "generic-ehci";
> - reg = <0xff5c0000 0x100>;
> - interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cru HCLK_HSIC>;
> - clock-names = "usbhost";
> - status = "disabled";
> - };
> -
> gic: interrupt-controller@ffc01000 {
> compatible = "arm,gic-400";
> interrupt-controller;
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Doug Anderson <dianders@chromium.org>, olof@lixom.net
Cc: Paul Zimmerman <paulz@synopsys.com>,
kever.yang@rock-chips.com, Sonny Rao <sonnyrao@chromium.org>,
linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/5] ARM: dts: Fix the sort ordering of EHCI and HSIC in rk3288.dtsi
Date: Fri, 01 Aug 2014 11:17:27 +0200 [thread overview]
Message-ID: <5965899.y405fxfhDg@diego> (raw)
In-Reply-To: <1406846976-23127-4-git-send-email-dianders@chromium.org>
Am Donnerstag, 31. Juli 2014, 15:49:35 schrieb Doug Anderson:
> The EHCI and HSIC device tree nodes were added in the wrong place.
> Fix them.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
hmm, not sure if this counts as fix ... aka material for 3.17-rc2 or should
wait for 3.18. Simply because it's more a cosmetic thing.
If it is a fix, could base it on the appropriate dts revision, because here
it's in the middle of the dwc2 series, including the
usb_host1: usb@ff540000
nodes.
Heiko
> ---
> Changes in v4:
> - Based on the proper patch
>
> Changes in v3:
> - EHCI and HSIC move new for version 3.
>
> arch/arm/boot/dts/rk3288.dtsi | 41
> ++++++++++++++++++++--------------------- 1 file changed, 20 insertions(+),
> 21 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 9713054..49c99f2 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -156,6 +156,17 @@
> status = "disabled";
> };
>
> + usb_host0_ehci: usb@ff500000 {
> + compatible = "generic-ehci";
> + reg = <0xff500000 0x100>;
> + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru HCLK_USBHOST0>;
> + clock-names = "usbhost";
> + status = "disabled";
> + };
> +
> + /* NOTE: ohci@ff520000 doesn't actually work on hardware */
> +
> usb_host1: usb@ff540000 {
> compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
> "snps,dwc2";
> @@ -176,6 +187,15 @@
> status = "disabled";
> };
>
> + usb_hsic: usb@ff5c0000 {
> + compatible = "generic-ehci";
> + reg = <0xff5c0000 0x100>;
> + interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru HCLK_HSIC>;
> + clock-names = "usbhost";
> + status = "disabled";
> + };
> +
> uart2: serial@ff690000 {
> compatible = "rockchip,rk3288-uart", "snps,dw-apb-uart";
> reg = <0xff690000 0x100>;
> @@ -270,27 +290,6 @@
> interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> };
> -
> - usb_host0_ehci: usb@ff500000 {
> - compatible = "generic-ehci";
> - reg = <0xff500000 0x100>;
> - interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cru HCLK_USBHOST0>;
> - clock-names = "usbhost";
> - status = "disabled";
> - };
> -
> - /* NOTE: ohci@ff520000 doesn't actually work on hardware */
> -
> - usb_hsic: usb@ff5c0000 {
> - compatible = "generic-ehci";
> - reg = <0xff5c0000 0x100>;
> - interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cru HCLK_HSIC>;
> - clock-names = "usbhost";
> - status = "disabled";
> - };
> -
> gic: interrupt-controller@ffc01000 {
> compatible = "arm,gic-400";
> interrupt-controller;
next prev parent reply other threads:[~2014-08-01 9:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 22:49 [PATCH v4 4/5] ARM: dts: Fix the sort ordering of EHCI and HSIC in rk3288.dtsi Doug Anderson
2014-07-31 22:49 ` Doug Anderson
2014-07-31 22:49 ` Doug Anderson
2014-08-01 9:17 ` Heiko Stübner [this message]
2014-08-01 9:17 ` Heiko Stübner
2014-08-01 9:17 ` Heiko Stübner
2014-08-02 5:06 ` Doug Anderson
2014-08-02 5:06 ` Doug Anderson
2014-08-02 5:06 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5965899.y405fxfhDg@diego \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.