From: jeffy.chen@rock-chips.com (jeffy)
To: linux-snps-arc@lists.infradead.org
Subject: [RFC PATCH 1/5] serial: arc: Remove __init marking from early write
Date: Tue, 18 Jul 2017 14:06:05 +0800 [thread overview]
Message-ID: <596DA54D.8060001@rock-chips.com> (raw)
In-Reply-To: <20170718050838.GA7529@kroah.com>
Hi Greg,
On 07/18/2017 01:08 PM, Greg KH wrote:
> On Tue, Jul 18, 2017@12:29:59PM +0800, Jeffy Chen wrote:
>> The earlycon would be alive outside the init code in these cases:
>> 1/ we have keep_bootcon in cmdline.
>> 2/ we don't have a real console to switch to.
>>
>> So remove the __init marking to avoid invalid memory access.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen at rock-chips.com>
>> ---
>>
>
> I can't apply "RFC" patches. If you have tested and found this series
> to be correct, can you resend it without that on the patch?
oh, sorry, i'll resend it :)
but i'm still not sure how to fix other hang cases(mentioned in the
cover-letter, earlycon's required clks/pm domain been disabled by ignore
unused initcalls or serial console driver's runtime suspend).
>
> thanks,
>
> greg k-h
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: jeffy <jeffy.chen@rock-chips.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org,
dianders@chromium.org, peter@hurleysoftware.com,
Jiri Slaby <jslaby@suse.com>, Vineet Gupta <vgupta@synopsys.com>,
linux-serial@vger.kernel.org, linux-snps-arc@lists.infradead.org
Subject: Re: [RFC PATCH 1/5] serial: arc: Remove __init marking from early write
Date: Tue, 18 Jul 2017 14:06:05 +0800 [thread overview]
Message-ID: <596DA54D.8060001@rock-chips.com> (raw)
In-Reply-To: <20170718050838.GA7529@kroah.com>
Hi Greg,
On 07/18/2017 01:08 PM, Greg KH wrote:
> On Tue, Jul 18, 2017 at 12:29:59PM +0800, Jeffy Chen wrote:
>> The earlycon would be alive outside the init code in these cases:
>> 1/ we have keep_bootcon in cmdline.
>> 2/ we don't have a real console to switch to.
>>
>> So remove the __init marking to avoid invalid memory access.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> ---
>>
>
> I can't apply "RFC" patches. If you have tested and found this series
> to be correct, can you resend it without that on the patch?
oh, sorry, i'll resend it :)
but i'm still not sure how to fix other hang cases(mentioned in the
cover-letter, earlycon's required clks/pm domain been disabled by ignore
unused initcalls or serial console driver's runtime suspend).
>
> thanks,
>
> greg k-h
>
>
>
next prev parent reply other threads:[~2017-07-18 6:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 4:29 [RFC PATCH 0/5] earlycon hang under some conditions Jeffy Chen
2017-07-18 4:29 ` Jeffy Chen
2017-07-18 4:29 ` Jeffy Chen
2017-07-18 4:29 ` [RFC PATCH 1/5] serial: arc: Remove __init marking from early write Jeffy Chen
2017-07-18 4:29 ` Jeffy Chen
2017-07-18 5:08 ` Greg KH
2017-07-18 5:08 ` Greg KH
2017-07-18 6:06 ` jeffy [this message]
2017-07-18 6:06 ` jeffy
2017-07-18 4:30 ` [RFC PATCH 2/5] serial: omap: " Jeffy Chen
2017-07-18 4:30 ` [RFC PATCH 3/5] serial: xuartps: " Jeffy Chen
2017-07-18 4:30 ` Jeffy Chen
2017-07-18 4:30 ` [RFC PATCH 4/5] serial: 8250_ingenic: " Jeffy Chen
2017-07-18 4:30 ` [RFC PATCH 5/5] serial: 8250_early: " Jeffy Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=596DA54D.8060001@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.