From: "Zhang, Jerry (Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
To: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: fix the incorrect scratch reg number on gfx v9
Date: Thu, 20 Jul 2017 10:46:32 +0800 [thread overview]
Message-ID: <59701988.2020808@amd.com> (raw)
In-Reply-To: <1500517276-13243-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
On 07/20/2017 10:21 AM, Huang Rui wrote:
> There are 8 scratch registers on gfx v9 (scrach_reg0 -> scratch_reg7).
Yeah, nice catch.
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>
Additionally it looks incorrect from gfx v6 till gfx9.
Could you fix them all?
Jerry
>
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index 48b43ea..4d7f042 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -211,7 +211,7 @@ static void gfx_v9_0_init_golden_registers(struct amdgpu_device *adev)
>
> static void gfx_v9_0_scratch_init(struct amdgpu_device *adev)
> {
> - adev->gfx.scratch.num_reg = 7;
> + adev->gfx.scratch.num_reg = 8;
> adev->gfx.scratch.reg_base = SOC15_REG_OFFSET(GC, 0, mmSCRATCH_REG0);
> adev->gfx.scratch.free_mask = (1u << adev->gfx.scratch.num_reg) - 1;
> }
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-07-20 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 2:21 [PATCH] drm/amdgpu: fix the incorrect scratch reg number on gfx v9 Huang Rui
[not found] ` <1500517276-13243-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
2017-07-20 2:46 ` Zhang, Jerry (Junwei) [this message]
2017-07-20 3:01 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59701988.2020808@amd.com \
--to=jerry.zhang-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=ray.huang-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.