* [PATCH] drm/amdgpu: fix the incorrect scratch reg number on gfx v9
@ 2017-07-20 2:21 Huang Rui
[not found] ` <1500517276-13243-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Huang Rui @ 2017-07-20 2:21 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Huang Rui
There are 8 scratch registers on gfx v9 (scrach_reg0 -> scratch_reg7).
Signed-off-by: Huang Rui <ray.huang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 48b43ea..4d7f042 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -211,7 +211,7 @@ static void gfx_v9_0_init_golden_registers(struct amdgpu_device *adev)
static void gfx_v9_0_scratch_init(struct amdgpu_device *adev)
{
- adev->gfx.scratch.num_reg = 7;
+ adev->gfx.scratch.num_reg = 8;
adev->gfx.scratch.reg_base = SOC15_REG_OFFSET(GC, 0, mmSCRATCH_REG0);
adev->gfx.scratch.free_mask = (1u << adev->gfx.scratch.num_reg) - 1;
}
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: fix the incorrect scratch reg number on gfx v9
[not found] ` <1500517276-13243-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
@ 2017-07-20 2:46 ` Zhang, Jerry (Junwei)
2017-07-20 3:01 ` Deucher, Alexander
1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Jerry (Junwei) @ 2017-07-20 2:46 UTC (permalink / raw)
To: Huang Rui, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 07/20/2017 10:21 AM, Huang Rui wrote:
> There are 8 scratch registers on gfx v9 (scrach_reg0 -> scratch_reg7).
Yeah, nice catch.
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>
Additionally it looks incorrect from gfx v6 till gfx9.
Could you fix them all?
Jerry
>
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index 48b43ea..4d7f042 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -211,7 +211,7 @@ static void gfx_v9_0_init_golden_registers(struct amdgpu_device *adev)
>
> static void gfx_v9_0_scratch_init(struct amdgpu_device *adev)
> {
> - adev->gfx.scratch.num_reg = 7;
> + adev->gfx.scratch.num_reg = 8;
> adev->gfx.scratch.reg_base = SOC15_REG_OFFSET(GC, 0, mmSCRATCH_REG0);
> adev->gfx.scratch.free_mask = (1u << adev->gfx.scratch.num_reg) - 1;
> }
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amdgpu: fix the incorrect scratch reg number on gfx v9
[not found] ` <1500517276-13243-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
2017-07-20 2:46 ` Zhang, Jerry (Junwei)
@ 2017-07-20 3:01 ` Deucher, Alexander
1 sibling, 0 replies; 3+ messages in thread
From: Deucher, Alexander @ 2017-07-20 3:01 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org; +Cc: Huang, Ray
> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Huang Rui
> Sent: Wednesday, July 19, 2017 10:21 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Huang, Ray
> Subject: [PATCH] drm/amdgpu: fix the incorrect scratch reg number on gfx v9
>
> There are 8 scratch registers on gfx v9 (scrach_reg0 -> scratch_reg7).
>
> Signed-off-by: Huang Rui <ray.huang@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index 48b43ea..4d7f042 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -211,7 +211,7 @@ static void gfx_v9_0_init_golden_registers(struct
> amdgpu_device *adev)
>
> static void gfx_v9_0_scratch_init(struct amdgpu_device *adev)
> {
> - adev->gfx.scratch.num_reg = 7;
> + adev->gfx.scratch.num_reg = 8;
> adev->gfx.scratch.reg_base = SOC15_REG_OFFSET(GC, 0,
> mmSCRATCH_REG0);
> adev->gfx.scratch.free_mask = (1u << adev->gfx.scratch.num_reg) -
> 1;
> }
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-20 3:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-20 2:21 [PATCH] drm/amdgpu: fix the incorrect scratch reg number on gfx v9 Huang Rui
[not found] ` <1500517276-13243-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
2017-07-20 2:46 ` Zhang, Jerry (Junwei)
2017-07-20 3:01 ` Deucher, Alexander
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.