From: Zhou Wang <wangzhou1@hisilicon.com>
To: Shawn Lin <shawn.lin@rock-chips.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>,
Gabriele Paoloni <gabriele.paoloni@huawei.com>
Subject: Re: [PATCH] PCI: hisi: remove unused variable driver
Date: Fri, 21 Jul 2017 15:12:01 +0800 [thread overview]
Message-ID: <5971A941.2000804@hisilicon.com> (raw)
In-Reply-To: <1500600366-181656-1-git-send-email-shawn.lin@rock-chips.com>
On 2017/7/21 9:26, Shawn Lin wrote:
> It was never used and also introduce a warning
>
> drivers/pci/dwc/pcie-hisi.c: In function 'hisi_pcie_probe':
> drivers/pci/dwc/pcie-hisi.c:271:24: warning: variable 'driver' set but
> not used [-Wunused-but-set-variable]
>
> Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com>
> Cc: Zhou Wang <wangzhou1@hisilicon.com>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Acked-by: Zhou Wang <wangzhou1@hisilicon.com>
Thanks,
Zhou
> ---
>
> drivers/pci/dwc/pcie-hisi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c
> index e51acee..6631654 100644
> --- a/drivers/pci/dwc/pcie-hisi.c
> +++ b/drivers/pci/dwc/pcie-hisi.c
> @@ -268,7 +268,6 @@ static int hisi_pcie_probe(struct platform_device *pdev)
> struct dw_pcie *pci;
> struct hisi_pcie *hisi_pcie;
> struct resource *reg;
> - struct device_driver *driver;
> int ret;
>
> hisi_pcie = devm_kzalloc(dev, sizeof(*hisi_pcie), GFP_KERNEL);
> @@ -282,8 +281,6 @@ static int hisi_pcie_probe(struct platform_device *pdev)
> pci->dev = dev;
> pci->ops = &dw_pcie_ops;
>
> - driver = dev->driver;
> -
> hisi_pcie->pci = pci;
>
> hisi_pcie->soc_ops = of_device_get_match_data(dev);
>
next prev parent reply other threads:[~2017-07-21 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 1:26 [PATCH] PCI: hisi: remove unused variable driver Shawn Lin
2017-07-21 7:12 ` Zhou Wang [this message]
2017-07-21 8:54 ` Gabriele Paoloni
2017-08-03 21:59 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5971A941.2000804@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=bhelgaas@google.com \
--cc=gabriele.paoloni@huawei.com \
--cc=linux-pci@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.