* [PATCH] PCI: hisi: remove unused variable driver
@ 2017-07-21 1:26 Shawn Lin
2017-07-21 7:12 ` Zhou Wang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Shawn Lin @ 2017-07-21 1:26 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, Shawn Lin, Gabriele Paoloni, Zhou Wang
It was never used and also introduce a warning
drivers/pci/dwc/pcie-hisi.c: In function 'hisi_pcie_probe':
drivers/pci/dwc/pcie-hisi.c:271:24: warning: variable 'driver' set but
not used [-Wunused-but-set-variable]
Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com>
Cc: Zhou Wang <wangzhou1@hisilicon.com>
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/pci/dwc/pcie-hisi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c
index e51acee..6631654 100644
--- a/drivers/pci/dwc/pcie-hisi.c
+++ b/drivers/pci/dwc/pcie-hisi.c
@@ -268,7 +268,6 @@ static int hisi_pcie_probe(struct platform_device *pdev)
struct dw_pcie *pci;
struct hisi_pcie *hisi_pcie;
struct resource *reg;
- struct device_driver *driver;
int ret;
hisi_pcie = devm_kzalloc(dev, sizeof(*hisi_pcie), GFP_KERNEL);
@@ -282,8 +281,6 @@ static int hisi_pcie_probe(struct platform_device *pdev)
pci->dev = dev;
pci->ops = &dw_pcie_ops;
- driver = dev->driver;
-
hisi_pcie->pci = pci;
hisi_pcie->soc_ops = of_device_get_match_data(dev);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: hisi: remove unused variable driver
2017-07-21 1:26 [PATCH] PCI: hisi: remove unused variable driver Shawn Lin
@ 2017-07-21 7:12 ` Zhou Wang
2017-07-21 8:54 ` Gabriele Paoloni
2017-08-03 21:59 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Zhou Wang @ 2017-07-21 7:12 UTC (permalink / raw)
To: Shawn Lin, Bjorn Helgaas; +Cc: linux-pci, Gabriele Paoloni
On 2017/7/21 9:26, Shawn Lin wrote:
> It was never used and also introduce a warning
>
> drivers/pci/dwc/pcie-hisi.c: In function 'hisi_pcie_probe':
> drivers/pci/dwc/pcie-hisi.c:271:24: warning: variable 'driver' set but
> not used [-Wunused-but-set-variable]
>
> Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com>
> Cc: Zhou Wang <wangzhou1@hisilicon.com>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Acked-by: Zhou Wang <wangzhou1@hisilicon.com>
Thanks,
Zhou
> ---
>
> drivers/pci/dwc/pcie-hisi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c
> index e51acee..6631654 100644
> --- a/drivers/pci/dwc/pcie-hisi.c
> +++ b/drivers/pci/dwc/pcie-hisi.c
> @@ -268,7 +268,6 @@ static int hisi_pcie_probe(struct platform_device *pdev)
> struct dw_pcie *pci;
> struct hisi_pcie *hisi_pcie;
> struct resource *reg;
> - struct device_driver *driver;
> int ret;
>
> hisi_pcie = devm_kzalloc(dev, sizeof(*hisi_pcie), GFP_KERNEL);
> @@ -282,8 +281,6 @@ static int hisi_pcie_probe(struct platform_device *pdev)
> pci->dev = dev;
> pci->ops = &dw_pcie_ops;
>
> - driver = dev->driver;
> -
> hisi_pcie->pci = pci;
>
> hisi_pcie->soc_ops = of_device_get_match_data(dev);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] PCI: hisi: remove unused variable driver
2017-07-21 1:26 [PATCH] PCI: hisi: remove unused variable driver Shawn Lin
2017-07-21 7:12 ` Zhou Wang
@ 2017-07-21 8:54 ` Gabriele Paoloni
2017-08-03 21:59 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Gabriele Paoloni @ 2017-07-21 8:54 UTC (permalink / raw)
To: Shawn Lin, Bjorn Helgaas; +Cc: linux-pci@vger.kernel.org, Wangzhou (B)
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogU2hhd24gTGluIFttYWls
dG86c2hhd24ubGluQHJvY2stY2hpcHMuY29tXQ0KPiBTZW50OiAyMSBKdWx5IDIwMTcgMDk6MjYN
Cj4gVG86IEJqb3JuIEhlbGdhYXMNCj4gQ2M6IGxpbnV4LXBjaUB2Z2VyLmtlcm5lbC5vcmc7IFNo
YXduIExpbjsgR2FicmllbGUgUGFvbG9uaTsgV2FuZ3pob3UgKEIpDQo+IFN1YmplY3Q6IFtQQVRD
SF0gUENJOiBoaXNpOiByZW1vdmUgdW51c2VkIHZhcmlhYmxlIGRyaXZlcg0KPiANCj4gSXQgd2Fz
IG5ldmVyIHVzZWQgYW5kIGFsc28gaW50cm9kdWNlIGEgd2FybmluZw0KPiANCj4gZHJpdmVycy9w
Y2kvZHdjL3BjaWUtaGlzaS5jOiBJbiBmdW5jdGlvbiAnaGlzaV9wY2llX3Byb2JlJzoNCj4gZHJp
dmVycy9wY2kvZHdjL3BjaWUtaGlzaS5jOjI3MToyNDogd2FybmluZzogdmFyaWFibGUgJ2RyaXZl
cicgc2V0IGJ1dA0KPiBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0NCj4gDQo+
IENjOiBHYWJyaWVsZSBQYW9sb25pIDxnYWJyaWVsZS5wYW9sb25pQGh1YXdlaS5jb20+DQo+IENj
OiBaaG91IFdhbmcgPHdhbmd6aG91MUBoaXNpbGljb24uY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBT
aGF3biBMaW4gPHNoYXduLmxpbkByb2NrLWNoaXBzLmNvbT4NCg0KQWNrZWQtYnk6IEdhYnJpZWxl
IFBhb2xvbmkgPGdhYnJpZWxlLnBhb2xvbmlAaHVhd2VpLmNvbT4NCg0KVGhhbmtzDQpHYWINCg0K
Wy4uLl0NCg==
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: hisi: remove unused variable driver
2017-07-21 1:26 [PATCH] PCI: hisi: remove unused variable driver Shawn Lin
2017-07-21 7:12 ` Zhou Wang
2017-07-21 8:54 ` Gabriele Paoloni
@ 2017-08-03 21:59 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2017-08-03 21:59 UTC (permalink / raw)
To: Shawn Lin; +Cc: Bjorn Helgaas, linux-pci, Gabriele Paoloni, Zhou Wang
On Fri, Jul 21, 2017 at 09:26:06AM +0800, Shawn Lin wrote:
> It was never used and also introduce a warning
>
> drivers/pci/dwc/pcie-hisi.c: In function 'hisi_pcie_probe':
> drivers/pci/dwc/pcie-hisi.c:271:24: warning: variable 'driver' set but
> not used [-Wunused-but-set-variable]
>
> Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com>
> Cc: Zhou Wang <wangzhou1@hisilicon.com>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Applied to pci/host-hisi for v4.14 with acks from Zhou and Gabriele, thanks!
> ---
>
> drivers/pci/dwc/pcie-hisi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c
> index e51acee..6631654 100644
> --- a/drivers/pci/dwc/pcie-hisi.c
> +++ b/drivers/pci/dwc/pcie-hisi.c
> @@ -268,7 +268,6 @@ static int hisi_pcie_probe(struct platform_device *pdev)
> struct dw_pcie *pci;
> struct hisi_pcie *hisi_pcie;
> struct resource *reg;
> - struct device_driver *driver;
> int ret;
>
> hisi_pcie = devm_kzalloc(dev, sizeof(*hisi_pcie), GFP_KERNEL);
> @@ -282,8 +281,6 @@ static int hisi_pcie_probe(struct platform_device *pdev)
> pci->dev = dev;
> pci->ops = &dw_pcie_ops;
>
> - driver = dev->driver;
> -
> hisi_pcie->pci = pci;
>
> hisi_pcie->soc_ops = of_device_get_match_data(dev);
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-03 21:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-21 1:26 [PATCH] PCI: hisi: remove unused variable driver Shawn Lin
2017-07-21 7:12 ` Zhou Wang
2017-07-21 8:54 ` Gabriele Paoloni
2017-08-03 21:59 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.