From: John Fastabend <john.fastabend@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] bpf: dev_map_alloc() shouldn't return NULL
Date: Sat, 22 Jul 2017 19:07:09 +0000 [thread overview]
Message-ID: <5973A25D.8030903@gmail.com> (raw)
In-Reply-To: <20170722074004.3abeucov67n3sbqs@mwanda>
On 07/22/2017 12:40 AM, Dan Carpenter wrote:
> We forgot to set the error code on two error paths which means that we
> return ERR_PTR(0) which is NULL. The caller, find_and_alloc_map(), is
> not expecting that and will have a NULL dereference.
>
> Fixes: 546ac1ffb70d ("bpf: add devmap, a map for storing net device references")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
> index 899364d097f5..d439ee0eadb1 100644
> --- a/kernel/bpf/devmap.c
> +++ b/kernel/bpf/devmap.c
> @@ -114,6 +114,7 @@ static struct bpf_map *dev_map_alloc(union bpf_attr *attr)
> if (err)
> goto free_dtab;
>
> + err = -ENOMEM;
> /* A per cpu bitfield with a bit per possible net device */
> dtab->flush_needed = __alloc_percpu(
> BITS_TO_LONGS(attr->max_entries) *
>
Thanks.
Acked-by: John Fastabend <john.fastabend@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: John Fastabend <john.fastabend@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] bpf: dev_map_alloc() shouldn't return NULL
Date: Sat, 22 Jul 2017 12:07:09 -0700 [thread overview]
Message-ID: <5973A25D.8030903@gmail.com> (raw)
In-Reply-To: <20170722074004.3abeucov67n3sbqs@mwanda>
On 07/22/2017 12:40 AM, Dan Carpenter wrote:
> We forgot to set the error code on two error paths which means that we
> return ERR_PTR(0) which is NULL. The caller, find_and_alloc_map(), is
> not expecting that and will have a NULL dereference.
>
> Fixes: 546ac1ffb70d ("bpf: add devmap, a map for storing net device references")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
> index 899364d097f5..d439ee0eadb1 100644
> --- a/kernel/bpf/devmap.c
> +++ b/kernel/bpf/devmap.c
> @@ -114,6 +114,7 @@ static struct bpf_map *dev_map_alloc(union bpf_attr *attr)
> if (err)
> goto free_dtab;
>
> + err = -ENOMEM;
> /* A per cpu bitfield with a bit per possible net device */
> dtab->flush_needed = __alloc_percpu(
> BITS_TO_LONGS(attr->max_entries) *
>
Thanks.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2017-07-22 19:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-22 7:40 [PATCH net-next] bpf: dev_map_alloc() shouldn't return NULL Dan Carpenter
2017-07-22 7:40 ` Dan Carpenter
2017-07-22 10:09 ` Daniel Borkmann
2017-07-22 10:09 ` Daniel Borkmann
2017-07-22 19:07 ` John Fastabend [this message]
2017-07-22 19:07 ` John Fastabend
2017-07-24 23:23 ` David Miller
2017-07-24 23:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5973A25D.8030903@gmail.com \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel@iogearbox.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.