All of lore.kernel.org
 help / color / mirror / Atom feed
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 1/3] dt-bindings: clock: meson8b: describe the embedded reset controller
Date: Tue, 25 Jul 2017 09:55:15 +0200	[thread overview]
Message-ID: <5976F963.5050200@baylibre.com> (raw)
In-Reply-To: <20170722185807.10504-2-martin.blumenstingl@googlemail.com>



Le 22/07/2017 20:58, Martin Blumenstingl a ?crit :
> The Amlogic Meson8/Meson8b/Meson8m2 clock controller provides some reset
> lines. These are used for example to boot the secondary CPU cores.
> 
> This patch describes the reset controller which is embedded into the
> clock controller on these SoCs.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
>  Documentation/devicetree/bindings/clock/amlogic,meson8b-clkc.txt | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/amlogic,meson8b-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,meson8b-clkc.txt
> index 606da38c0959..e1af4764114d 100644
> --- a/Documentation/devicetree/bindings/clock/amlogic,meson8b-clkc.txt
> +++ b/Documentation/devicetree/bindings/clock/amlogic,meson8b-clkc.txt
> @@ -16,18 +16,24 @@ Required Properties:
>  	   mapped region.
>  
>  - #clock-cells: should be 1.
> +- #reset-cells: should be 1.
>  
>  Each clock is assigned an identifier and client nodes can use this identifier
>  to specify the clock which they consume. All available clocks are defined as
>  preprocessor macros in the dt-bindings/clock/meson8b-clkc.h header and can be
>  used in device tree sources.
> +This is also valid for the reset lines provided by the clock controller: a
> +preprocessor macro for each reset line is defined (in the same header file as
> +the clock identifiers).
> +
>  
>  Example: Clock controller node:
>  
>  	clkc: clock-controller at c1104000 {
> -		#clock-cells = <1>;
>  		compatible = "amlogic,meson8b-clkc";
>  		reg = <0xc1108000 0x4>, <0xc1104000 0x460>;
> +		#clock-cells = <1>;
> +		#reset-cells = <1>;
>  	};
>  
>  
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-amlogic@lists.infradead.org, khilman@baylibre.com,
	carlo@caione.org, jbrunet@baylibre.com,
	linux-clk@vger.kernel.org, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux@armlinux.org.uk,
	mark.rutland@arm.com, mturquette@baylibre.com,
	sboyd@codeaurora.org
Subject: Re: [PATCH v2 1/3] dt-bindings: clock: meson8b: describe the embedded reset controller
Date: Tue, 25 Jul 2017 09:55:15 +0200	[thread overview]
Message-ID: <5976F963.5050200@baylibre.com> (raw)
In-Reply-To: <20170722185807.10504-2-martin.blumenstingl@googlemail.com>



Le 22/07/2017 20:58, Martin Blumenstingl a écrit :
> The Amlogic Meson8/Meson8b/Meson8m2 clock controller provides some reset
> lines. These are used for example to boot the secondary CPU cores.
> 
> This patch describes the reset controller which is embedded into the
> clock controller on these SoCs.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
>  Documentation/devicetree/bindings/clock/amlogic,meson8b-clkc.txt | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/amlogic,meson8b-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,meson8b-clkc.txt
> index 606da38c0959..e1af4764114d 100644
> --- a/Documentation/devicetree/bindings/clock/amlogic,meson8b-clkc.txt
> +++ b/Documentation/devicetree/bindings/clock/amlogic,meson8b-clkc.txt
> @@ -16,18 +16,24 @@ Required Properties:
>  	   mapped region.
>  
>  - #clock-cells: should be 1.
> +- #reset-cells: should be 1.
>  
>  Each clock is assigned an identifier and client nodes can use this identifier
>  to specify the clock which they consume. All available clocks are defined as
>  preprocessor macros in the dt-bindings/clock/meson8b-clkc.h header and can be
>  used in device tree sources.
> +This is also valid for the reset lines provided by the clock controller: a
> +preprocessor macro for each reset line is defined (in the same header file as
> +the clock identifiers).
> +
>  
>  Example: Clock controller node:
>  
>  	clkc: clock-controller@c1104000 {
> -		#clock-cells = <1>;
>  		compatible = "amlogic,meson8b-clkc";
>  		reg = <0xc1108000 0x4>, <0xc1104000 0x460>;
> +		#clock-cells = <1>;
> +		#reset-cells = <1>;
>  	};
>  
>  
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

  reply	other threads:[~2017-07-25  7:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-22 18:58 [PATCH v2 0/3] add the reset controller to the Meson8b clkc Martin Blumenstingl
2017-07-22 18:58 ` Martin Blumenstingl
2017-07-22 18:58 ` [PATCH v2 1/3] dt-bindings: clock: meson8b: describe the embedded reset controller Martin Blumenstingl
2017-07-22 18:58   ` Martin Blumenstingl
2017-07-25  7:55   ` Neil Armstrong [this message]
2017-07-25  7:55     ` Neil Armstrong
2017-07-22 18:58 ` [PATCH v2 2/3] clk: meson: meson8b: register the built-in " Martin Blumenstingl
2017-07-22 18:58   ` Martin Blumenstingl
2017-07-22 18:58   ` Martin Blumenstingl
2017-07-25  7:58   ` Neil Armstrong
2017-07-25  7:58     ` Neil Armstrong
2017-07-25  7:58     ` Neil Armstrong
2017-07-25 19:17     ` Martin Blumenstingl
2017-07-25 19:17       ` Martin Blumenstingl
2017-07-25 19:17       ` Martin Blumenstingl
2017-07-22 18:58 ` [PATCH v2 3/3] ARM: dts: meson: mark the clock controller also as " Martin Blumenstingl
2017-07-22 18:58   ` Martin Blumenstingl
2017-07-25  7:58   ` Neil Armstrong
2017-07-25  7:58     ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5976F963.5050200@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.