Re: [PATCH] drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228

[Nicolas Frattaroli <nicolas.frattaroli@collabora.com>]

On Friday, 10 October 2025 19:31:41 Central European Summer Time Alok Tiwari wrote:
> In dw_hdmi_rk3228_setup_hpd(), the SCLIN mask incorrectly references
> the RK3328 variant. This change updates it to the RK3228-specific mask
> RK3228_HDMI_SCLIN_MSK using FIELD_PREP_WM16, ensuring proper HPD and
> I2C pin configuration for RK3228.
> 
> Change: RK3328_HDMI_SCLIN_MSK -> RK3228_HDMI_SCLIN_MSK
> 
> Fixes: 63df37f3fc71 ("drm/rockchip: dw_hdmi: switch to FIELD_PREP_WM16* macros")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
>  drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> index 7b613997bb50..727cdf768161 100644
> --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> @@ -361,7 +361,7 @@ static void dw_hdmi_rk3228_setup_hpd(struct dw_hdmi *dw_hdmi, void *data)
>  
>  	regmap_write(hdmi->regmap, RK3228_GRF_SOC_CON2,
>  		     FIELD_PREP_WM16(RK3228_HDMI_SDAIN_MSK, 1) |
> -		     FIELD_PREP_WM16(RK3328_HDMI_SCLIN_MSK, 1));
> +		     FIELD_PREP_WM16(RK3228_HDMI_SCLIN_MSK, 1));
>  }
>  
>  static enum drm_connector_status
> 

Oops, thanks.

Reviewed-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

In the future, please use something like get_maintainers or b4 to
make sure all recipients that should be included are included; in
this case, I'm very much interested in hearing of problems I
created.

Kind regards,
Nicolas Frattaroli