diff for duplicates of <599341878.20081209040844@emcraft.com> diff --git a/a/1.txt b/N1/1.txt index 7d99921..5bf90ea 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,7 @@ +=0D=0A Hello Josh, - - Hello Josh, - - If you are still intending to review our ppc440spe ADMA driver -(thanks in advance if so), then please use the driver from my latest + If you are still intending to review our ppc440spe ADMA driver=20 +(thanks in advance if so), then please use the driver from my latest=20 post as the reference: http://ozlabs.org/pipermail/linuxppc-dev/2008-December/065983.html @@ -17,32 +15,41 @@ On Thursday, November 13, 2008 you wrote: >> Josh Boyer wrote: >> > On Thu, Nov 13, 2008 at 06:16:04PM +0300, Ilya Yanok wrote: ->> > ->> >> Adds the platform device definitions and the architecture specific support +>> > =20 +>> >> Adds the platform device definitions and the architecture specific su= +pport >> >> routines for the ppc440spe adma driver. >> >> ->> >> Any board equipped with PPC440SP(e) controller may utilize this driver. +>> >> Any board equipped with PPC440SP(e) controller may utilize this drive= +r. >> >> >> >> Signed-off-by: Yuri Tikhonov <yur@emcraft.com> >> >> Signed-off-by: Ilya Yanok <yanok@emcraft.com> ->> >> +>> >> =20 >> > ->> > Before I really dig into reviewing this driver, I'm going to ask you as simple ->> > question. This looks like a 1/2 completed port of an arch/ppc driver that uses ->> > the device tree (incorrectly) to get the interrupt resources and that's about it. ->> > Otherwise, it's just a straight up platform device driver. Is that correct? ->> > ->> +>> > Before I really dig into reviewing this driver, I'm going to ask you a= +s simple +>> > question. This looks like a 1/2 completed port of an arch/ppc driver = +that uses +>> > the device tree (incorrectly) to get the interrupt resources and that'= +s about it. +>> > Otherwise, it's just a straight up platform device driver. Is that co= +rrect? +>> > =20 +>>=20 >> Yep, that's correct. > OK. ->> > If that is the case, I think the driver needs more work before it can be merged. ->> > It should get the DCR and MMIO resources from the device tree as well. It should ->> > be binding on compatible properties and not based on device tree paths. And it +>> > If that is the case, I think the driver needs more work before it can = +be merged. +>> > It should get the DCR and MMIO resources from the device tree as well.= + It should +>> > be binding on compatible properties and not based on device tree paths= +. And it >> > should probably be an of_platform device driver. ->> > ->> +>> > =20 +>>=20 >> Surely, you're right. I agree with you in that this driver isn't ready >> for merging. But it works so we'd like to publish it so interested >> people could use it and test it. diff --git a/a/content_digest b/N1/content_digest index 54ff784..dcca08c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -7,19 +7,17 @@ "Subject\0Re[2]: [PATCH 11/11] ppc440spe-adma: ADMA driver for PPC440SP(e) systems\0" "Date\0Tue, 9 Dec 2008 04:08:44 +0300\0" "To\0Josh Boyer <jwboyer@linux.vnet.ibm.com>\0" - "Cc\0Ilya Yanok <yanok@emcraft.com>" - linux-raid@vger.kernel.org + "Cc\0linux-raid@vger.kernel.org" linuxppc-dev@ozlabs.org dzu@denx.de + Ilya Yanok <yanok@emcraft.com> " wd@denx.de\0" "\00:1\0" "b\0" + "=0D=0A Hello Josh,\n" "\n" - "\n" - " Hello Josh,\n" - "\n" - " If you are still intending to review our ppc440spe ADMA driver \n" - "(thanks in advance if so), then please use the driver from my latest \n" + " If you are still intending to review our ppc440spe ADMA driver=20\n" + "(thanks in advance if so), then please use the driver from my latest=20\n" "post as the reference:\n" "\n" " http://ozlabs.org/pipermail/linuxppc-dev/2008-December/065983.html\n" @@ -33,32 +31,41 @@ "\n" ">> Josh Boyer wrote:\n" ">> > On Thu, Nov 13, 2008 at 06:16:04PM +0300, Ilya Yanok wrote:\n" - ">> > \n" - ">> >> Adds the platform device definitions and the architecture specific support\n" + ">> > =20\n" + ">> >> Adds the platform device definitions and the architecture specific su=\n" + "pport\n" ">> >> routines for the ppc440spe adma driver.\n" ">> >>\n" - ">> >> Any board equipped with PPC440SP(e) controller may utilize this driver.\n" + ">> >> Any board equipped with PPC440SP(e) controller may utilize this drive=\n" + "r.\n" ">> >>\n" ">> >> Signed-off-by: Yuri Tikhonov <yur@emcraft.com>\n" ">> >> Signed-off-by: Ilya Yanok <yanok@emcraft.com>\n" - ">> >> \n" + ">> >> =20\n" ">> >\n" - ">> > Before I really dig into reviewing this driver, I'm going to ask you as simple\n" - ">> > question. This looks like a 1/2 completed port of an arch/ppc driver that uses\n" - ">> > the device tree (incorrectly) to get the interrupt resources and that's about it.\n" - ">> > Otherwise, it's just a straight up platform device driver. Is that correct?\n" - ">> > \n" - ">> \n" + ">> > Before I really dig into reviewing this driver, I'm going to ask you a=\n" + "s simple\n" + ">> > question. This looks like a 1/2 completed port of an arch/ppc driver =\n" + "that uses\n" + ">> > the device tree (incorrectly) to get the interrupt resources and that'=\n" + "s about it.\n" + ">> > Otherwise, it's just a straight up platform device driver. Is that co=\n" + "rrect?\n" + ">> > =20\n" + ">>=20\n" ">> Yep, that's correct.\n" "\n" "> OK.\n" "\n" - ">> > If that is the case, I think the driver needs more work before it can be merged.\n" - ">> > It should get the DCR and MMIO resources from the device tree as well. It should\n" - ">> > be binding on compatible properties and not based on device tree paths. And it\n" + ">> > If that is the case, I think the driver needs more work before it can =\n" + "be merged.\n" + ">> > It should get the DCR and MMIO resources from the device tree as well.=\n" + " It should\n" + ">> > be binding on compatible properties and not based on device tree paths=\n" + ". And it\n" ">> > should probably be an of_platform device driver.\n" - ">> > \n" - ">> \n" + ">> > =20\n" + ">>=20\n" ">> Surely, you're right. I agree with you in that this driver isn't ready\n" ">> for merging. But it works so we'd like to publish it so interested\n" ">> people could use it and test it.\n" @@ -81,4 +88,4 @@ " Yuri Tikhonov, Senior Software Engineer\n" Emcraft Systems, www.emcraft.com -88a0bb1b4e7de866bee8f1ffeb18ebe51120f6d6385355b85723145c1adf93ed +672c5a342d44a25a571ac4380d3bedae3dc250a4c8b5dd3fcee93d44fe1cd9e9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.