From: Yuri Tikhonov <yur@emcraft.com>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: Ilya Yanok <yanok@emcraft.com>,
linux-raid@vger.kernel.org, linuxppc-dev@ozlabs.org, dzu@denx.de,
wd@denx.de
Subject: Re[2]: [PATCH 11/11] ppc440spe-adma: ADMA driver for PPC440SP(e) systems
Date: Tue, 9 Dec 2008 04:08:44 +0300 [thread overview]
Message-ID: <599341878.20081209040844@emcraft.com> (raw)
In-Reply-To: <20081113125451.4a7bd7d9@zod.rchland.ibm.com>
Hello Josh,
If you are still intending to review our ppc440spe ADMA driver
(thanks in advance if so), then please use the driver from my latest
post as the reference:
http://ozlabs.org/pipermail/linuxppc-dev/2008-December/065983.html
since this has some updates relating to the November version.
On Thursday, November 13, 2008 you wrote:
> On Thu, 13 Nov 2008 20:50:43 +0300
> Ilya Yanok <yanok@emcraft.com> wrote:
>> Josh Boyer wrote:
>> > On Thu, Nov 13, 2008 at 06:16:04PM +0300, Ilya Yanok wrote:
>> >
>> >> Adds the platform device definitions and the architecture specific support
>> >> routines for the ppc440spe adma driver.
>> >>
>> >> Any board equipped with PPC440SP(e) controller may utilize this driver.
>> >>
>> >> Signed-off-by: Yuri Tikhonov <yur@emcraft.com>
>> >> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
>> >>
>> >
>> > Before I really dig into reviewing this driver, I'm going to ask you as simple
>> > question. This looks like a 1/2 completed port of an arch/ppc driver that uses
>> > the device tree (incorrectly) to get the interrupt resources and that's about it.
>> > Otherwise, it's just a straight up platform device driver. Is that correct?
>> >
>>
>> Yep, that's correct.
> OK.
>> > If that is the case, I think the driver needs more work before it can be merged.
>> > It should get the DCR and MMIO resources from the device tree as well. It should
>> > be binding on compatible properties and not based on device tree paths. And it
>> > should probably be an of_platform device driver.
>> >
>>
>> Surely, you're right. I agree with you in that this driver isn't ready
>> for merging. But it works so we'd like to publish it so interested
>> people could use it and test it.
> And that's fine. I just wanted to see where you were headed with this
> one for now. I'll try to do a review in the next few days. Thanks for
> posting.
> josh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Regards, Yuri
--
Yuri Tikhonov, Senior Software Engineer
Emcraft Systems, www.emcraft.com
WARNING: multiple messages have this Message-ID (diff)
From: Yuri Tikhonov <yur@emcraft.com>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linux-raid@vger.kernel.org, linuxppc-dev@ozlabs.org, dzu@denx.de,
Ilya Yanok <yanok@emcraft.com>,
wd@denx.de
Subject: Re[2]: [PATCH 11/11] ppc440spe-adma: ADMA driver for PPC440SP(e) systems
Date: Tue, 9 Dec 2008 04:08:44 +0300 [thread overview]
Message-ID: <599341878.20081209040844@emcraft.com> (raw)
In-Reply-To: <20081113125451.4a7bd7d9@zod.rchland.ibm.com>
=0D=0A Hello Josh,
If you are still intending to review our ppc440spe ADMA driver=20
(thanks in advance if so), then please use the driver from my latest=20
post as the reference:
http://ozlabs.org/pipermail/linuxppc-dev/2008-December/065983.html
since this has some updates relating to the November version.
On Thursday, November 13, 2008 you wrote:
> On Thu, 13 Nov 2008 20:50:43 +0300
> Ilya Yanok <yanok@emcraft.com> wrote:
>> Josh Boyer wrote:
>> > On Thu, Nov 13, 2008 at 06:16:04PM +0300, Ilya Yanok wrote:
>> > =20
>> >> Adds the platform device definitions and the architecture specific su=
pport
>> >> routines for the ppc440spe adma driver.
>> >>
>> >> Any board equipped with PPC440SP(e) controller may utilize this drive=
r.
>> >>
>> >> Signed-off-by: Yuri Tikhonov <yur@emcraft.com>
>> >> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
>> >> =20
>> >
>> > Before I really dig into reviewing this driver, I'm going to ask you a=
s simple
>> > question. This looks like a 1/2 completed port of an arch/ppc driver =
that uses
>> > the device tree (incorrectly) to get the interrupt resources and that'=
s about it.
>> > Otherwise, it's just a straight up platform device driver. Is that co=
rrect?
>> > =20
>>=20
>> Yep, that's correct.
> OK.
>> > If that is the case, I think the driver needs more work before it can =
be merged.
>> > It should get the DCR and MMIO resources from the device tree as well.=
It should
>> > be binding on compatible properties and not based on device tree paths=
. And it
>> > should probably be an of_platform device driver.
>> > =20
>>=20
>> Surely, you're right. I agree with you in that this driver isn't ready
>> for merging. But it works so we'd like to publish it so interested
>> people could use it and test it.
> And that's fine. I just wanted to see where you were headed with this
> one for now. I'll try to do a review in the next few days. Thanks for
> posting.
> josh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Regards, Yuri
--
Yuri Tikhonov, Senior Software Engineer
Emcraft Systems, www.emcraft.com
next prev parent reply other threads:[~2008-12-09 1:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 15:15 [RFC PATCH 00/11] md: support for asynchronous execution of RAID6 operations Ilya Yanok
2008-11-13 15:15 ` [PATCH 01/11] async_tx: don't use src_list argument of async_xor() for dma addresses Ilya Yanok
2008-11-15 0:42 ` Dan Williams
2008-11-15 0:42 ` Dan Williams
2008-11-15 7:12 ` Benjamin Herrenschmidt
2008-11-15 7:12 ` Benjamin Herrenschmidt
2008-11-13 15:15 ` [PATCH 02/11] async_tx: add support for asynchronous GF multiplication Ilya Yanok
2008-11-15 1:28 ` Dan Williams
2008-11-15 1:28 ` Dan Williams
2008-11-27 1:26 ` Re[2]: " Yuri Tikhonov
2008-11-27 1:26 ` Yuri Tikhonov
2008-11-28 21:18 ` Dan Williams
2008-11-28 21:18 ` Dan Williams
2008-11-13 15:15 ` [PATCH 03/11] async_tx: add support for asynchronous RAID6 recovery operations Ilya Yanok
2008-11-13 15:15 ` [PATCH 04/11] md: run stripe operations outside the lock Ilya Yanok
2008-11-13 15:15 ` [PATCH 05/11] md: common schedule_reconstruction for raid5/6 Ilya Yanok
2008-11-13 15:15 ` [PATCH 06/11] md: change handle_stripe_fill6 to work in asynchronous way Ilya Yanok
2008-11-13 15:16 ` [PATCH 07/11] md: rewrite handle_stripe_dirtying6 " Ilya Yanok
2008-11-13 15:16 ` [PATCH 08/11] md: asynchronous handle_parity_check6 Ilya Yanok
2008-11-13 15:16 ` [PATCH 09/11] md: change handle_stripe6 to work asynchronously Ilya Yanok
2008-11-13 15:16 ` [PATCH 10/11] md: remove unused functions Ilya Yanok
2008-11-13 15:16 ` [PATCH 11/11] ppc440spe-adma: ADMA driver for PPC440SP(e) systems Ilya Yanok
2008-11-13 16:03 ` Josh Boyer
2008-11-13 16:03 ` Josh Boyer
2008-11-13 17:50 ` Ilya Yanok
2008-11-13 17:50 ` Ilya Yanok
2008-11-13 17:54 ` Josh Boyer
2008-11-13 17:54 ` Josh Boyer
2008-12-09 1:08 ` Yuri Tikhonov [this message]
2008-12-09 1:08 ` Re[2]: " Yuri Tikhonov
2009-05-06 15:32 ` 440SPE ADMA driver Tirumala Reddy Marri
2009-05-06 15:32 ` Tirumala Reddy Marri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=599341878.20081209040844@emcraft.com \
--to=yur@emcraft.com \
--cc=dzu@denx.de \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linux-raid@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=wd@denx.de \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.