All of lore.kernel.org
 help / color / mirror / Atom feed
From: xuwei5@hisilicon.com (Wei Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: hisi: Fix typo in comment
Date: Wed, 16 Aug 2017 10:18:22 +0100	[thread overview]
Message-ID: <59940DDE.1000906@hisilicon.com> (raw)
In-Reply-To: <20170807093322.26050-1-yunzhi.li@deephi.tech>

Hi Yunzhi,

On 2017/8/7 10:33, Yunzhi Li wrote:
> Fix the rc vs. pc typo. There is no a register named rc, I felt
> confused when I read this assembler command in comment.
>

Thanks!
Yes, it is a typo.
And 0xe51ff004 is the machine code to do the jump.
I will change the commit msg as below and pick up it:

The machine code "0xe51ff004" means "ldr pc, [pc, #-4]".
This patch fixed the comment typo to avoid any confusion.

Best Regards,
Wei

> Signed-off-by: Yunzhi Li <yunzhi.li@deephi.tech>
> ---
> 
>  arch/arm/mach-hisi/platsmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-hisi/platsmp.c b/arch/arm/mach-hisi/platsmp.c
> index 91bb02dec20f..da5689ababf7 100644
> --- a/arch/arm/mach-hisi/platsmp.c
> +++ b/arch/arm/mach-hisi/platsmp.c
> @@ -109,7 +109,7 @@ static void hix5hd2_set_scu_boot_addr(phys_addr_t start_addr, phys_addr_t jump_a
>  
>  	virt = ioremap(start_addr, PAGE_SIZE);
>  
> -	writel_relaxed(0xe51ff004, virt);	/* ldr pc, [rc, #-4] */
> +	writel_relaxed(0xe51ff004, virt);	/* ldr pc, [pc, #-4] */
>  	writel_relaxed(jump_addr, virt + 4);	/* pc jump phy address */
>  	iounmap(virt);
>  }
> 

WARNING: multiple messages have this Message-ID (diff)
From: Wei Xu <xuwei5@hisilicon.com>
To: Yunzhi Li <yunzhi.li@deephi.tech>, <yunzhi.li@deephi.com>
Cc: <linux-kernel@vger.kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	<linux-arm-kernel@lists.infradead.org>,
	Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH] ARM: hisi: Fix typo in comment
Date: Wed, 16 Aug 2017 10:18:22 +0100	[thread overview]
Message-ID: <59940DDE.1000906@hisilicon.com> (raw)
In-Reply-To: <20170807093322.26050-1-yunzhi.li@deephi.tech>

Hi Yunzhi,

On 2017/8/7 10:33, Yunzhi Li wrote:
> Fix the rc vs. pc typo. There is no a register named rc, I felt
> confused when I read this assembler command in comment.
>

Thanks!
Yes, it is a typo.
And 0xe51ff004 is the machine code to do the jump.
I will change the commit msg as below and pick up it:

The machine code "0xe51ff004" means "ldr pc, [pc, #-4]".
This patch fixed the comment typo to avoid any confusion.

Best Regards,
Wei

> Signed-off-by: Yunzhi Li <yunzhi.li@deephi.tech>
> ---
> 
>  arch/arm/mach-hisi/platsmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-hisi/platsmp.c b/arch/arm/mach-hisi/platsmp.c
> index 91bb02dec20f..da5689ababf7 100644
> --- a/arch/arm/mach-hisi/platsmp.c
> +++ b/arch/arm/mach-hisi/platsmp.c
> @@ -109,7 +109,7 @@ static void hix5hd2_set_scu_boot_addr(phys_addr_t start_addr, phys_addr_t jump_a
>  
>  	virt = ioremap(start_addr, PAGE_SIZE);
>  
> -	writel_relaxed(0xe51ff004, virt);	/* ldr pc, [rc, #-4] */
> +	writel_relaxed(0xe51ff004, virt);	/* ldr pc, [pc, #-4] */
>  	writel_relaxed(jump_addr, virt + 4);	/* pc jump phy address */
>  	iounmap(virt);
>  }
> 

  reply	other threads:[~2017-08-16  9:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-07  9:33 [PATCH] ARM: hisi: Fix typo in comment Yunzhi Li
2017-08-07  9:33 ` Yunzhi Li
2017-08-16  9:18 ` Wei Xu [this message]
2017-08-16  9:18   ` Wei Xu
  -- strict thread matches above, loose matches on Subject: below --
2017-08-07  9:37 Yunzhi Li
2017-08-07  9:37 ` Yunzhi Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59940DDE.1000906@hisilicon.com \
    --to=xuwei5@hisilicon.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.