All of lore.kernel.org
 help / color / mirror / Atom feed
From: jeffy <jeffy.chen@rock-chips.com>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: linux-kernel@vger.kernel.org, dgreid@chromium.org,
	heiko@sntech.de, briannorris@chromium.org, dianders@chromium.org,
	Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org,
	Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] ASoC: rockchip: Parse dai links from dts
Date: Thu, 17 Aug 2017 06:55:20 +0800	[thread overview]
Message-ID: <5994CD58.7030406@rock-chips.com> (raw)
In-Reply-To: <20170816215909.GC109008@google.com>

hi matthias,

thanks for your suggestion.

On 08/17/2017 05:59 AM, Matthias Kaehlcke wrote:
> El Thu, Aug 10, 2017 at 12:54:56PM +0800 Jeffy Chen ha dit:
>
>> >Refactor rockchip_sound_probe, parse dai links from dts instead of
>> >hard coding them.
> Mark doesn't seem to be overly convinced that 'rockchip,codec-names'
> is a good idea (https://lkml.org/lkml/2017/8/10/511).
>
> How about using something like this instead:
>
> static const char *dailink_compat[] = {
> 	[DAILINK_MAX98357A] = "maxim,max98357a",
> 	[DAILINK_RT5514] = "realtek,rt5514",
> 	[DAILINK_DA7219] = "dlg,da7219",
> };
i've thought about this too, but i'm working on converting rt5514 
dsp(spi) from codec name matching to of_node, and it would have the same 
compatible with rt5514(i2c)

WARNING: multiple messages have this Message-ID (diff)
From: jeffy.chen@rock-chips.com (jeffy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ASoC: rockchip: Parse dai links from dts
Date: Thu, 17 Aug 2017 06:55:20 +0800	[thread overview]
Message-ID: <5994CD58.7030406@rock-chips.com> (raw)
In-Reply-To: <20170816215909.GC109008@google.com>

hi matthias,

thanks for your suggestion.

On 08/17/2017 05:59 AM, Matthias Kaehlcke wrote:
> El Thu, Aug 10, 2017 at 12:54:56PM +0800 Jeffy Chen ha dit:
>
>> >Refactor rockchip_sound_probe, parse dai links from dts instead of
>> >hard coding them.
> Mark doesn't seem to be overly convinced that 'rockchip,codec-names'
> is a good idea (https://lkml.org/lkml/2017/8/10/511).
>
> How about using something like this instead:
>
> static const char *dailink_compat[] = {
> 	[DAILINK_MAX98357A] = "maxim,max98357a",
> 	[DAILINK_RT5514] = "realtek,rt5514",
> 	[DAILINK_DA7219] = "dlg,da7219",
> };
i've thought about this too, but i'm working on converting rt5514 
dsp(spi) from codec name matching to of_node, and it would have the same 
compatible with rt5514(i2c)

  reply	other threads:[~2017-08-16 22:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-10  4:54 [PATCH v2 0/3] ASoC: rockchip: Parse dai links from dts Jeffy Chen
2017-08-10  4:54 ` Jeffy Chen
2017-08-10  4:54 ` Jeffy Chen
2017-08-10  4:54 ` [PATCH v2 1/3] " Jeffy Chen
2017-08-10  4:54   ` Jeffy Chen
2017-08-16 21:59   ` Matthias Kaehlcke
2017-08-16 21:59     ` Matthias Kaehlcke
2017-08-16 22:55     ` jeffy [this message]
2017-08-16 22:55       ` jeffy
2017-08-16 23:50       ` Matthias Kaehlcke
2017-08-16 23:50         ` Matthias Kaehlcke
2017-08-16 23:50         ` Matthias Kaehlcke
2017-08-17  4:45         ` jeffy
2017-08-17  4:45           ` jeffy
     [not found] ` <1502340898-28403-1-git-send-email-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-10  4:54   ` [PATCH v2 2/3] arm64: dts: rockchip: Add rockchip,codec-names property Jeffy Chen
2017-08-10  4:54     ` Jeffy Chen
2017-08-10  4:54     ` [PATCH v2 2/3] arm64: dts: rockchip: Add rockchip, codec-names property Jeffy Chen
2017-08-10  4:54 ` [PATCH v2 3/3] dt-bindings: ASoC: rockchip: Add rockchip,codec-names property Jeffy Chen
2017-08-10  4:54   ` [PATCH v2 3/3] dt-bindings: ASoC: rockchip: Add rockchip, codec-names property Jeffy Chen
2017-08-10 14:56   ` [PATCH v2 3/3] dt-bindings: ASoC: rockchip: Add rockchip,codec-names property Mark Brown
2017-08-10 14:56     ` Mark Brown
     [not found]     ` <20170810145607.g663oq7cfxjmaxtf-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-08-11  1:30       ` jeffy
2017-08-11  1:30         ` jeffy
2017-08-11  1:30         ` [PATCH v2 3/3] dt-bindings: ASoC: rockchip: Add rockchip, codec-names property jeffy
     [not found]   ` <1502340898-28403-4-git-send-email-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-17 15:10     ` [PATCH v2 3/3] dt-bindings: ASoC: rockchip: Add rockchip,codec-names property Rob Herring
2017-08-17 15:10       ` Rob Herring
2017-08-17 15:10       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5994CD58.7030406@rock-chips.com \
    --to=jeffy.chen@rock-chips.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=briannorris@chromium.org \
    --cc=broonie@kernel.org \
    --cc=dgreid@chromium.org \
    --cc=dianders@chromium.org \
    --cc=heiko@sntech.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mka@chromium.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.