From: jeffy <jeffy.chen@rock-chips.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
linux-pci@vger.kernel.org, briannorris@chromium.org,
linux-kernel@vger.kernel.org, dianders@chromium.org,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
bhelgaas@google.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 2/3] dt-bindings: PCI: rockchip: Add support for pcie wake irq
Date: Thu, 17 Aug 2017 14:17:52 +0800 [thread overview]
Message-ID: <59953510.8000509@rock-chips.com> (raw)
In-Reply-To: <35487e90-74f2-3a66-70d3-d0780b0b6e26@rock-chips.com>
Hi Shawn,
On 08/16/2017 04:35 PM, Shawn Lin wrote:
> Hi Jeffy
>
> On 2017/8/16 15:52, Jeffy Chen wrote:
>> Add an optional interrupt for PCIE_WAKE pin.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> ---
>>
>> Documentation/devicetree/bindings/pci/rockchip-pcie.txt | 11
>> +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> index 1453a734c2f5..6ef9903567db 100644
>> --- a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> +++ b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> @@ -22,10 +22,13 @@ Required properties:
>> - phys: From PHY bindings: Phandle for the Generic PHY for PCIe.
>> - phy-names: MUST be "pcie-phy".
>> - interrupts: Three interrupt entries must be specified.
>> -- interrupt-names: Must include the following names
>> - - "sys"
>> - - "legacy"
>> - - "client"
>> +- interrupt-names: Include the following names
>> + Required:
>> + - "sys"
>> + - "legacy"
>> + - "client"
>> + Optional:
>> + - "wake"
>
> It would be better to introduce interrupts-extended and show a example
> here. :)
ok, will add it in next version
>
>> - resets: Must contain seven entries for each entry in reset-names.
>> See ../reset/reset.txt for details.
>> - reset-names: Must include the following names
>>
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: jeffy <jeffy.chen@rock-chips.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: linux-kernel@vger.kernel.org, bhelgaas@google.com,
briannorris@chromium.org, dianders@chromium.org,
devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 2/3] dt-bindings: PCI: rockchip: Add support for pcie wake irq
Date: Thu, 17 Aug 2017 14:17:52 +0800 [thread overview]
Message-ID: <59953510.8000509@rock-chips.com> (raw)
In-Reply-To: <35487e90-74f2-3a66-70d3-d0780b0b6e26@rock-chips.com>
Hi Shawn,
On 08/16/2017 04:35 PM, Shawn Lin wrote:
> Hi Jeffy
>
> On 2017/8/16 15:52, Jeffy Chen wrote:
>> Add an optional interrupt for PCIE_WAKE pin.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> ---
>>
>> Documentation/devicetree/bindings/pci/rockchip-pcie.txt | 11
>> +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> index 1453a734c2f5..6ef9903567db 100644
>> --- a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> +++ b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> @@ -22,10 +22,13 @@ Required properties:
>> - phys: From PHY bindings: Phandle for the Generic PHY for PCIe.
>> - phy-names: MUST be "pcie-phy".
>> - interrupts: Three interrupt entries must be specified.
>> -- interrupt-names: Must include the following names
>> - - "sys"
>> - - "legacy"
>> - - "client"
>> +- interrupt-names: Include the following names
>> + Required:
>> + - "sys"
>> + - "legacy"
>> + - "client"
>> + Optional:
>> + - "wake"
>
> It would be better to introduce interrupts-extended and show a example
> here. :)
ok, will add it in next version
>
>> - resets: Must contain seven entries for each entry in reset-names.
>> See ../reset/reset.txt for details.
>> - reset-names: Must include the following names
>>
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: jeffy.chen@rock-chips.com (jeffy)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/3] dt-bindings: PCI: rockchip: Add support for pcie wake irq
Date: Thu, 17 Aug 2017 14:17:52 +0800 [thread overview]
Message-ID: <59953510.8000509@rock-chips.com> (raw)
In-Reply-To: <35487e90-74f2-3a66-70d3-d0780b0b6e26@rock-chips.com>
Hi Shawn,
On 08/16/2017 04:35 PM, Shawn Lin wrote:
> Hi Jeffy
>
> On 2017/8/16 15:52, Jeffy Chen wrote:
>> Add an optional interrupt for PCIE_WAKE pin.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> ---
>>
>> Documentation/devicetree/bindings/pci/rockchip-pcie.txt | 11
>> +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> index 1453a734c2f5..6ef9903567db 100644
>> --- a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> +++ b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> @@ -22,10 +22,13 @@ Required properties:
>> - phys: From PHY bindings: Phandle for the Generic PHY for PCIe.
>> - phy-names: MUST be "pcie-phy".
>> - interrupts: Three interrupt entries must be specified.
>> -- interrupt-names: Must include the following names
>> - - "sys"
>> - - "legacy"
>> - - "client"
>> +- interrupt-names: Include the following names
>> + Required:
>> + - "sys"
>> + - "legacy"
>> + - "client"
>> + Optional:
>> + - "wake"
>
> It would be better to introduce interrupts-extended and show a example
> here. :)
ok, will add it in next version
>
>> - resets: Must contain seven entries for each entry in reset-names.
>> See ../reset/reset.txt for details.
>> - reset-names: Must include the following names
>>
>
>
>
next prev parent reply other threads:[~2017-08-17 6:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 7:52 [RFC PATCH 0/3] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver Jeffy Chen
2017-08-16 7:52 ` Jeffy Chen
2017-08-16 7:52 ` Jeffy Chen
2017-08-16 7:52 ` [RFC PATCH 1/3] PCI: rockchip: Add support for pcie wake irq Jeffy Chen
2017-08-16 7:52 ` Jeffy Chen
2017-08-16 7:52 ` Jeffy Chen
2017-08-16 9:00 ` Shawn Lin
2017-08-16 9:00 ` Shawn Lin
2017-08-17 0:25 ` jeffy
2017-08-17 0:25 ` jeffy
2017-08-17 0:25 ` jeffy
2017-08-16 17:49 ` Brian Norris
2017-08-16 17:49 ` Brian Norris
2017-08-17 12:03 ` jeffy
2017-08-17 12:03 ` jeffy
2017-08-17 12:03 ` jeffy
2017-08-16 7:52 ` [RFC PATCH 2/3] dt-bindings: " Jeffy Chen
2017-08-16 7:52 ` Jeffy Chen
2017-08-16 7:52 ` Jeffy Chen
2017-08-16 8:35 ` Shawn Lin
2017-08-16 8:35 ` Shawn Lin
2017-08-16 8:35 ` Shawn Lin
2017-08-16 8:35 ` Shawn Lin
2017-08-17 6:17 ` jeffy [this message]
2017-08-17 6:17 ` jeffy
2017-08-17 6:17 ` jeffy
2017-08-16 7:52 ` [RFC PATCH 3/3] arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru Jeffy Chen
2017-08-16 7:52 ` Jeffy Chen
[not found] ` <20170816075224.31734-4-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-16 8:33 ` Shawn Lin
2017-08-16 8:33 ` Shawn Lin
2017-08-16 8:33 ` Shawn Lin
[not found] ` <3bd2600e-6e5d-6179-6b9b-6989e1f65b7d-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-16 16:43 ` Brian Norris
2017-08-16 16:43 ` Brian Norris
2017-08-16 16:43 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59953510.8000509@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.