From: Daniel Borkmann <daniel@iogearbox.net>
To: Alexei Starovoitov <ast@fb.com>, davem@davemloft.net
Cc: john.fastabend@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] bpf: fix double free from dev_map_notification()
Date: Mon, 21 Aug 2017 02:47:55 +0200 [thread overview]
Message-ID: <599A2DBB.2060305@iogearbox.net> (raw)
In-Reply-To: <52f70537-afcf-e384-cb96-2a5b8c032c51@fb.com>
On 08/21/2017 02:42 AM, Alexei Starovoitov wrote:
> On 8/20/17 4:48 PM, Daniel Borkmann wrote:
[...]
> I wonder why it was done the other way around in the first place then?
> dev_map_list is there only for notifier and since the map is freed
> with all the devices totally makes sense to isolate it from notifier
> as a first step.
Yep, agree. Initially this was done by the mutex, but that was not
correct due to RCU for map helpers, of course.
next prev parent reply other threads:[~2017-08-21 0:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-20 23:48 [PATCH net-next] bpf: fix double free from dev_map_notification() Daniel Borkmann
2017-08-21 0:42 ` Alexei Starovoitov
2017-08-21 0:47 ` Daniel Borkmann [this message]
2017-08-21 2:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=599A2DBB.2060305@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@fb.com \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.