From: jeffy <jeffy.chen@rock-chips.com>
To: Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, mengdong.lin@linux.intel.com,
lars@metafoo.de, linux-kernel@vger.kernel.org,
briannorris@chromium.org, dianders@chromium.org,
"Donglin Peng" <dolinux.peng@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
mka@chromium.org, dgreid@chromium.org,
"Heiko Stübner" <heiko@sntech.de>
Subject: Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai
Date: Tue, 22 Aug 2017 22:39:06 +0800 [thread overview]
Message-ID: <599C420A.80601@rock-chips.com> (raw)
In-Reply-To: <s5h8tib8yq4.wl-tiwai@suse.de>
Hi guys,
On 08/22/2017 10:26 PM, Takashi Iwai wrote:
> On Tue, 22 Aug 2017 16:21:11 +0200,
> Mark Brown wrote:
>>
>> On Tue, Aug 22, 2017 at 10:15:32PM +0800, Donglin Peng wrote:
>>> On Tue, Aug 22, 2017 at 10:02 PM, Mark Brown <broonie@kernel.org> wrote:
>>
>>>> We should be already verifying that drivers have a name, we assume one
>>>> elsewhere.
>>
>>> But I can't find any codes that set or check dai_driver->name in
>>> function snd_soc_register_codec or snd_soc_register_component.
>>
>> We should fix that then.
>
> Hmm, as far as I read the code, the NULL dai driver name is valid for
> a single component. The dai name is determined by fmt_single_name().
>
>
> Takashi
>
>
sorry, i though that is checked too... new patch is coming, thanks for
noticing :)
>
WARNING: multiple messages have this Message-ID (diff)
From: jeffy <jeffy.chen@rock-chips.com>
To: Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>
Cc: "Donglin Peng" <dolinux.peng@gmail.com>,
alsa-devel@alsa-project.org, briannorris@chromium.org,
dgreid@chromium.org, dianders@chromium.org, mka@chromium.org,
"Liam Girdwood" <lgirdwood@gmail.com>,
mengdong.lin@linux.intel.com, lars@metafoo.de,
"Jaroslav Kysela" <perex@perex.cz>,
"Heiko Stübner" <heiko@sntech.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai
Date: Tue, 22 Aug 2017 22:39:06 +0800 [thread overview]
Message-ID: <599C420A.80601@rock-chips.com> (raw)
In-Reply-To: <s5h8tib8yq4.wl-tiwai@suse.de>
Hi guys,
On 08/22/2017 10:26 PM, Takashi Iwai wrote:
> On Tue, 22 Aug 2017 16:21:11 +0200,
> Mark Brown wrote:
>>
>> On Tue, Aug 22, 2017 at 10:15:32PM +0800, Donglin Peng wrote:
>>> On Tue, Aug 22, 2017 at 10:02 PM, Mark Brown <broonie@kernel.org> wrote:
>>
>>>> We should be already verifying that drivers have a name, we assume one
>>>> elsewhere.
>>
>>> But I can't find any codes that set or check dai_driver->name in
>>> function snd_soc_register_codec or snd_soc_register_component.
>>
>> We should fix that then.
>
> Hmm, as far as I read the code, the NULL dai driver name is valid for
> a single component. The dai name is determined by fmt_single_name().
>
>
> Takashi
>
>
sorry, i though that is checked too... new patch is coming, thanks for
noticing :)
>
next prev parent reply other threads:[~2017-08-22 14:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 7:57 [PATCH v5 0/9] ASoC: rockchip: Parse dai links from dts Jeffy Chen
2017-08-22 7:57 ` Jeffy Chen
2017-08-22 7:57 ` Jeffy Chen
2017-08-22 7:57 ` [PATCH v5 1/9] ASoC: rockchip: Remove obsolete dmic-delay Jeffy Chen
2017-08-22 7:57 ` Jeffy Chen
2017-08-22 10:32 ` Mark Brown
2017-08-22 10:32 ` Mark Brown
2017-08-22 11:01 ` jeffy
2017-08-22 11:01 ` jeffy
2017-08-22 11:01 ` jeffy
2017-08-22 7:57 ` [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai Jeffy Chen
2017-08-22 7:57 ` Jeffy Chen
2017-08-22 12:47 ` Applied "ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai" to the asoc tree Mark Brown
2017-08-22 12:47 ` Mark Brown
2017-08-22 13:24 ` [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai Donglin Peng
2017-08-22 14:02 ` Mark Brown
2017-08-22 14:15 ` Donglin Peng
2017-08-22 14:21 ` Mark Brown
2017-08-22 14:26 ` Takashi Iwai
2017-08-22 14:26 ` Takashi Iwai
2017-08-22 14:31 ` Mark Brown
2017-08-22 14:39 ` jeffy [this message]
2017-08-22 14:39 ` jeffy
2017-08-22 7:57 ` [PATCH v5 3/9] ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp Jeffy Chen
2017-08-22 7:57 ` Jeffy Chen
2017-08-22 7:57 ` [PATCH v5 4/9] arm64: dts: rockchip: Add rt5514 dsp for Gru Jeffy Chen
2017-08-22 7:57 ` Jeffy Chen
2017-08-22 7:57 ` [PATCH v5 5/9] arm64: dts: rockchip: Update rt5514 devices' compatible " Jeffy Chen
2017-08-22 7:57 ` Jeffy Chen
2017-08-22 7:57 ` [PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts Jeffy Chen
2017-08-22 7:57 ` Jeffy Chen
2017-08-22 9:08 ` Donglin Peng
2017-08-22 9:08 ` Donglin Peng
2017-08-22 9:25 ` jeffy
2017-08-22 9:25 ` jeffy
2017-08-22 7:57 ` [PATCH v5 7/9] ASoC: rockchip: Add support for DP codec Jeffy Chen
2017-08-22 7:57 ` Jeffy Chen
2017-08-22 7:57 ` [PATCH v5 8/9] ASoC: rockchip: Add support for DMIC codec Jeffy Chen
2017-08-22 7:57 ` Jeffy Chen
[not found] ` <20170822075729.8438-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-22 7:57 ` [PATCH v5 9/9] dt-bindings: ASoC: rockchip: Update description of rockchip,codec Jeffy Chen
2017-08-22 7:57 ` Jeffy Chen
2017-08-22 7:57 ` [PATCH v5 9/9] dt-bindings: ASoC: rockchip: Update description of rockchip, codec Jeffy Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=599C420A.80601@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=alsa-devel@alsa-project.org \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=dgreid@chromium.org \
--cc=dianders@chromium.org \
--cc=dolinux.peng@gmail.com \
--cc=heiko@sntech.de \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mengdong.lin@linux.intel.com \
--cc=mka@chromium.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.