All of lore.kernel.org
 help / color / mirror / Atom feed
From: arvind.yadav.cs@gmail.com (arvind)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/9] constify amba_id
Date: Fri, 25 Aug 2017 23:29:40 +0530	[thread overview]
Message-ID: <59A0658C.8070404@gmail.com> (raw)
In-Reply-To: <CANLsYkwVT=N8FOCOAYnZMCXEBt8aB9ovMymPYuYHLhqb4DwwGg@mail.gmail.com>

Hi,

On Friday 25 August 2017 09:50 PM, Mathieu Poirier wrote:
> On 24 August 2017 at 10:35, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
>> amba_id are not supposed to change at runtime. All functions
>> working with const amba_id. So mark the non-const structs as const.
> The real explanation here is that coresight IDs are only referenced in
> the amba driver declaration where the "id_table" field of struct
> amba_driver is a const.  Given the widespread usage of the pattern I
> would have expected this set to be part of a wide effort.  Also did
> you find this manually or by using a tool?  If so please provide a
> description of what that tool is.
I am not using any tools. I have push same change for other subsystem.
So I thought to change coresight ids.
>
> Thanks,
> Mathieu
>
>> Arvind Yadav (9):
>>    [PATCH 1/9] coresight: constify amba_id
>>    [PATCH 2/9] coresight: etb10: constify amba_id
>>    [PATCH 3/9] coresight: etm3x: constify amba_id
>>    [PATCH 4/9] coresight: etm4x: constify amba_id
>>    [PATCH 5/9] coresight: funnel: constify amba_id
>>    [PATCH 6/9] coresight: replicator: constify amba_id
>>    [PATCH 7/9] coresight: stm: constify amba_id
>>    [PATCH 8/9] coresight: tmc: constify amba_id
>>    [PATCH 9/9] coresight: tpiu: constify amba_id
>>
>>   drivers/hwtracing/coresight/coresight-cpu-debug.c       | 2 +-
>>   drivers/hwtracing/coresight/coresight-etb10.c           | 2 +-
>>   drivers/hwtracing/coresight/coresight-etm3x.c           | 2 +-
>>   drivers/hwtracing/coresight/coresight-etm4x.c           | 2 +-
>>   drivers/hwtracing/coresight/coresight-funnel.c          | 2 +-
>>   drivers/hwtracing/coresight/coresight-replicator-qcom.c | 2 +-
>>   drivers/hwtracing/coresight/coresight-stm.c             | 2 +-
>>   drivers/hwtracing/coresight/coresight-tmc.c             | 2 +-
>>   drivers/hwtracing/coresight/coresight-tpiu.c            | 2 +-
>>   9 files changed, 9 insertions(+), 9 deletions(-)
>>
>> --
>> 2.7.4
>>
~arvind

WARNING: multiple messages have this Message-ID (diff)
From: arvind <arvind.yadav.cs@gmail.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/9] constify amba_id
Date: Fri, 25 Aug 2017 23:29:40 +0530	[thread overview]
Message-ID: <59A0658C.8070404@gmail.com> (raw)
In-Reply-To: <CANLsYkwVT=N8FOCOAYnZMCXEBt8aB9ovMymPYuYHLhqb4DwwGg@mail.gmail.com>

Hi,

On Friday 25 August 2017 09:50 PM, Mathieu Poirier wrote:
> On 24 August 2017 at 10:35, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
>> amba_id are not supposed to change at runtime. All functions
>> working with const amba_id. So mark the non-const structs as const.
> The real explanation here is that coresight IDs are only referenced in
> the amba driver declaration where the "id_table" field of struct
> amba_driver is a const.  Given the widespread usage of the pattern I
> would have expected this set to be part of a wide effort.  Also did
> you find this manually or by using a tool?  If so please provide a
> description of what that tool is.
I am not using any tools. I have push same change for other subsystem.
So I thought to change coresight ids.
>
> Thanks,
> Mathieu
>
>> Arvind Yadav (9):
>>    [PATCH 1/9] coresight: constify amba_id
>>    [PATCH 2/9] coresight: etb10: constify amba_id
>>    [PATCH 3/9] coresight: etm3x: constify amba_id
>>    [PATCH 4/9] coresight: etm4x: constify amba_id
>>    [PATCH 5/9] coresight: funnel: constify amba_id
>>    [PATCH 6/9] coresight: replicator: constify amba_id
>>    [PATCH 7/9] coresight: stm: constify amba_id
>>    [PATCH 8/9] coresight: tmc: constify amba_id
>>    [PATCH 9/9] coresight: tpiu: constify amba_id
>>
>>   drivers/hwtracing/coresight/coresight-cpu-debug.c       | 2 +-
>>   drivers/hwtracing/coresight/coresight-etb10.c           | 2 +-
>>   drivers/hwtracing/coresight/coresight-etm3x.c           | 2 +-
>>   drivers/hwtracing/coresight/coresight-etm4x.c           | 2 +-
>>   drivers/hwtracing/coresight/coresight-funnel.c          | 2 +-
>>   drivers/hwtracing/coresight/coresight-replicator-qcom.c | 2 +-
>>   drivers/hwtracing/coresight/coresight-stm.c             | 2 +-
>>   drivers/hwtracing/coresight/coresight-tmc.c             | 2 +-
>>   drivers/hwtracing/coresight/coresight-tpiu.c            | 2 +-
>>   9 files changed, 9 insertions(+), 9 deletions(-)
>>
>> --
>> 2.7.4
>>
~arvind

  reply	other threads:[~2017-08-25 17:59 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 16:35 [PATCH 0/9] constify amba_id Arvind Yadav
2017-08-24 16:35 ` Arvind Yadav
2017-08-24 16:35 ` [PATCH 1/9] coresight: " Arvind Yadav
2017-08-24 16:35   ` Arvind Yadav
2017-08-24 16:35 ` [PATCH 2/9] coresight: etb10: " Arvind Yadav
2017-08-24 16:35   ` Arvind Yadav
2017-08-24 16:35 ` [PATCH 3/9] coresight: etm3x: " Arvind Yadav
2017-08-24 16:35   ` Arvind Yadav
2017-08-24 16:36 ` [PATCH 4/9] coresight: etm4x: " Arvind Yadav
2017-08-24 16:36   ` Arvind Yadav
2017-08-24 16:36 ` [PATCH 5/9] coresight: funnel: " Arvind Yadav
2017-08-24 16:36   ` Arvind Yadav
2017-08-24 16:36 ` [PATCH 6/9] coresight: replicator: " Arvind Yadav
2017-08-24 16:36   ` Arvind Yadav
2017-08-24 16:36 ` [PATCH 7/9] coresight: stm: " Arvind Yadav
2017-08-24 16:36   ` Arvind Yadav
2017-08-24 16:36 ` [PATCH 8/9] coresight: tmc: " Arvind Yadav
2017-08-24 16:36   ` Arvind Yadav
2017-08-24 16:36 ` [PATCH 9/9] coresight: tpiu: " Arvind Yadav
2017-08-24 16:36   ` Arvind Yadav
2017-08-25 16:20 ` [PATCH 0/9] " Mathieu Poirier
2017-08-25 16:20   ` Mathieu Poirier
2017-08-25 17:59   ` arvind [this message]
2017-08-25 17:59     ` arvind
2017-08-28 16:48 ` Mathieu Poirier
2017-08-28 16:48   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59A0658C.8070404@gmail.com \
    --to=arvind.yadav.cs@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.