All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Longpeng (Mike)" <longpeng2@huawei.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>
Cc: stefanha@redhat.com, qemu-devel@nongnu.org,
	virtio-dev@lists.oasis-open.org, luonengjun@huawei.com,
	mst@redhat.com, cohuck@redhat.com, denglingli@chinamobile.com,
	Jani.Kokkonen@huawei.com, Ola.Liljedahl@arm.com,
	Varun.Sethi@freescale.com, xin.zeng@intel.com,
	brian.a.keating@intel.com, liang.j.ma@intel.com,
	john.griffin@intel.com, weidong.huang@huawei.com,
	mike.caraman@nxp.com, agraf@suse.de, jasowang@redhat.com,
	nmorey@kalray.eu, vincent.jardin@6wind.com,
	arei.gonglei@hotmail.com, wangxinxin.wang@huawei.com
Subject: Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification
Date: Fri, 01 Sep 2017 18:52:14 -0700	[thread overview]
Message-ID: <59AA0ECE.5040408@huawei.com> (raw)
In-Reply-To: <7f0b8eb2-9e5c-7507-191d-1aab17c6ff0f@linux.vnet.ibm.com>

Hi Halil,

On 2017/9/1 19:45, Halil Pasic wrote:

> 
> 
> On 09/01/2017 02:47 AM, Longpeng (Mike) wrote:
>> Ping...
>>
>> Stefan, Halil, do you have any suggestion ?
>>
> 
> Hi Longpeng,
> 
> I've ran trough your patch, and it reads much better that
> what I recall v18 used to read like. Because it's been a while
> since v18 doing a conscious review on this will take a considerable
> amount of time (my memories of the issues identified back then
> are very sketchy/vague now). It's on my todo list, but it ain't the
> only item there.
> 


That's great, thanks :)

> Btw. I like to have a reference implementation at hand when reviewing
> a spec. What is the status of the (reference) implementation (I mean
> the new stuff like stateless/mux)? I think it would be nice to provide
> this info in the cover letter (e.g. next time, should we need another
> iteration).
> 


OK, I'll send a reference implementation based on the v19 spec next week.

> Regards,
> Halil
> 
> 
> .
> 


-- 
Regards,
Longpeng(Mike)


WARNING: multiple messages have this Message-ID (diff)
From: "Longpeng (Mike)" <longpeng2@huawei.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>
Cc: stefanha@redhat.com, qemu-devel@nongnu.org,
	virtio-dev@lists.oasis-open.org, luonengjun@huawei.com,
	mst@redhat.com, cohuck@redhat.com, denglingli@chinamobile.com,
	Jani.Kokkonen@huawei.com, Ola.Liljedahl@arm.com,
	Varun.Sethi@freescale.com, xin.zeng@intel.com,
	brian.a.keating@intel.com, liang.j.ma@intel.com,
	john.griffin@intel.com, weidong.huang@huawei.com,
	mike.caraman@nxp.com, agraf@suse.de, jasowang@redhat.com,
	nmorey@kalray.eu, vincent.jardin@6wind.com,
	arei.gonglei@hotmail.com, wangxinxin.wang@huawei.com
Subject: Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification
Date: Sat, 2 Sep 2017 09:52:14 +0800	[thread overview]
Message-ID: <59AA0ECE.5040408@huawei.com> (raw)
In-Reply-To: <7f0b8eb2-9e5c-7507-191d-1aab17c6ff0f@linux.vnet.ibm.com>

Hi Halil,

On 2017/9/1 19:45, Halil Pasic wrote:

> 
> 
> On 09/01/2017 02:47 AM, Longpeng (Mike) wrote:
>> Ping...
>>
>> Stefan, Halil, do you have any suggestion ?
>>
> 
> Hi Longpeng,
> 
> I've ran trough your patch, and it reads much better that
> what I recall v18 used to read like. Because it's been a while
> since v18 doing a conscious review on this will take a considerable
> amount of time (my memories of the issues identified back then
> are very sketchy/vague now). It's on my todo list, but it ain't the
> only item there.
> 


That's great, thanks :)

> Btw. I like to have a reference implementation at hand when reviewing
> a spec. What is the status of the (reference) implementation (I mean
> the new stuff like stateless/mux)? I think it would be nice to provide
> this info in the cover letter (e.g. next time, should we need another
> iteration).
> 


OK, I'll send a reference implementation based on the v19 spec next week.

> Regards,
> Halil
> 
> 
> .
> 


-- 
Regards,
Longpeng(Mike)

  reply	other threads:[~2017-09-02  1:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-26  7:53 [PATCH v19 0/2] virtio-crypto: virtio crypto device specification Longpeng(Mike)
2017-08-26  7:53 ` [Qemu-devel] " Longpeng(Mike)
2017-08-26  7:53 ` [PATCH v19 1/2] virtio-crypto: Add " Longpeng(Mike)
2017-08-26  7:53   ` [Qemu-devel] " Longpeng(Mike)
2017-08-26  7:53 ` [PATCH v19 2/2] virtio-crypto: Add conformance clauses Longpeng(Mike)
2017-08-26  7:53   ` [Qemu-devel] " Longpeng(Mike)
2017-09-01  0:47 ` [PATCH v19 0/2] virtio-crypto: virtio crypto device specification Longpeng (Mike)
2017-09-01  0:47   ` [Qemu-devel] " Longpeng (Mike)
2017-09-01 11:45   ` [virtio-dev] " Halil Pasic
2017-09-01 11:45     ` Halil Pasic
2017-09-02  1:52     ` Longpeng (Mike) [this message]
2017-09-02  1:52       ` Longpeng (Mike)
2017-09-06 13:52     ` [virtio-dev] " Michael S. Tsirkin
2017-09-06 13:52       ` [Qemu-devel] [virtio-dev] " Michael S. Tsirkin
2017-09-06 14:12       ` [virtio-dev] Re: [Qemu-devel] " Halil Pasic
2017-09-06 14:12         ` [Qemu-devel] [virtio-dev] " Halil Pasic
2017-09-08  4:17       ` [virtio-dev] Re: [Qemu-devel] " Longpeng (Mike)
2017-09-08  4:17         ` [Qemu-devel] [virtio-dev] " Longpeng (Mike)
2017-09-08  3:49   ` Michael S. Tsirkin
2017-09-08  3:49     ` [Qemu-devel] " Michael S. Tsirkin
2017-09-08  4:22     ` Longpeng (Mike)
2017-09-08  4:22       ` [Qemu-devel] " Longpeng (Mike)
2017-09-08  4:31       ` [virtio-dev] " Michael S. Tsirkin
2017-09-08  4:31         ` [Qemu-devel] " Michael S. Tsirkin
2017-09-08  6:32         ` Longpeng (Mike)
2017-09-08  6:32           ` [Qemu-devel] " Longpeng (Mike)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59AA0ECE.5040408@huawei.com \
    --to=longpeng2@huawei.com \
    --cc=Jani.Kokkonen@huawei.com \
    --cc=Ola.Liljedahl@arm.com \
    --cc=Varun.Sethi@freescale.com \
    --cc=agraf@suse.de \
    --cc=arei.gonglei@hotmail.com \
    --cc=brian.a.keating@intel.com \
    --cc=cohuck@redhat.com \
    --cc=denglingli@chinamobile.com \
    --cc=jasowang@redhat.com \
    --cc=john.griffin@intel.com \
    --cc=liang.j.ma@intel.com \
    --cc=luonengjun@huawei.com \
    --cc=mike.caraman@nxp.com \
    --cc=mst@redhat.com \
    --cc=nmorey@kalray.eu \
    --cc=pasic@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vincent.jardin@6wind.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=wangxinxin.wang@huawei.com \
    --cc=weidong.huang@huawei.com \
    --cc=xin.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.