From: Chanwoo Choi <cw00.choi@samsung.com>
To: Colin King <colin.king@canonical.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: make extcon_info static const, fixes warning
Date: Mon, 11 Sep 2017 00:43:05 +0000 [thread overview]
Message-ID: <59B5DC19.4020805@samsung.com> (raw)
In-Reply-To: <20170909165100.30701-1-colin.king@canonical.com>
On 2017년 09월 10일 01:51, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The array extcon_info is read only, local to the source and does not
> need to be in global scope, so make it static const.
>
> Cleans up sparse warning:
> symbol 'extcon_info' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/extcon/extcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 35e9fb885486..cb38c2747684 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -36,7 +36,7 @@
>
> #define SUPPORTED_CABLE_MAX 32
>
> -struct __extcon_info {
> +static const struct __extcon_info {
> unsigned int type;
> unsigned int id;
> const char *name;
>
Applied it for v4.15. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Colin King <colin.king@canonical.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: make extcon_info static const, fixes warning
Date: Mon, 11 Sep 2017 09:43:05 +0900 [thread overview]
Message-ID: <59B5DC19.4020805@samsung.com> (raw)
In-Reply-To: <20170909165100.30701-1-colin.king@canonical.com>
On 2017년 09월 10일 01:51, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The array extcon_info is read only, local to the source and does not
> need to be in global scope, so make it static const.
>
> Cleans up sparse warning:
> symbol 'extcon_info' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/extcon/extcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 35e9fb885486..cb38c2747684 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -36,7 +36,7 @@
>
> #define SUPPORTED_CABLE_MAX 32
>
> -struct __extcon_info {
> +static const struct __extcon_info {
> unsigned int type;
> unsigned int id;
> const char *name;
>
Applied it for v4.15. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2017-09-11 0:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170909165107epcas3p169935c5e37c5b21a9ffecf4cf01d5256@epcas3p1.samsung.com>
2017-09-09 16:51 ` [PATCH] extcon: make extcon_info static const, fixes warning Colin King
2017-09-09 16:51 ` Colin King
2017-09-11 0:43 ` Chanwoo Choi [this message]
2017-09-11 0:43 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59B5DC19.4020805@samsung.com \
--to=cw00.choi@samsung.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.