From: Daniel Borkmann <daniel@iogearbox.net>
To: Jesper Dangaard Brouer <brouer@redhat.com>,
Eric Leblond <eric@regit.org>
Cc: xdp-newbies@vger.kernel.org, wangnan0@huawei.com,
Daniel Borkmann <borkmann@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: libbpf missing set_link_xdp_fd ?
Date: Mon, 25 Sep 2017 13:02:04 +0200 [thread overview]
Message-ID: <59C8E22C.3000609@iogearbox.net> (raw)
In-Reply-To: <59C8CF39.7030405@iogearbox.net>
On 09/25/2017 11:41 AM, Daniel Borkmann wrote:
> On 09/25/2017 11:25 AM, Jesper Dangaard Brouer wrote:
>> On Sun, 24 Sep 2017 20:07:11 +0200
>> Eric Leblond <eric@regit.org> wrote:
>>
>>> Hello,
>>>
>>> bpf_load is implementing the set_link_xdp_fd() function and it seems
>>> this function is not available in libbpf.
>>
>> I also ran into this problem, when I wanted to switch my XDP programs
>> into using tools/lib/bpf/.
>
> Right.
>
>> E.g.: https://github.com/netoptimizer/prototype-kernel/commit/5397e596c30416763
>>
>>> Should it be the case or should it be part of another library ?
>>
>> I'm not sure... maybe Alexei, Daniel or Wang have an opinion?
>
> It seems that none of the actual attach infra is handled in
> tools/lib/bpf/, meaning neither attaching the fd to kprobes/
> uprobes/tracepoints nor tc or xdp, so adding a special case
> only for xdp into the lib feels that we probably might be better
> off putting this either into its own mini lib on top of that,
That could potentially go to tools/lib/xdp/, probably would be
the best option.
> or as a small helper included in the samples / selftests and
> the like where its needed.
>
> Best,
> Daniel
next prev parent reply other threads:[~2017-09-25 11:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 18:07 libbpf missing set_link_xdp_fd ? Eric Leblond
2017-09-25 9:25 ` Jesper Dangaard Brouer
2017-09-25 9:41 ` Daniel Borkmann
2017-09-25 11:02 ` Daniel Borkmann [this message]
2017-09-25 16:01 ` Alexei Starovoitov
2017-09-25 19:39 ` Daniel Borkmann
2017-09-25 10:03 ` Wangnan (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59C8E22C.3000609@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=brouer@redhat.com \
--cc=eric@regit.org \
--cc=wangnan0@huawei.com \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.