From: "Wei Hu (Xavier)" <xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lijun_nudt-9Onoh4P/yGk@public.gmane.org,
oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
charles.chenxin-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
xushaobo2-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
zhangxiping3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
xavier.huwei-WVlzvzqoTvw@public.gmane.org,
linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
shaobohsu-9Onoh4P/yGk@public.gmane.org
Subject: Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function
Date: Fri, 29 Sep 2017 10:05:04 +0800 [thread overview]
Message-ID: <59CDAA50.60809@huawei.com> (raw)
In-Reply-To: <20170928135014.GY2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On 2017/9/28 21:50, Leon Romanovsky wrote:
> On Thu, Sep 28, 2017 at 12:57:27PM +0800, Wei Hu (Xavier) wrote:
>> From: Lijun Ou <oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>>
>> It mainly places the lines for checking send doorbell status
>> into a special functions. As a result, we can directly call it in
>> check_qp_db_process_status function and keep consistent indenting
>> style.
>>
>> It fixes: 5f110ac4bed8 ("IB/hns: Fix for checkpatch.pl comment style)
> You forgot " at the end of the line, and there is need to put fixes
> (should be Fixes) in the line before Signed-off-by.
Thanks, Leon
We will modify the statement(Fixes: xx) and put it before signed-off-by
in patch v2.
>> The warning from static checker:
>> drivers/infiniband/hw/hns/hns_roce_hw_v1.c:3562 check_qp_db_process_status()
>> warn: inconsistent indenting
>>
>> Signed-off-by: Lijun Ou <oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>> Signed-off-by: Shaobo Xu <xushaobo2-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>> ---
>> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 95 ++++++++++++++++--------------
>> 1 file changed, 51 insertions(+), 44 deletions(-)
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
<lijun_nudt@163.com>, <oulijun@huawei.com>,
<charles.chenxin@huawei.com>, <liuyixian@huawei.com>,
<xushaobo2@huawei.com>, <zhangxiping3@huawei.com>,
<xavier.huwei@tom.com>, <linuxarm@huawei.com>,
<linux-kernel@vger.kernel.org>, <shaobohsu@163.com>
Subject: Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function
Date: Fri, 29 Sep 2017 10:05:04 +0800 [thread overview]
Message-ID: <59CDAA50.60809@huawei.com> (raw)
In-Reply-To: <20170928135014.GY2297@mtr-leonro.local>
On 2017/9/28 21:50, Leon Romanovsky wrote:
> On Thu, Sep 28, 2017 at 12:57:27PM +0800, Wei Hu (Xavier) wrote:
>> From: Lijun Ou <oulijun@huawei.com>
>>
>> It mainly places the lines for checking send doorbell status
>> into a special functions. As a result, we can directly call it in
>> check_qp_db_process_status function and keep consistent indenting
>> style.
>>
>> It fixes: 5f110ac4bed8 ("IB/hns: Fix for checkpatch.pl comment style)
> You forgot " at the end of the line, and there is need to put fixes
> (should be Fixes) in the line before Signed-off-by.
Thanks, Leon
We will modify the statement(Fixes: xx) and put it before signed-off-by
in patch v2.
>> The warning from static checker:
>> drivers/infiniband/hw/hns/hns_roce_hw_v1.c:3562 check_qp_db_process_status()
>> warn: inconsistent indenting
>>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>> Signed-off-by: Shaobo Xu <xushaobo2@huawei.com>
>> ---
>> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 95 ++++++++++++++++--------------
>> 1 file changed, 51 insertions(+), 44 deletions(-)
>>
next prev parent reply other threads:[~2017-09-29 2:05 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 4:57 [PATCH for-next 0/9] Bug fixes & Code improvements in hip06 and hip08 RoCE driver Wei Hu (Xavier)
2017-09-28 4:57 ` Wei Hu (Xavier)
2017-09-28 4:57 ` [PATCH for-next 1/9] RDMA/hns: Modify the value with rd&dest_rd of qp_attr Wei Hu (Xavier)
2017-09-28 4:57 ` Wei Hu (Xavier)
2017-09-28 4:57 ` [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function Wei Hu (Xavier)
2017-09-28 4:57 ` Wei Hu (Xavier)
[not found] ` <1506574654-56699-3-git-send-email-xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-09-28 13:50 ` Leon Romanovsky
2017-09-28 13:50 ` Leon Romanovsky
[not found] ` <20170928135014.GY2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-29 2:05 ` Wei Hu (Xavier) [this message]
2017-09-29 2:05 ` Wei Hu (Xavier)
2017-09-28 4:57 ` [PATCH for-next 4/9] RDMA/hns: Set mask for destination qp field of qp context assignment Wei Hu (Xavier)
2017-09-28 4:57 ` Wei Hu (Xavier)
2017-09-28 4:57 ` [PATCH for-next 5/9] RDMA/hns: Set rdma_ah_attr type for querying qp Wei Hu (Xavier)
2017-09-28 4:57 ` Wei Hu (Xavier)
2017-09-28 4:57 ` [PATCH for-next 7/9] RDMA/hns: Remove unnecessarily calling unregister_inetaddr_notifier function Wei Hu (Xavier)
2017-09-28 4:57 ` Wei Hu (Xavier)
[not found] ` <1506574654-56699-1-git-send-email-xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-09-28 4:57 ` [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp Wei Hu (Xavier)
2017-09-28 4:57 ` Wei Hu (Xavier)
[not found] ` <1506574654-56699-4-git-send-email-xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-09-28 9:13 ` Leon Romanovsky
2017-09-28 9:13 ` Leon Romanovsky
2017-09-28 11:56 ` Wei Hu (Xavier)
2017-09-28 11:56 ` Wei Hu (Xavier)
2017-09-28 12:59 ` Leon Romanovsky
[not found] ` <20170928125912.GU2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-29 6:07 ` Wei Hu (Xavier)
2017-09-29 6:07 ` Wei Hu (Xavier)
[not found] ` <59CDE31A.5090707-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-09-29 10:23 ` Leon Romanovsky
2017-09-29 10:23 ` Leon Romanovsky
[not found] ` <20170929102337.GK2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-29 13:15 ` Wei Hu (Xavier)
2017-09-29 13:15 ` Wei Hu (Xavier)
2017-09-28 4:57 ` [PATCH for-next 6/9] RDMA/hns: Add return statement when checking error in hns_roce_v1_mr_free_work_fn Wei Hu (Xavier)
2017-09-28 4:57 ` Wei Hu (Xavier)
2017-09-28 4:57 ` [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h Wei Hu (Xavier)
2017-09-28 4:57 ` Wei Hu (Xavier)
[not found] ` <1506574654-56699-9-git-send-email-xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-09-28 9:02 ` Leon Romanovsky
2017-09-28 9:02 ` Leon Romanovsky
[not found] ` <20170928090203.GS2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-28 11:56 ` Wei Hu (Xavier)
2017-09-28 11:56 ` Wei Hu (Xavier)
2017-09-28 13:04 ` Leon Romanovsky
[not found] ` <20170928130437.GV2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-28 16:12 ` Wei Hu (Xavier)
2017-09-28 16:12 ` Wei Hu (Xavier)
2017-09-28 4:57 ` [PATCH for-next 9/9] RDMA/hns: Replace usleep_range with udelay when checking command status Wei Hu (Xavier)
2017-09-28 4:57 ` Wei Hu (Xavier)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59CDAA50.60809@huawei.com \
--to=xavier.huwei-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=charles.chenxin-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=lijun_nudt-9Onoh4P/yGk@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=shaobohsu-9Onoh4P/yGk@public.gmane.org \
--cc=xavier.huwei-WVlzvzqoTvw@public.gmane.org \
--cc=xushaobo2-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=zhangxiping3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.