From: Hanjun Guo <guohanjun@huawei.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-acpi@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Hanjun Guo <hanjun.guo@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH 2/3] ACPI/IORT: Improve functions return type/storage class specifier indentation
Date: Tue, 10 Oct 2017 16:03:34 +0800 [thread overview]
Message-ID: <59DC7ED6.50204@huawei.com> (raw)
In-Reply-To: <1507038811-23382-3-git-send-email-lorenzo.pieralisi@arm.com>
On 2017/10/3 21:53, Lorenzo Pieralisi wrote:
> Some functions definition indentations are using a style that is frowned
> upon with return value type/storage class specifier in a separate line.
>
> Reindent the function definitions to fix them.
Shall we fix the functions which guarded with #ifdef CONFIG_IOMMU_API
as well?
Thanks
Hanjun
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Hanjun Guo <hanjun.guo@linaro.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/acpi/arm64/iort.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index 69f21f3..f4775e7 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -88,8 +88,8 @@ static inline int iort_set_fwnode(struct acpi_iort_node *iort_node,
> *
> * Returns: fwnode_handle pointer on success, NULL on failure
> */
> -static inline
> -struct fwnode_handle *iort_get_fwnode(struct acpi_iort_node *node)
> +static inline struct fwnode_handle *iort_get_fwnode(
> + struct acpi_iort_node *node)
> {
> struct iort_fwnode *curr;
> struct fwnode_handle *fwnode = NULL;
> @@ -306,9 +306,8 @@ static int iort_id_map(struct acpi_iort_id_mapping *map, u8 type, u32 rid_in,
> return 0;
> }
>
> -static
> -struct acpi_iort_node *iort_node_get_id(struct acpi_iort_node *node,
> - u32 *id_out, int index)
> +static struct acpi_iort_node *iort_node_get_id(struct acpi_iort_node *node,
> + u32 *id_out, int index)
> {
> struct acpi_iort_node *parent;
> struct acpi_iort_id_mapping *map;
> @@ -392,10 +391,9 @@ static struct acpi_iort_node *iort_node_map_id(struct acpi_iort_node *node,
> return NULL;
> }
>
> -static
> -struct acpi_iort_node *iort_node_map_platform_id(struct acpi_iort_node *node,
> - u32 *id_out, u8 type_mask,
> - int index)
> +static struct acpi_iort_node *iort_node_map_platform_id(
> + struct acpi_iort_node *node, u32 *id_out, u8 type_mask,
> + int index)
> {
> struct acpi_iort_node *parent;
> u32 id;
> @@ -1077,8 +1075,8 @@ static const struct iort_iommu_config iort_arm_smmu_cfg __initconst = {
> .iommu_init_resources = arm_smmu_init_resources
> };
>
> -static __init
> -const struct iort_iommu_config *iort_get_iommu_cfg(struct acpi_iort_node *node)
> +static __init const struct iort_dev_config *iort_get_dev_cfg(
> + struct acpi_iort_node *node)
> {
> switch (node->type) {
> case ACPI_IORT_NODE_SMMU_V3:
WARNING: multiple messages have this Message-ID (diff)
From: guohanjun@huawei.com (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ACPI/IORT: Improve functions return type/storage class specifier indentation
Date: Tue, 10 Oct 2017 16:03:34 +0800 [thread overview]
Message-ID: <59DC7ED6.50204@huawei.com> (raw)
In-Reply-To: <1507038811-23382-3-git-send-email-lorenzo.pieralisi@arm.com>
On 2017/10/3 21:53, Lorenzo Pieralisi wrote:
> Some functions definition indentations are using a style that is frowned
> upon with return value type/storage class specifier in a separate line.
>
> Reindent the function definitions to fix them.
Shall we fix the functions which guarded with #ifdef CONFIG_IOMMU_API
as well?
Thanks
Hanjun
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Hanjun Guo <hanjun.guo@linaro.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/acpi/arm64/iort.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index 69f21f3..f4775e7 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -88,8 +88,8 @@ static inline int iort_set_fwnode(struct acpi_iort_node *iort_node,
> *
> * Returns: fwnode_handle pointer on success, NULL on failure
> */
> -static inline
> -struct fwnode_handle *iort_get_fwnode(struct acpi_iort_node *node)
> +static inline struct fwnode_handle *iort_get_fwnode(
> + struct acpi_iort_node *node)
> {
> struct iort_fwnode *curr;
> struct fwnode_handle *fwnode = NULL;
> @@ -306,9 +306,8 @@ static int iort_id_map(struct acpi_iort_id_mapping *map, u8 type, u32 rid_in,
> return 0;
> }
>
> -static
> -struct acpi_iort_node *iort_node_get_id(struct acpi_iort_node *node,
> - u32 *id_out, int index)
> +static struct acpi_iort_node *iort_node_get_id(struct acpi_iort_node *node,
> + u32 *id_out, int index)
> {
> struct acpi_iort_node *parent;
> struct acpi_iort_id_mapping *map;
> @@ -392,10 +391,9 @@ static struct acpi_iort_node *iort_node_map_id(struct acpi_iort_node *node,
> return NULL;
> }
>
> -static
> -struct acpi_iort_node *iort_node_map_platform_id(struct acpi_iort_node *node,
> - u32 *id_out, u8 type_mask,
> - int index)
> +static struct acpi_iort_node *iort_node_map_platform_id(
> + struct acpi_iort_node *node, u32 *id_out, u8 type_mask,
> + int index)
> {
> struct acpi_iort_node *parent;
> u32 id;
> @@ -1077,8 +1075,8 @@ static const struct iort_iommu_config iort_arm_smmu_cfg __initconst = {
> .iommu_init_resources = arm_smmu_init_resources
> };
>
> -static __init
> -const struct iort_iommu_config *iort_get_iommu_cfg(struct acpi_iort_node *node)
> +static __init const struct iort_dev_config *iort_get_dev_cfg(
> + struct acpi_iort_node *node)
> {
> switch (node->type) {
> case ACPI_IORT_NODE_SMMU_V3:
next prev parent reply other threads:[~2017-10-10 8:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 13:53 [PATCH 0/3] ACPI/IORT: Clean-up/rework for v4.15 Lorenzo Pieralisi
2017-10-03 13:53 ` Lorenzo Pieralisi
2017-10-03 13:53 ` [PATCH 1/3] ACPI/IORT: Remove leftover ACPI_IORT_SMMU_V3_PXM_VALID guard Lorenzo Pieralisi
2017-10-03 13:53 ` Lorenzo Pieralisi
2017-10-10 7:59 ` Hanjun Guo
2017-10-10 7:59 ` Hanjun Guo
2017-10-03 13:53 ` [PATCH 2/3] ACPI/IORT: Improve functions return type/storage class specifier indentation Lorenzo Pieralisi
2017-10-03 13:53 ` Lorenzo Pieralisi
2017-10-10 8:03 ` Hanjun Guo [this message]
2017-10-10 8:03 ` Hanjun Guo
2017-10-10 9:03 ` Hanjun Guo
2017-10-10 9:03 ` Hanjun Guo
2017-10-10 11:17 ` Lorenzo Pieralisi
2017-10-10 11:17 ` Lorenzo Pieralisi
2017-10-10 11:16 ` Lorenzo Pieralisi
2017-10-10 11:16 ` Lorenzo Pieralisi
2017-10-03 13:53 ` [PATCH 3/3] ACPI/IORT: Make platform devices initialization code SMMU agnostic Lorenzo Pieralisi
2017-10-03 13:53 ` Lorenzo Pieralisi
2017-10-10 9:27 ` Hanjun Guo
2017-10-10 9:27 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59DC7ED6.50204@huawei.com \
--to=guohanjun@huawei.com \
--cc=hanjun.guo@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.