From: Hanjun Guo <guohanjun@huawei.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>,
lorenzo.pieralisi@arm.com, hanjun.guo@linaro.org,
sudeep.holla@arm.com, rjw@rjwysocki.net, lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] acpi/arm64: pr_err() strings should end with newlines
Date: Tue, 10 Oct 2017 17:33:50 +0800 [thread overview]
Message-ID: <59DC93FE.2060004@huawei.com> (raw)
In-Reply-To: <d81bee42b06beefa9a7149b5b35bf884836c2595.1506321825.git.arvind.yadav.cs@gmail.com>
On 2017/9/25 15:24, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2:
> Add changelog.
>
> drivers/acpi/arm64/gtdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index 597a737..92f9edf 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -199,7 +199,7 @@ static int __init gtdt_parse_timer_block(struct acpi_gtdt_timer_block *block,
> struct acpi_gtdt_timer_entry *gtdt_frame;
>
> if (!block->timer_count) {
> - pr_err(FW_BUG "GT block present, but frame count is zero.");
> + pr_err(FW_BUG "GT block present, but frame count is zero.\n");
> return -ENODEV;
> }
>
Make sense to me,
Acked-by: Hanjun Guo <hanjun.guo@linaro.org>
Lorenzo, could you pick this up for 4.15?
Thanks
Hanjun
WARNING: multiple messages have this Message-ID (diff)
From: Hanjun Guo <guohanjun@huawei.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>,
<lorenzo.pieralisi@arm.com>, <hanjun.guo@linaro.org>,
<sudeep.holla@arm.com>, <rjw@rjwysocki.net>, <lenb@kernel.org>
Cc: <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] acpi/arm64: pr_err() strings should end with newlines
Date: Tue, 10 Oct 2017 17:33:50 +0800 [thread overview]
Message-ID: <59DC93FE.2060004@huawei.com> (raw)
In-Reply-To: <d81bee42b06beefa9a7149b5b35bf884836c2595.1506321825.git.arvind.yadav.cs@gmail.com>
On 2017/9/25 15:24, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2:
> Add changelog.
>
> drivers/acpi/arm64/gtdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index 597a737..92f9edf 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -199,7 +199,7 @@ static int __init gtdt_parse_timer_block(struct acpi_gtdt_timer_block *block,
> struct acpi_gtdt_timer_entry *gtdt_frame;
>
> if (!block->timer_count) {
> - pr_err(FW_BUG "GT block present, but frame count is zero.");
> + pr_err(FW_BUG "GT block present, but frame count is zero.\n");
> return -ENODEV;
> }
>
Make sense to me,
Acked-by: Hanjun Guo <hanjun.guo@linaro.org>
Lorenzo, could you pick this up for 4.15?
Thanks
Hanjun
next prev parent reply other threads:[~2017-10-10 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 6:45 [PATCH] acpi/arm64: pr_err() strings should end with newlines Arvind Yadav
2017-10-10 9:33 ` Hanjun Guo [this message]
2017-10-10 9:33 ` [PATCH v2] " Hanjun Guo
2017-10-10 10:24 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59DC93FE.2060004@huawei.com \
--to=guohanjun@huawei.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=hanjun.guo@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.