From: jeffy <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Brian Norris
<briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [RESEND PATCH 1/2] spi: rockchip: Convert to late and early system PM callbacks
Date: Sat, 14 Oct 2017 02:25:48 +0800 [thread overview]
Message-ID: <59E1052C.3000503@rock-chips.com> (raw)
In-Reply-To: <59E103B0.8060705-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
On 10/14/2017 02:19 AM, jeffy wrote:
>
>
> it looks like the suspend sequence depends on the dt node sequence, and
> we are putting display-subsystem dt node above spi dt node, so it would
> be earlier in the device list, then got suspended later than spi device.
>
> the pwm backlight and cros_ec_spi pwm are very interesting, not only
> about suspend dependency... if we unbind cros_ec_spi pwm, the pwm
> backlight would still hold a reference to it, and crash the kernel later.
or maybe we should move device_pm_add() from device_add() to driver_bound()?
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: jeffy.chen@rock-chips.com (jeffy)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 1/2] spi: rockchip: Convert to late and early system PM callbacks
Date: Sat, 14 Oct 2017 02:25:48 +0800 [thread overview]
Message-ID: <59E1052C.3000503@rock-chips.com> (raw)
In-Reply-To: <59E103B0.8060705@rock-chips.com>
On 10/14/2017 02:19 AM, jeffy wrote:
>
>
> it looks like the suspend sequence depends on the dt node sequence, and
> we are putting display-subsystem dt node above spi dt node, so it would
> be earlier in the device list, then got suspended later than spi device.
>
> the pwm backlight and cros_ec_spi pwm are very interesting, not only
> about suspend dependency... if we unbind cros_ec_spi pwm, the pwm
> backlight would still hold a reference to it, and crash the kernel later.
or maybe we should move device_pm_add() from device_add() to driver_bound()?
WARNING: multiple messages have this Message-ID (diff)
From: jeffy <jeffy.chen@rock-chips.com>
To: Mark Brown <broonie@kernel.org>, Brian Norris <briannorris@chromium.org>
Cc: Doug Anderson <dianders@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-spi <linux-spi@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [RESEND PATCH 1/2] spi: rockchip: Convert to late and early system PM callbacks
Date: Sat, 14 Oct 2017 02:25:48 +0800 [thread overview]
Message-ID: <59E1052C.3000503@rock-chips.com> (raw)
In-Reply-To: <59E103B0.8060705@rock-chips.com>
On 10/14/2017 02:19 AM, jeffy wrote:
>
>
> it looks like the suspend sequence depends on the dt node sequence, and
> we are putting display-subsystem dt node above spi dt node, so it would
> be earlier in the device list, then got suspended later than spi device.
>
> the pwm backlight and cros_ec_spi pwm are very interesting, not only
> about suspend dependency... if we unbind cros_ec_spi pwm, the pwm
> backlight would still hold a reference to it, and crash the kernel later.
or maybe we should move device_pm_add() from device_add() to driver_bound()?
next prev parent reply other threads:[~2017-10-13 18:25 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 10:41 [RESEND PATCH 0/2] rockchip: kevin: Enable edp display Jeffy Chen
2017-10-13 10:41 ` Jeffy Chen
2017-10-13 10:41 ` Jeffy Chen
2017-10-13 10:41 ` [RESEND PATCH 1/2] spi: rockchip: Convert to late and early system PM callbacks Jeffy Chen
2017-10-13 10:41 ` Jeffy Chen
2017-10-13 15:32 ` Doug Anderson
2017-10-13 15:32 ` Doug Anderson
2017-10-13 15:51 ` Brian Norris
2017-10-13 15:51 ` Brian Norris
[not found] ` <20171013155120.GA137489-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-10-13 16:42 ` Mark Brown
2017-10-13 16:42 ` Mark Brown
2017-10-13 16:42 ` Mark Brown
2017-10-13 18:19 ` jeffy
2017-10-13 18:19 ` jeffy
[not found] ` <59E103B0.8060705-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-10-13 18:25 ` jeffy [this message]
2017-10-13 18:25 ` jeffy
2017-10-13 18:25 ` jeffy
2017-10-13 18:30 ` Dmitry Torokhov
2017-10-13 18:30 ` Dmitry Torokhov
2017-10-13 18:30 ` Dmitry Torokhov
2017-10-13 18:30 ` Dmitry Torokhov
2017-10-13 18:30 ` Dmitry Torokhov
2017-10-13 18:37 ` Mark Brown
2017-10-13 18:37 ` Mark Brown
2017-10-13 18:37 ` Mark Brown
[not found] ` <20171013183750.piabs7m3dnpabnkm-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-10-13 23:45 ` Dmitry Torokhov
2017-10-13 23:45 ` Dmitry Torokhov
2017-10-13 23:45 ` Dmitry Torokhov
2017-10-14 0:15 ` Rafael J. Wysocki
2017-10-14 0:15 ` Rafael J. Wysocki
2017-10-14 0:15 ` Rafael J. Wysocki
[not found] ` <1617641.TtuYKIH8aZ-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org>
2017-10-14 8:59 ` Mark Brown
2017-10-14 8:59 ` Mark Brown
2017-10-14 8:59 ` Mark Brown
2017-10-13 18:44 ` jeffy
2017-10-13 18:44 ` jeffy
2017-10-13 19:01 ` jeffy
2017-10-13 19:01 ` jeffy
2017-10-13 10:41 ` [RESEND PATCH 2/2] arm64: dts: rockchip: Enable edp disaplay on kevin Jeffy Chen
2017-10-13 10:41 ` Jeffy Chen
2017-10-13 13:25 ` Heiko Stuebner
2017-10-13 13:25 ` Heiko Stuebner
2017-10-13 13:42 ` Emil Renner Berthing
2017-10-13 13:42 ` Emil Renner Berthing
2017-10-13 13:42 ` Emil Renner Berthing
2017-10-13 15:15 ` Emil Renner Berthing
2017-10-13 15:15 ` Emil Renner Berthing
2017-10-13 18:12 ` jeffy
2017-10-13 18:12 ` jeffy
[not found] ` <20171013104138.3216-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-10-13 15:34 ` [RESEND PATCH 0/2] rockchip: kevin: Enable edp display Doug Anderson
2017-10-13 15:34 ` Doug Anderson
2017-10-13 15:34 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59E1052C.3000503@rock-chips.com \
--to=jeffy.chen-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
--cc=briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.