All of lore.kernel.org
 help / color / mirror / Atom feed
From: tomjose <tomjose@linux.vnet.ibm.com>
To: Dave Cobbley <david.j.cobbley@linux.intel.com>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>
Cc: chinari@us.ibm.com, Brad Bishop <bradleyb@fuzziesquirrel.com>
Subject: Re: IPMI - get device ID
Date: Fri, 27 Oct 2017 17:22:30 +0530	[thread overview]
Message-ID: <59F31DFE.50809@linux.vnet.ibm.com> (raw)
In-Reply-To: <e1f79a27-ea39-90d5-3cb9-c55f8e1d68ec@linux.intel.com>

Hello Dave,

https://github.com/openbmc/openbmc/issues/495

We had this issue open to fix the hardcoded Product ID, Manufacturing 
ID..etc. Since these fields are IPMI specific, we do not plan to create 
D-Bus properties for that.

The solution we have in mind is to have these values specified in a yaml 
in the openbmc machine specific layer. This gives the advantage that we 
have these values as machine specific and can be taken care at compile 
time. We would add code in phosphor-host-ipmid, to generate code out of 
this yaml file and serve the Get Device ID command.

Dinesh is working on this and he would share the code on gerrit to 
solicit your feedback. Let me know your thoughts.

Regards,
Tom

On Thursday 26 October 2017 10:29 PM, Dave Cobbley wrote:
> I noticed a bit of the get-device-id information in 
> phosphor-ipmi-host/apphandler is hard coded.
>
> Much of this info should be determined at compile time - would the 
> inventory manager be the appropriate place that all platforms under 
> the OpenBMC umbrella would like to store this information?
>
> •   Device ID
> •   Device Revision
> •   IANA
> •   Product ID
> •   Auxiliary
>
> Thanks,
>
> -Dave Cobbley
>

  reply	other threads:[~2017-10-27 11:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26 16:59 IPMI - get device ID Dave Cobbley
2017-10-27 11:52 ` tomjose [this message]
2017-10-27 16:54   ` Dave Cobbley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59F31DFE.50809@linux.vnet.ibm.com \
    --to=tomjose@linux.vnet.ibm.com \
    --cc=bradleyb@fuzziesquirrel.com \
    --cc=chinari@us.ibm.com \
    --cc=david.j.cobbley@linux.intel.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.