IPMI - get device ID

IPMI - get device ID

[Dave Cobbley]

I noticed a bit of the get-device-id information in 
phosphor-ipmi-host/apphandler is hard coded.

Much of this info should be determined at compile time - would the 
inventory manager be the appropriate place that all platforms under the 
OpenBMC umbrella would like to store this information?

•   Device ID
•   Device Revision
•   IANA
•   Product ID
•   Auxiliary

Thanks,

-Dave Cobbley

Re: IPMI - get device ID

[tomjose]

Hello Dave,

https://github.com/openbmc/openbmc/issues/495

We had this issue open to fix the hardcoded Product ID, Manufacturing 
ID..etc. Since these fields are IPMI specific, we do not plan to create 
D-Bus properties for that.

The solution we have in mind is to have these values specified in a yaml 
in the openbmc machine specific layer. This gives the advantage that we 
have these values as machine specific and can be taken care at compile 
time. We would add code in phosphor-host-ipmid, to generate code out of 
this yaml file and serve the Get Device ID command.

Dinesh is working on this and he would share the code on gerrit to 
solicit your feedback. Let me know your thoughts.

Regards,
Tom

On Thursday 26 October 2017 10:29 PM, Dave Cobbley wrote:
> I noticed a bit of the get-device-id information in 
> phosphor-ipmi-host/apphandler is hard coded.
>
> Much of this info should be determined at compile time - would the 
> inventory manager be the appropriate place that all platforms under 
> the OpenBMC umbrella would like to store this information?
>
> •   Device ID
> •   Device Revision
> •   IANA
> •   Product ID
> •   Auxiliary
>
> Thanks,
>
> -Dave Cobbley
>

Re: IPMI - get device ID

[Dave Cobbley]

Sounds great!

Looking forward to seeing the pull request in gerrit.


Thanks,

-Dave


On 10/27/2017 04:52 AM, tomjose wrote:
> Hello Dave,
>
> https://github.com/openbmc/openbmc/issues/495
>
> We had this issue open to fix the hardcoded Product ID, Manufacturing 
> ID..etc. Since these fields are IPMI specific, we do not plan to 
> create D-Bus properties for that.
>
> The solution we have in mind is to have these values specified in a 
> yaml in the openbmc machine specific layer. This gives the advantage 
> that we have these values as machine specific and can be taken care at 
> compile time. We would add code in phosphor-host-ipmid, to generate 
> code out of this yaml file and serve the Get Device ID command.
>
> Dinesh is working on this and he would share the code on gerrit to 
> solicit your feedback. Let me know your thoughts.
>
> Regards,
> Tom
>
> On Thursday 26 October 2017 10:29 PM, Dave Cobbley wrote:
>> I noticed a bit of the get-device-id information in 
>> phosphor-ipmi-host/apphandler is hard coded.
>>
>> Much of this info should be determined at compile time - would the 
>> inventory manager be the appropriate place that all platforms under 
>> the OpenBMC umbrella would like to store this information?
>>
>> •   Device ID
>> •   Device Revision
>> •   IANA
>> •   Product ID
>> •   Auxiliary
>>
>> Thanks,
>>
>> -Dave Cobbley
>>
>