All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guoqing Jiang <gqjiang@suse.com>
To: Shaohua Li <shli@kernel.org>
Cc: jsorensen@fb.com, linux-raid@vger.kernel.org
Subject: Re: [mdadm PATCH] mdadm: make create clustered raid10 possible
Date: Mon, 30 Oct 2017 14:54:21 +0800	[thread overview]
Message-ID: <59F6CC9D.8020206@suse.com> (raw)
In-Reply-To: <20171030055717.x5rgvkymaygitzfn@kernel.org>



On 10/30/2017 01:57 PM, Shaohua Li wrote:
> On Tue, Oct 24, 2017 at 03:31:24PM +0800, Guoqing Jiang wrote:
>> This change to make we can create a clustered
>> raid10 array as well.
>>
>> Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
>> ---
>>   mdadm.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/mdadm.c b/mdadm.c
>> index 7cdcdba7c652..60d80e0103f4 100644
>> --- a/mdadm.c
>> +++ b/mdadm.c
>> @@ -1542,8 +1542,9 @@ int main(int argc, char *argv[])
>>   				break;
>>   			}
>>   
>> -			if (s.level != 1) {
>> -				pr_err("--bitmap=clustered is currently supported with RAID mirror only\n");
>> +			if (s.level != 1 && s.level != 10) {
>> +				pr_err("--bitmap=clustered is currently "
>> +				       "supported with raid1/10 only\n");
>>   				rv = 1;
>>   				break;
> Since kernel only supports near layout for raid10 cluster, probably check the
> layout in mdadm too?

The changes in raid10_run has ensured only near layout is possible for 
clustered raid10.
Anyway, I will add the check either.

Thanks,
Guoqing

      reply	other threads:[~2017-10-30  6:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24  7:31 [mdadm PATCH] mdadm: make create clustered raid10 possible Guoqing Jiang
2017-10-24 20:05 ` NeilBrown
2017-10-24 20:09   ` Jes Sorensen
2017-10-30  5:57 ` Shaohua Li
2017-10-30  6:54   ` Guoqing Jiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59F6CC9D.8020206@suse.com \
    --to=gqjiang@suse.com \
    --cc=jsorensen@fb.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.