Re: [mdadm PATCH] mdadm: make create clustered raid10 possible

[NeilBrown <neilb@suse.com>]

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

On Tue, Oct 24 2017, Guoqing Jiang wrote:

> This change to make we can create a clustered
> raid10 array as well.
>
> Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
> ---
>  mdadm.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mdadm.c b/mdadm.c
> index 7cdcdba7c652..60d80e0103f4 100644
> --- a/mdadm.c
> +++ b/mdadm.c
> @@ -1542,8 +1542,9 @@ int main(int argc, char *argv[])
>  				break;
>  			}
>  
> -			if (s.level != 1) {
> -				pr_err("--bitmap=clustered is currently supported with RAID mirror only\n");
> +			if (s.level != 1 && s.level != 10) {
> +				pr_err("--bitmap=clustered is currently "
> +				       "supported with raid1/10 only\n");


Please don't wrap strings.  It makes it hard to search for them.
Long line might be bad, but wrapped strings are worse.

Thanks,
NeilBrown


>  				rv = 1;
>  				break;
>  			}
> -- 
> 2.10.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]