All of lore.kernel.org
 help / color / mirror / Atom feed
From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "David Airlie" <airlied@linux.ie>,
	kernel-janitors@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	"Dmytro Laktyushkin" <Dmytro.Laktyushkin@amd.com>,
	"Hersen Wu" <hersenxs.wu@amd.com>,
	dri-devel@lists.freedesktop.org,
	"Yue Hin Lau" <Yuehin.Lau@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Tony Cheng" <tony.cheng@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: indent an if statement
Date: Sat, 04 Nov 2017 10:16:23 +0100	[thread overview]
Message-ID: <59FD8567.4030500@bfs.de> (raw)
In-Reply-To: <20171104061232.5bq5hwr2p2ca2cl7@mwanda>



Am 04.11.2017 07:12, schrieb Dan Carpenter:
> The if statement wasn't indented so it makes static analysis tools and
> probably very recent GCC versions complain.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I went over 80 characters because other lines do already and it seemed
> like the cleanest thing here.
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
> index d911590d08bc..c83ac4d9ca3a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
> @@ -727,7 +727,7 @@ static void destruct(struct dcn10_resource_pool *pool)
>  
>  	for (i = 0; i < pool->base.stream_enc_count; i++) {
>  		if (pool->base.stream_enc[i] != NULL)
> -		kfree(DCE110STRENC_FROM_STRENC(pool->base.stream_enc[i]));
> +			kfree(DCE110STRENC_FROM_STRENC(pool->base.stream_enc[i]));
>  	}
>  

Is that "if (pool->base.stream_enc[i] != NULL)" needed at all ?
kfree() should happily handle NULL.

re,
 wh



>  	for (i = 0; i < pool->base.audio_count; i++) {
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "David Airlie" <airlied@linux.ie>,
	kernel-janitors@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	"Dmytro Laktyushkin" <Dmytro.Laktyushkin@amd.com>,
	"Hersen Wu" <hersenxs.wu@amd.com>,
	dri-devel@lists.freedesktop.org,
	"Yue Hin Lau" <Yuehin.Lau@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Tony Cheng" <tony.cheng@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: indent an if statement
Date: Sat, 04 Nov 2017 09:16:23 +0000	[thread overview]
Message-ID: <59FD8567.4030500@bfs.de> (raw)
In-Reply-To: <20171104061232.5bq5hwr2p2ca2cl7@mwanda>



Am 04.11.2017 07:12, schrieb Dan Carpenter:
> The if statement wasn't indented so it makes static analysis tools and
> probably very recent GCC versions complain.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I went over 80 characters because other lines do already and it seemed
> like the cleanest thing here.
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
> index d911590d08bc..c83ac4d9ca3a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
> @@ -727,7 +727,7 @@ static void destruct(struct dcn10_resource_pool *pool)
>  
>  	for (i = 0; i < pool->base.stream_enc_count; i++) {
>  		if (pool->base.stream_enc[i] != NULL)
> -		kfree(DCE110STRENC_FROM_STRENC(pool->base.stream_enc[i]));
> +			kfree(DCE110STRENC_FROM_STRENC(pool->base.stream_enc[i]));
>  	}
>  

Is that "if (pool->base.stream_enc[i] != NULL)" needed at all ?
kfree() should happily handle NULL.

re,
 wh



>  	for (i = 0; i < pool->base.audio_count; i++) {
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2017-11-04  9:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-04  6:12 [PATCH] drm/amd/display: indent an if statement Dan Carpenter
2017-11-04  6:12 ` Dan Carpenter
2017-11-04  9:16 ` walter harms [this message]
2017-11-04  9:16   ` walter harms
     [not found]   ` <59FD8567.4030500-fPG8STNUNVg@public.gmane.org>
2017-11-04 10:07     ` Christian König
2017-11-04 10:07       ` Christian König
2017-11-06  7:07       ` [PATCH] drm/amd/display: small cleanup in destruct() Dan Carpenter
2017-11-06  7:07         ` Dan Carpenter
2017-11-06  8:44         ` Christian König
2017-11-06  8:44           ` Christian König
2017-11-06 21:29           ` Alex Deucher
2017-11-06 21:29             ` Alex Deucher
2017-11-06  6:42   ` [PATCH] drm/amd/display: indent an if statement Dan Carpenter
2017-11-06  6:42     ` Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2018-08-14  9:09 Dan Carpenter
2018-08-14  9:09 ` Dan Carpenter
     [not found] ` <20180814090944.qjm4vxyrjdqxu4d7-vMlZ3nK25oGAIHFoDFOv9A@public.gmane.org>
2018-08-21 18:51   ` Harry Wentland
2018-08-21 18:51     ` Harry Wentland
2020-08-03 14:35 [PATCH] drm/amd/display: Indent " Dan Carpenter
2020-08-03 14:35 ` Dan Carpenter
2020-08-04 20:33 ` Alex Deucher
2020-08-04 20:33   ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59FD8567.4030500@bfs.de \
    --to=wharms@bfs.de \
    --cc=Dmytro.Laktyushkin@amd.com \
    --cc=Yuehin.Lau@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hersenxs.wu@amd.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=tony.cheng@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.