All of lore.kernel.org
 help / color / mirror / Atom feed
From: Macpaul Lin via iommu <iommu@lists.linux-foundation.org>
To: Yong Wu <yong.wu@mediatek.com>, Fabien Parent <fparent@baylibre.com>
Cc: devicetree@vger.kernel.org,
	Kidd-KW Chen <Kidd-KW.Chen@mediatek.com>,
	Macross Chen <macross.chen@mediatek.com>,
	linux-kernel@vger.kernel.org, Bear Wang <bear.wang@mediatek.com>,
	iommu@lists.linux-foundation.org,
	Rob Herring <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Andy Hsieh <Andy.Hsieh@mediatek.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Will Deacon <will@kernel.org>, Pablo Sun <pablo.sun@mediatek.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: iommu: mediatek: add binding documentation for MT8365 SoC
Date: Thu, 2 Jun 2022 16:27:45 +0800	[thread overview]
Message-ID: <59cedd50-4141-e589-11ae-b8d1a017eb46@mediatek.com> (raw)
In-Reply-To: <8ac7a6766c635412b408cb5295ddb3da37541140.camel@mediatek.com>


[-- Attachment #1.1: Type: text/html, Size: 3489 bytes --]

[-- Attachment #1.2: Type: text/plain, Size: 1634 bytes --]

On 6/2/22 2:18 PM, Yong Wu wrote:
> On Mon, 2022-05-30 at 20:03 +0200, Fabien Parent wrote:
>> Add IOMMU binding documentation for the MT8365 SoC.
>>
>> Signed-off-by: Fabien Parent <fparent@baylibre.com>
>> ---
>>   .../bindings/iommu/mediatek,iommu.yaml        |  2 +
>>   include/dt-bindings/memory/mt8365-larb-port.h | 96
>> +++++++++++++++++++
>>   2 files changed, 98 insertions(+)
>>   create mode 100644 include/dt-bindings/memory/mt8365-larb-port.h
> 
> [snip...]
> 
>> +#ifndef _DT_BINDINGS_MEMORY_MT8365_LARB_PORT_H_
>> +#define _DT_BINDINGS_MEMORY_MT8365_LARB_PORT_H_
>> +
>> +#include <dt-bindings/memory/mtk-memory-port.h>
>> +
>> +#define M4U_LARB0_ID			0
>> +#define M4U_LARB1_ID			1
>> +#define M4U_LARB2_ID			2
>> +#define M4U_LARB3_ID			3
>> +#define M4U_LARB4_ID			4
>> +#define M4U_LARB5_ID			5
>> +#define M4U_LARB6_ID			6
>> +#define M4U_LARB7_ID			7
> 
> Remove these. they are no used, right?

AIOT and customers are using the modules and their related IOMMU modules.
DISP0, VENC, VDEC, ISP (CAMSYS), and APU (as far as I know, which should 
be VP6?) were all supported.

> 
>> +
>> +/* larb0 */
>> +#define M4U_PORT_DISP_OVL0		MTK_M4U_ID(0, 0)
>> +#define M4U_PORT_DISP_OVL0_2L	MTK_M4U_ID(0, 1)
> 
> [...]
> 
>>
>> +/* larb4 */
>> +#define M4U_PORT_APU_READ		MTK_M4U_ID(0, 0)
>> +#define M4U_PORT_APU_WRITE		MTK_M4U_ID(0, 1)
> 
> Please remove these two APU definitions. currently these are not
> supported.

Kidd, please help to check if APU use these definitions with Yong.
However, I think these are all available to the customers.

Thanks
Macpaul Lin

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Yong Wu <yong.wu@mediatek.com>, Fabien Parent <fparent@baylibre.com>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	<iommu@lists.linux-foundation.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Bear Wang <bear.wang@mediatek.com>,
	Macross Chen <macross.chen@mediatek.com>,
	Kidd-KW Chen <Kidd-KW.Chen@mediatek.com>,
	Andy Hsieh <Andy.Hsieh@mediatek.com>,
	Pablo Sun <pablo.sun@mediatek.com>
Subject: Re: [PATCH 1/3] dt-bindings: iommu: mediatek: add binding documentation for MT8365 SoC
Date: Thu, 2 Jun 2022 16:27:45 +0800	[thread overview]
Message-ID: <59cedd50-4141-e589-11ae-b8d1a017eb46@mediatek.com> (raw)
In-Reply-To: <8ac7a6766c635412b408cb5295ddb3da37541140.camel@mediatek.com>

On 6/2/22 2:18 PM, Yong Wu wrote:
> On Mon, 2022-05-30 at 20:03 +0200, Fabien Parent wrote:
>> Add IOMMU binding documentation for the MT8365 SoC.
>>
>> Signed-off-by: Fabien Parent <fparent@baylibre.com>
>> ---
>>   .../bindings/iommu/mediatek,iommu.yaml        |  2 +
>>   include/dt-bindings/memory/mt8365-larb-port.h | 96
>> +++++++++++++++++++
>>   2 files changed, 98 insertions(+)
>>   create mode 100644 include/dt-bindings/memory/mt8365-larb-port.h
> 
> [snip...]
> 
>> +#ifndef _DT_BINDINGS_MEMORY_MT8365_LARB_PORT_H_
>> +#define _DT_BINDINGS_MEMORY_MT8365_LARB_PORT_H_
>> +
>> +#include <dt-bindings/memory/mtk-memory-port.h>
>> +
>> +#define M4U_LARB0_ID			0
>> +#define M4U_LARB1_ID			1
>> +#define M4U_LARB2_ID			2
>> +#define M4U_LARB3_ID			3
>> +#define M4U_LARB4_ID			4
>> +#define M4U_LARB5_ID			5
>> +#define M4U_LARB6_ID			6
>> +#define M4U_LARB7_ID			7
> 
> Remove these. they are no used, right?

AIOT and customers are using the modules and their related IOMMU modules.
DISP0, VENC, VDEC, ISP (CAMSYS), and APU (as far as I know, which should 
be VP6?) were all supported.

> 
>> +
>> +/* larb0 */
>> +#define M4U_PORT_DISP_OVL0		MTK_M4U_ID(0, 0)
>> +#define M4U_PORT_DISP_OVL0_2L	MTK_M4U_ID(0, 1)
> 
> [...]
> 
>>
>> +/* larb4 */
>> +#define M4U_PORT_APU_READ		MTK_M4U_ID(0, 0)
>> +#define M4U_PORT_APU_WRITE		MTK_M4U_ID(0, 1)
> 
> Please remove these two APU definitions. currently these are not
> supported.

Kidd, please help to check if APU use these definitions with Yong.
However, I think these are all available to the customers.

Thanks
Macpaul Lin

  reply	other threads:[~2022-06-02  9:23 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-30 18:03 [PATCH 1/3] dt-bindings: iommu: mediatek: add binding documentation for MT8365 SoC Fabien Parent
2022-05-30 18:03 ` Fabien Parent
2022-05-30 18:03 ` Fabien Parent
2022-05-30 18:03 ` Fabien Parent
2022-05-30 18:03 ` [PATCH 2/3] iommu: mtk_iommu: add support for 6-bit encoded port IDs Fabien Parent
2022-05-30 18:03   ` Fabien Parent
2022-05-30 18:03   ` Fabien Parent
2022-05-30 18:03   ` Fabien Parent
2022-06-02  6:18   ` Yong Wu via iommu
2022-06-02  6:18     ` Yong Wu
2022-06-02  6:18     ` Yong Wu
2022-06-02  6:18     ` Yong Wu
2022-05-30 18:03 ` [PATCH 3/3] iommu: mtk_iommu: add support for MT8365 SoC Fabien Parent
2022-05-30 18:03   ` Fabien Parent
2022-05-30 18:03   ` Fabien Parent
2022-05-30 18:03   ` Fabien Parent
2022-07-20  8:52   ` Amjad Ouled-Ameur
2022-07-20  8:52     ` Amjad Ouled-Ameur
2022-06-02  6:18 ` [PATCH 1/3] dt-bindings: iommu: mediatek: add binding documentation " Yong Wu via iommu
2022-06-02  6:18   ` Yong Wu
2022-06-02  6:18   ` Yong Wu
2022-06-02  6:18   ` Yong Wu
2022-06-02  8:27   ` Macpaul Lin via iommu [this message]
2022-06-02  8:27     ` Macpaul Lin
2022-06-02  8:42     ` Macpaul Lin via iommu
2022-06-02  8:42       ` Macpaul Lin
2022-06-02  9:26       ` Yong Wu via iommu
2022-06-02  9:26         ` Yong Wu
2022-06-02  9:26         ` Yong Wu
2022-06-02  9:26         ` Yong Wu
2022-06-05 21:13 ` Rob Herring
2022-06-05 21:13   ` Rob Herring
2022-06-05 21:13   ` Rob Herring
2022-06-05 21:13   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59cedd50-4141-e589-11ae-b8d1a017eb46@mediatek.com \
    --to=iommu@lists.linux-foundation.org \
    --cc=Andy.Hsieh@mediatek.com \
    --cc=Kidd-KW.Chen@mediatek.com \
    --cc=bear.wang@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fparent@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=macpaul.lin@mediatek.com \
    --cc=macross.chen@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=pablo.sun@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=will@kernel.org \
    --cc=yong.wu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.