From: Chanwoo Choi <cw00.choi@samsung.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
kernel-janitors@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] extcon: max8997: Delete an unnecessary variable initialisation in max8997_muic_set_path(
Date: Thu, 09 Nov 2017 09:16:15 +0000 [thread overview]
Message-ID: <5A041CDF.1030504@samsung.com> (raw)
In-Reply-To: <e24dddc4-6be6-0ffd-ca58-979fa91b77c6@users.sourceforge.net>
Hi,
On 2017년 11월 09일 18:05, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 9 Nov 2017 10:00:08 +0100
>
> The variable "ret" will be set to an appropriate value a bit later.
> Thus omit the explicit initialisation at the beginning.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/extcon/extcon-max8997.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index 8152790d72e1..9f30f4929b72 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -204,7 +204,7 @@ static int max8997_muic_set_debounce_time(struct max8997_muic_info *info,
> static int max8997_muic_set_path(struct max8997_muic_info *info,
> u8 val, bool attached)
> {
> - int ret = 0;
> + int ret;
> u8 ctrl1, ctrl2 = 0;
>
> if (attached)
>
Applied it.
But, it will be merged to v4.16-rc1.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
kernel-janitors@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] extcon: max8997: Delete an unnecessary variable initialisation in max8997_muic_set_path()
Date: Thu, 09 Nov 2017 18:16:15 +0900 [thread overview]
Message-ID: <5A041CDF.1030504@samsung.com> (raw)
In-Reply-To: <e24dddc4-6be6-0ffd-ca58-979fa91b77c6@users.sourceforge.net>
Hi,
On 2017년 11월 09일 18:05, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 9 Nov 2017 10:00:08 +0100
>
> The variable "ret" will be set to an appropriate value a bit later.
> Thus omit the explicit initialisation at the beginning.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/extcon/extcon-max8997.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index 8152790d72e1..9f30f4929b72 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -204,7 +204,7 @@ static int max8997_muic_set_debounce_time(struct max8997_muic_info *info,
> static int max8997_muic_set_path(struct max8997_muic_info *info,
> u8 val, bool attached)
> {
> - int ret = 0;
> + int ret;
> u8 ctrl1, ctrl2 = 0;
>
> if (attached)
>
Applied it.
But, it will be merged to v4.16-rc1.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2017-11-09 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171109090556epcas1p265558b4f87c887533655517a23e59e21@epcas1p2.samsung.com>
2017-11-09 9:05 ` [PATCH] extcon: max8997: Delete an unnecessary variable initialisation in max8997_muic_set_path() SF Markus Elfring
2017-11-09 9:05 ` SF Markus Elfring
2017-11-09 9:16 ` Chanwoo Choi [this message]
2017-11-09 9:16 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A041CDF.1030504@samsung.com \
--to=cw00.choi@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.