From: alex chen <alex.chen@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2/dlm: clean dead code up
Date: Fri, 24 Nov 2017 13:57:56 +0800 [thread overview]
Message-ID: <5A17B4E4.4060703@huawei.com> (raw)
In-Reply-To: <63ADC13FD55D6546B7DECE290D39E373CED7EF9E@H3CMLB14-EX.srv.huawei-3com.com>
It looks good to me.
On 2017/11/24 13:30, Changwei Ge wrote:
> This code snippet is no longer used. So trim it, thus to make code neat.
>
> Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
Reviewed-by: Alex Chen <alex.chen@huawei.com>
> ---
> fs/ocfs2/dlm/dlmmaster.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
> index 3e04279446e8..93b61c6c409e 100644
> --- a/fs/ocfs2/dlm/dlmmaster.c
> +++ b/fs/ocfs2/dlm/dlmmaster.c
> @@ -1122,13 +1122,6 @@ static int dlm_wait_for_lock_mastery(struct
> dlm_ctxt *dlm,
> /* sleep if we haven't finished voting yet */
> if (sleep) {
> unsigned long timeo = msecs_to_jiffies(DLM_MASTERY_TIMEOUT_MS);
> -
> - /*
> - if (kref_read(&mle->mle_refs) < 2)
> - mlog(ML_ERROR, "mle (%p) refs=%d, name=%.*s\n", mle,
> - kref_read(&mle->mle_refs),
> - res->lockname.len, res->lockname.name);
> - */
> atomic_set(&mle->woken, 0);
> (void)wait_event_timeout(mle->wq,
> (atomic_read(&mle->woken) == 1),
>
prev parent reply other threads:[~2017-11-24 5:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 5:30 [Ocfs2-devel] [PATCH] ocfs2/dlm: clean dead code up Changwei Ge
2017-11-24 5:57 ` alex chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A17B4E4.4060703@huawei.com \
--to=alex.chen@huawei.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.