* [Ocfs2-devel] [PATCH] ocfs2/dlm: clean dead code up
@ 2017-11-24 5:30 Changwei Ge
2017-11-24 5:57 ` alex chen
0 siblings, 1 reply; 2+ messages in thread
From: Changwei Ge @ 2017-11-24 5:30 UTC (permalink / raw)
To: ocfs2-devel
This code snippet is no longer used. So trim it, thus to make code neat.
Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
---
fs/ocfs2/dlm/dlmmaster.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
index 3e04279446e8..93b61c6c409e 100644
--- a/fs/ocfs2/dlm/dlmmaster.c
+++ b/fs/ocfs2/dlm/dlmmaster.c
@@ -1122,13 +1122,6 @@ static int dlm_wait_for_lock_mastery(struct
dlm_ctxt *dlm,
/* sleep if we haven't finished voting yet */
if (sleep) {
unsigned long timeo = msecs_to_jiffies(DLM_MASTERY_TIMEOUT_MS);
-
- /*
- if (kref_read(&mle->mle_refs) < 2)
- mlog(ML_ERROR, "mle (%p) refs=%d, name=%.*s\n", mle,
- kref_read(&mle->mle_refs),
- res->lockname.len, res->lockname.name);
- */
atomic_set(&mle->woken, 0);
(void)wait_event_timeout(mle->wq,
(atomic_read(&mle->woken) == 1),
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2/dlm: clean dead code up
2017-11-24 5:30 [Ocfs2-devel] [PATCH] ocfs2/dlm: clean dead code up Changwei Ge
@ 2017-11-24 5:57 ` alex chen
0 siblings, 0 replies; 2+ messages in thread
From: alex chen @ 2017-11-24 5:57 UTC (permalink / raw)
To: ocfs2-devel
It looks good to me.
On 2017/11/24 13:30, Changwei Ge wrote:
> This code snippet is no longer used. So trim it, thus to make code neat.
>
> Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
Reviewed-by: Alex Chen <alex.chen@huawei.com>
> ---
> fs/ocfs2/dlm/dlmmaster.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
> index 3e04279446e8..93b61c6c409e 100644
> --- a/fs/ocfs2/dlm/dlmmaster.c
> +++ b/fs/ocfs2/dlm/dlmmaster.c
> @@ -1122,13 +1122,6 @@ static int dlm_wait_for_lock_mastery(struct
> dlm_ctxt *dlm,
> /* sleep if we haven't finished voting yet */
> if (sleep) {
> unsigned long timeo = msecs_to_jiffies(DLM_MASTERY_TIMEOUT_MS);
> -
> - /*
> - if (kref_read(&mle->mle_refs) < 2)
> - mlog(ML_ERROR, "mle (%p) refs=%d, name=%.*s\n", mle,
> - kref_read(&mle->mle_refs),
> - res->lockname.len, res->lockname.name);
> - */
> atomic_set(&mle->woken, 0);
> (void)wait_event_timeout(mle->wq,
> (atomic_read(&mle->woken) == 1),
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-24 5:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-24 5:30 [Ocfs2-devel] [PATCH] ocfs2/dlm: clean dead code up Changwei Ge
2017-11-24 5:57 ` alex chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.