From: arvindY <arvind.yadav.cs@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
knaack.h@gmx.de, pmeerw@pmeerw.net, samuel@sortiz.org,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: irda: Handle return value of platform_get_irq
Date: Thu, 30 Nov 2017 22:15:19 +0530 [thread overview]
Message-ID: <5A20359F.10508@gmail.com> (raw)
In-Reply-To: <20171130164124.GB17869@kroah.com>
Hi Greg,
On Thursday 30 November 2017 10:11 PM, Greg KH wrote:
> On Thu, Nov 30, 2017 at 09:13:35PM +0530, Arvind Yadav wrote:
>> platform_get_irq() can fail here and we must check its return value.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>> drivers/staging/irda/drivers/pxaficp_ir.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
> Did you read drivers/staging/irda/TODO?
Sorry, Now I have read it. :(
>
> thanks,
>
> greg k-h
Thanks,
~arvind
WARNING: multiple messages have this Message-ID (diff)
From: arvindY <arvind.yadav.cs@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, lars@metafoo.de,
Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
samuel@sortiz.org, pmeerw@pmeerw.net, knaack.h@gmx.de,
jic23@kernel.org
Subject: Re: [PATCH 2/3] staging: irda: Handle return value of platform_get_irq
Date: Thu, 30 Nov 2017 22:15:19 +0530 [thread overview]
Message-ID: <5A20359F.10508@gmail.com> (raw)
In-Reply-To: <20171130164124.GB17869@kroah.com>
Hi Greg,
On Thursday 30 November 2017 10:11 PM, Greg KH wrote:
> On Thu, Nov 30, 2017 at 09:13:35PM +0530, Arvind Yadav wrote:
>> platform_get_irq() can fail here and we must check its return value.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>> drivers/staging/irda/drivers/pxaficp_ir.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
> Did you read drivers/staging/irda/TODO?
Sorry, Now I have read it. :(
>
> thanks,
>
> greg k-h
Thanks,
~arvind
next prev parent reply other threads:[~2017-11-30 16:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 15:43 [PATCH 0/3] Handle return value of platform_get_irq Arvind Yadav
2017-11-30 15:43 ` Arvind Yadav
2017-11-30 15:43 ` [PATCH 1/3] iio: trigger: Fix platform_get_irq's error checking Arvind Yadav
2017-11-30 15:43 ` Arvind Yadav
2017-12-02 12:22 ` Jonathan Cameron
2017-12-02 12:22 ` Jonathan Cameron
2017-11-30 15:43 ` [PATCH 2/3] staging: irda: Handle return value of platform_get_irq Arvind Yadav
2017-11-30 15:43 ` Arvind Yadav
2017-11-30 16:41 ` Greg KH
2017-11-30 16:45 ` arvindY [this message]
2017-11-30 16:45 ` arvindY
2017-11-30 15:43 ` [PATCH 3/3] staging: irda: Remove unnecessary 'err' initialization Arvind Yadav
2017-11-30 15:43 ` Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A20359F.10508@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.