* [Ocfs2-devel] [PATCH] ocfs2/cluster: neaten a member of o2net_msg_handler
@ 2017-12-05 5:47 Changwei Ge
2017-12-05 7:58 ` alex chen
2017-12-05 8:20 ` Joseph Qi
0 siblings, 2 replies; 3+ messages in thread
From: Changwei Ge @ 2017-12-05 5:47 UTC (permalink / raw)
To: ocfs2-devel
It's odd that o2net_msg_handler::nh_func_data is declared as type
o2net_msg_handler_func*.
So neaten it.
Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
---
fs/ocfs2/cluster/tcp_internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/cluster/tcp_internal.h
b/fs/ocfs2/cluster/tcp_internal.h
index b95e7df5b76a..0276f7f8d5e6 100644
--- a/fs/ocfs2/cluster/tcp_internal.h
+++ b/fs/ocfs2/cluster/tcp_internal.h
@@ -196,7 +196,7 @@ struct o2net_msg_handler {
u32 nh_msg_type;
u32 nh_key;
o2net_msg_handler_func *nh_func;
- o2net_msg_handler_func *nh_func_data;
+ void *nh_func_data;
o2net_post_msg_handler_func
*nh_post_func;
struct kref nh_kref;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2/cluster: neaten a member of o2net_msg_handler
2017-12-05 5:47 [Ocfs2-devel] [PATCH] ocfs2/cluster: neaten a member of o2net_msg_handler Changwei Ge
@ 2017-12-05 7:58 ` alex chen
2017-12-05 8:20 ` Joseph Qi
1 sibling, 0 replies; 3+ messages in thread
From: alex chen @ 2017-12-05 7:58 UTC (permalink / raw)
To: ocfs2-devel
Hi Changwei,
Thank you for your patch.
On 2017/12/5 13:47, Changwei Ge wrote:
> It's odd that o2net_msg_handler::nh_func_data is declared as type
> o2net_msg_handler_func*.
> So neaten it.
>
> Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
Reviewed-by: Alex Chen <alex.chen@huawei.com>
> ---
> fs/ocfs2/cluster/tcp_internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/cluster/tcp_internal.h
> b/fs/ocfs2/cluster/tcp_internal.h
> index b95e7df5b76a..0276f7f8d5e6 100644
> --- a/fs/ocfs2/cluster/tcp_internal.h
> +++ b/fs/ocfs2/cluster/tcp_internal.h
> @@ -196,7 +196,7 @@ struct o2net_msg_handler {
> u32 nh_msg_type;
> u32 nh_key;
> o2net_msg_handler_func *nh_func;
> - o2net_msg_handler_func *nh_func_data;
> + void *nh_func_data;
> o2net_post_msg_handler_func
> *nh_post_func;
> struct kref nh_kref;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2/cluster: neaten a member of o2net_msg_handler
2017-12-05 5:47 [Ocfs2-devel] [PATCH] ocfs2/cluster: neaten a member of o2net_msg_handler Changwei Ge
2017-12-05 7:58 ` alex chen
@ 2017-12-05 8:20 ` Joseph Qi
1 sibling, 0 replies; 3+ messages in thread
From: Joseph Qi @ 2017-12-05 8:20 UTC (permalink / raw)
To: ocfs2-devel
On 17/12/5 13:47, Changwei Ge wrote:
> It's odd that o2net_msg_handler::nh_func_data is declared as type
> o2net_msg_handler_func*.
> So neaten it.
>
> Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
Reviewed-by: Joseph Qi <jiangqi903@gmail.com>
> ---
> fs/ocfs2/cluster/tcp_internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/cluster/tcp_internal.h
> b/fs/ocfs2/cluster/tcp_internal.h
> index b95e7df5b76a..0276f7f8d5e6 100644
> --- a/fs/ocfs2/cluster/tcp_internal.h
> +++ b/fs/ocfs2/cluster/tcp_internal.h
> @@ -196,7 +196,7 @@ struct o2net_msg_handler {
> u32 nh_msg_type;
> u32 nh_key;
> o2net_msg_handler_func *nh_func;
> - o2net_msg_handler_func *nh_func_data;
> + void *nh_func_data;
> o2net_post_msg_handler_func
> *nh_post_func;
> struct kref nh_kref;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-05 8:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-05 5:47 [Ocfs2-devel] [PATCH] ocfs2/cluster: neaten a member of o2net_msg_handler Changwei Ge
2017-12-05 7:58 ` alex chen
2017-12-05 8:20 ` Joseph Qi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.