From: JeffyChen <jeffy.chen@rock-chips.com>
To: Robin Murphy <robin.murphy@arm.com>, linux-kernel@vger.kernel.org
Cc: jcliang@chromium.org, tfiga@chromium.org,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
iommu@lists.linux-foundation.org, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/9] iommu/rockchip: Fix error handling in attach
Date: Fri, 12 Jan 2018 08:33:17 +0800 [thread overview]
Message-ID: <5A58024D.2010402@rock-chips.com> (raw)
In-Reply-To: <427ecf29-2024-b746-c567-903c1ce02e75@arm.com>
Hi Robin,
thanks for your reply.
On 01/11/2018 11:47 PM, Robin Murphy wrote:
>>
>> + for (i = 0; i < iommu->num_irq; i++) {
>> + ret = devm_request_irq(iommu->dev, iommu->irq[i], rk_iommu_irq,
>> + IRQF_SHARED, dev_name(dev), iommu);
>
> Why aren't we simply requesting the IRQ once in rk_iommu_probe()? Given
> that the hardware doesn't handle multiple translation contexts, there
> doesn't seem to be much point in being this dynamic about it.
>
it make sense, will do it in next version:)
> Robin.
WARNING: multiple messages have this Message-ID (diff)
From: jeffy.chen@rock-chips.com (JeffyChen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] iommu/rockchip: Fix error handling in attach
Date: Fri, 12 Jan 2018 08:33:17 +0800 [thread overview]
Message-ID: <5A58024D.2010402@rock-chips.com> (raw)
In-Reply-To: <427ecf29-2024-b746-c567-903c1ce02e75@arm.com>
Hi Robin,
thanks for your reply.
On 01/11/2018 11:47 PM, Robin Murphy wrote:
>>
>> + for (i = 0; i < iommu->num_irq; i++) {
>> + ret = devm_request_irq(iommu->dev, iommu->irq[i], rk_iommu_irq,
>> + IRQF_SHARED, dev_name(dev), iommu);
>
> Why aren't we simply requesting the IRQ once in rk_iommu_probe()? Given
> that the hardware doesn't handle multiple translation contexts, there
> doesn't seem to be much point in being this dynamic about it.
>
it make sense, will do it in next version:)
> Robin.
next prev parent reply other threads:[~2018-01-12 0:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 8:22 [PATCH 0/9] iommu/rockchip: Use OF_IOMMU Jeffy Chen
2018-01-11 8:22 ` Jeffy Chen
2018-01-11 8:22 ` [PATCH 1/9] iommu/of: Drop early initialisation hooks Jeffy Chen
2018-01-11 8:22 ` Jeffy Chen
[not found] ` <20180111082229.24011-2-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-11 9:40 ` Marek Szyprowski
2018-01-11 9:40 ` Marek Szyprowski
2018-01-11 9:40 ` Marek Szyprowski
[not found] ` <60fdd375-ca74-0fea-c598-39a68b9e7735-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2018-01-11 11:14 ` JeffyChen
2018-01-11 11:14 ` JeffyChen
2018-01-11 11:14 ` JeffyChen
[not found] ` <5A57471E.7020304-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-11 12:24 ` Robin Murphy
2018-01-11 12:24 ` Robin Murphy
2018-01-11 12:24 ` Robin Murphy
[not found] ` <faeccc75-79e9-ddb6-446d-88ab63fe4e1f-5wv7dgnIgG8@public.gmane.org>
2018-01-12 1:22 ` JeffyChen
2018-01-12 1:22 ` JeffyChen
2018-01-12 1:22 ` JeffyChen
2018-01-11 12:26 ` Marek Szyprowski
2018-01-11 12:26 ` Marek Szyprowski
2018-01-11 8:22 ` [PATCH 2/9] iommu/rockchip: Fix error handling in attach Jeffy Chen
2018-01-11 8:22 ` Jeffy Chen
[not found] ` <20180111082229.24011-3-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-11 15:47 ` Robin Murphy
2018-01-11 15:47 ` Robin Murphy
2018-01-11 15:47 ` Robin Murphy
2018-01-12 0:33 ` JeffyChen [this message]
2018-01-12 0:33 ` JeffyChen
2018-01-11 8:22 ` [PATCH 3/9] iommu/rockchip: Fix error handling in probe Jeffy Chen
2018-01-11 8:22 ` Jeffy Chen
2018-01-11 8:22 ` [PATCH 4/9] iommu/rockchip: Fix error handling in init Jeffy Chen
2018-01-11 8:22 ` Jeffy Chen
2018-01-11 8:22 ` [PATCH 5/9] iommu/rockchip: Use iopoll helpers to wait for hardware Jeffy Chen
2018-01-11 8:22 ` Jeffy Chen
2018-01-11 8:22 ` [PATCH 6/9] iommu/rockchip: Fix TLB flush of secondary IOMMUs Jeffy Chen
2018-01-11 8:22 ` Jeffy Chen
[not found] ` <20180111082229.24011-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-11 8:22 ` [PATCH 7/9] iommu/rockchip: Use iommu_group_get_for_dev() for add_device Jeffy Chen
2018-01-11 8:22 ` Jeffy Chen
2018-01-11 8:22 ` Jeffy Chen
2018-01-11 8:22 ` [PATCH 8/9] iommu/rockchip: Use IOMMU device for dma mapping operations Jeffy Chen
2018-01-11 8:22 ` Jeffy Chen
2018-01-11 8:22 ` [PATCH 9/9] iommu/rockchip: Use OF_IOMMU to attach devices automatically Jeffy Chen
2018-01-11 8:22 ` Jeffy Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A58024D.2010402@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jcliang@chromium.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.