All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Morse <james.morse@arm.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] firmware: arm_sdei: Fix return value check in sdei_present_dt()
Date: Mon, 15 Jan 2018 10:38:06 +0000	[thread overview]
Message-ID: <5A5C848E.70304@arm.com> (raw)
In-Reply-To: <1516012913-196560-1-git-send-email-weiyongjun1@huawei.com>

Hi Wei,

On 15/01/18 10:41, Wei Yongjun wrote:
> In case of error, the function of_platform_device_create() returns
> NULL pointer not ERR_PTR(). The IS_ERR() test in the return value
> check should be replaced with NULL test.

Bother, so it does!

Thanks for catching this.
Acked-by: James Morse <james.morse@arm.com>


Thanks,

James


WARNING: multiple messages have this Message-ID (diff)
From: james.morse@arm.com (James Morse)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] firmware: arm_sdei: Fix return value check in sdei_present_dt()
Date: Mon, 15 Jan 2018 10:38:06 +0000	[thread overview]
Message-ID: <5A5C848E.70304@arm.com> (raw)
In-Reply-To: <1516012913-196560-1-git-send-email-weiyongjun1@huawei.com>

Hi Wei,

On 15/01/18 10:41, Wei Yongjun wrote:
> In case of error, the function of_platform_device_create() returns
> NULL pointer not ERR_PTR(). The IS_ERR() test in the return value
> check should be replaced with NULL test.

Bother, so it does!

Thanks for catching this.
Acked-by: James Morse <james.morse@arm.com>


Thanks,

James

WARNING: multiple messages have this Message-ID (diff)
From: James Morse <james.morse@arm.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
	Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] firmware: arm_sdei: Fix return value check in sdei_present_dt()
Date: Mon, 15 Jan 2018 10:38:06 +0000	[thread overview]
Message-ID: <5A5C848E.70304@arm.com> (raw)
In-Reply-To: <1516012913-196560-1-git-send-email-weiyongjun1@huawei.com>

Hi Wei,

On 15/01/18 10:41, Wei Yongjun wrote:
> In case of error, the function of_platform_device_create() returns
> NULL pointer not ERR_PTR(). The IS_ERR() test in the return value
> check should be replaced with NULL test.

Bother, so it does!

Thanks for catching this.
Acked-by: James Morse <james.morse@arm.com>


Thanks,

James

  reply	other threads:[~2018-01-15 10:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 10:41 [PATCH -next] firmware: arm_sdei: Fix return value check in sdei_present_dt() Wei Yongjun
2018-01-15 10:41 ` Wei Yongjun
2018-01-15 10:41 ` Wei Yongjun
2018-01-15 10:38 ` James Morse [this message]
2018-01-15 10:38   ` James Morse
2018-01-15 10:38   ` James Morse
2018-01-15 18:17 ` Catalin Marinas
2018-01-15 18:17   ` Catalin Marinas
2018-01-15 18:17   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A5C848E.70304@arm.com \
    --to=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.